feat: unify history tools and improve execution reliability

tests/unit/test_ui_command.py

@@ -6,12 +6,21 @@
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
 
+import io
 import os
+import subprocess
+import sys
+
+import pytest
+from rich.console import Console
 
 from artemis.interfaces.cli.commands import ui
 from artemis.interfaces.cli.commands.ui import (
+    _npm_install_required,
     _resolve_npm_executable,
+    _run_build_step,
     _showcase_build_required,
+    ensure_showcase_built,
 )
 
 
@@ -64,3 +73,111 @@ def test_showcase_build_not_required_when_build_is_current(tmp_path):
     os.utime(built_index, (200, 200))
 
     assert _showcase_build_required(showcase_dir) is False
+
+
+def _showcase_with_manifests(tmp_path, *, stamp_mtime=None):
+    showcase_dir = tmp_path / "showcase_ui"
+    showcase_dir.mkdir()
+    for name in ("package.json", "package-lock.json"):
+        path = showcase_dir / name
+        path.write_text("{}", encoding="utf-8")
+        os.utime(path, (100, 100))
+    if stamp_mtime is not None:
+        stamp = showcase_dir / "node_modules" / ".package-lock.json"
+        stamp.parent.mkdir()
+        stamp.write_text("{}", encoding="utf-8")
+        os.utime(stamp, (stamp_mtime, stamp_mtime))
+    return showcase_dir
+
+
+def test_npm_install_required_when_node_modules_missing(tmp_path):
+    assert _npm_install_required(_showcase_with_manifests(tmp_path)) is True
+
+
+def test_npm_install_not_required_when_lock_stamp_is_current(tmp_path):
+    assert _npm_install_required(_showcase_with_manifests(tmp_path, stamp_mtime=200)) is False
+
+
+def test_npm_install_required_when_package_lock_is_newer(tmp_path):
+    showcase_dir = _showcase_with_manifests(tmp_path, stamp_mtime=200)
+    os.utime(showcase_dir / "package-lock.json", (300, 300))
+
+    assert _npm_install_required(showcase_dir) is True
+
+
+def _recording_console():
+    return Console(file=io.StringIO(), force_terminal=False, width=120)
+
+
+def test_ensure_showcase_built_skips_install_when_deps_current(monkeypatch):
+    steps = []
+    monkeypatch.setattr(ui, "_showcase_build_required", lambda showcase_dir: True)
+    monkeypatch.setattr(ui, "_npm_install_required", lambda showcase_dir: False)
+    monkeypatch.setattr(ui, "_resolve_npm_executable", lambda: "npm")
+    monkeypatch.setattr(
+        ui, "_run_build_step", lambda console, label, cmd, cwd: steps.append((label, cmd))
+    )
+    console = _recording_console()
+
+    ensure_showcase_built(console)
+
+    assert [label for label, _ in steps] == ["② ng build"]
+    assert steps[0][1] == ["npm", "run", "build"]
+    assert "Showcase UI built in" in console.file.getvalue()
+
+
+def test_ensure_showcase_built_runs_install_first_when_deps_changed(monkeypatch):
+    steps = []
+    monkeypatch.setattr(ui, "_showcase_build_required", lambda showcase_dir: True)
+    monkeypatch.setattr(ui, "_npm_install_required", lambda showcase_dir: True)
+    monkeypatch.setattr(ui, "_resolve_npm_executable", lambda: "npm")
+    monkeypatch.setattr(
+        ui, "_run_build_step", lambda console, label, cmd, cwd: steps.append((label, cmd))
+    )
+
+    ensure_showcase_built(_recording_console())
+
+    assert [label for label, _ in steps] == ["① npm install (dependencies changed)", "② ng build"]
+    assert steps[0][1] == ["npm", "install", "--no-audit", "--no-fund", "--loglevel=warn"]
+
+
+def test_ensure_showcase_built_reports_failure_with_manual_command(monkeypatch):
+    monkeypatch.setattr(ui, "_showcase_build_required", lambda showcase_dir: True)
+    monkeypatch.setattr(ui, "_npm_install_required", lambda showcase_dir: False)
+    monkeypatch.setattr(ui, "_resolve_npm_executable", lambda: "npm")
+
+    def failing_step(console, label, cmd, cwd):
+        raise subprocess.CalledProcessError(1, cmd)
+
+    monkeypatch.setattr(ui, "_run_build_step", failing_step)
+    console = _recording_console()
+
+    ensure_showcase_built(console)  # must not raise: the server still starts
+
+    output = console.file.getvalue()
+    assert "Failed to auto-build Showcase UI" in output
+    assert "npm install && npm run build" in output
+
+
+def test_run_build_step_streams_child_output_and_raises_on_failure(tmp_path):
+    console = _recording_console()
+    cmd = [sys.executable, "-c", "print('hello from child'); import sys; sys.exit(3)"]
+
+    with pytest.raises(subprocess.CalledProcessError) as excinfo:
+        _run_build_step(console, "② ng build", cmd, tmp_path)
+
+    assert excinfo.value.returncode == 3
+    output = console.file.getvalue()
+    assert "② ng build" in output
+    assert "hello from child" in output
+
+
+def test_run_build_step_strips_ansi_and_succeeds(tmp_path):
+    console = _recording_console()
+    cmd = [sys.executable, "-c", "print('\\x1b[32mdone\\x1b[0m')"]
+
+    _run_build_step(console, "step", cmd, tmp_path)
+
+    output = console.file.getvalue()
+    assert "done" in output
+    assert "\x1b[32m" not in output