fix: correct task scheduling and simplify agent internals

Fix queue cancellation, concurrency limits and worker status updates.

Use direct Explorer imports, split the Diagnoser loop into helpers and remove unused tool registration and prompt-builder code.

Correct model caching, endpoint selection and retry handling.
This commit is contained in:
somew1nd committed 2026-09-02 22:58:00 -07:00
1 parent 67248c887e
commit 12d7902a82
92 files changed
+1085 -1763

No files matched your search

+1
View File
@@ -228,6 +228,7 @@ async def stop_task(
# Empty or non-JSON body: fall back to the query parameters. # Empty or non-JSON body: fall back to the query parameters.
pass pass
# stop_tasks updates scheduler state and asyncio events owned by this loop.
stopped = task_queue_service.stop_tasks( stopped = task_queue_service.stop_tasks(
clear_all=target_all, clear_all=target_all,
session_id=target_sid, session_id=target_sid,
+13 -3
View File
@@ -19,6 +19,7 @@ Modular entrypoint for full trace inspection, step replay, and task execution ma
import argparse import argparse
import asyncio import asyncio
from contextlib import asynccontextmanager
import os import os
from pathlib import Path from pathlib import Path
import secrets import secrets
@@ -95,8 +96,19 @@ except ImportError:
# Initialize language server synchronization address # Initialize language server synchronization address
init_ls_address() init_ls_address()
@asynccontextmanager
async def _lifespan(_app: "FastAPI"):
"""Start server resources and release them on shutdown."""
await on_startup()
try:
yield
finally:
await on_shutdown()
# Initialize FastAPI application # Initialize FastAPI application
app = FastAPI(title="Artemis Admin & Trace Console") app = FastAPI(title="Artemis Admin & Trace Console", lifespan=_lifespan)
LIFECYCLE_TOKEN = os.environ.get("ARTEMIS_LIFECYCLE_TOKEN") or secrets.token_urlsafe(32) LIFECYCLE_TOKEN = os.environ.get("ARTEMIS_LIFECYCLE_TOKEN") or secrets.token_urlsafe(32)
app.state.lifecycle_token = LIFECYCLE_TOKEN app.state.lifecycle_token = LIFECYCLE_TOKEN
@@ -106,7 +118,6 @@ app.state.lifecycle_token = LIFECYCLE_TOKEN
app.add_middleware(SameOriginBoundaryMiddleware) app.add_middleware(SameOriginBoundaryMiddleware)
@app.on_event("startup")
async def on_startup(): async def on_startup():
"""Startup lifecycle hooks.""" """Startup lifecycle hooks."""
state.is_shutting_down = False state.is_shutting_down = False
@@ -150,7 +161,6 @@ async def on_startup():
state.worker_task = asyncio.create_task(task_queue_service.queue_worker()) state.worker_task = asyncio.create_task(task_queue_service.queue_worker())
@app.on_event("shutdown")
async def on_shutdown(): async def on_shutdown():
"""Stop task and IPC children before the UI server exits.""" """Stop task and IPC children before the UI server exits."""
state.is_shutting_down = True state.is_shutting_down = True
@@ -343,40 +343,23 @@ class TaskQueueService:
pass pass
@classmethod @classmethod
def _concurrency_mode(cls) -> str: def _concurrency_limit(cls) -> int:
"""Resolve the scheduler concurrency mode. """Return 0 for per-device concurrency, or the global task limit."""
return DeviceExecutionLock.resolve_env_concurrency()
Mirrors DeviceExecutionLock's contract (ARTEMIS_CONCURRENCY_MODE /
ARTEMIS_MAX_CONCURRENT_TASKS):
- "global": strict serial -- one task at a time across all devices.
- "per_device": one task per device -- distinct devices run concurrently.
Defaults to per-device concurrency, matching the lock layer's default.
"""
mode = os.environ.get("ARTEMIS_CONCURRENCY_MODE", "").strip().lower()
if mode in ("global", "serial", "1"):
return "global"
if mode in ("per_device", "device", "parallel", "0"):
return "per_device"
try:
if int(os.environ.get("ARTEMIS_MAX_CONCURRENT_TASKS", 0) or 0) == 1:
return "global"
except (TypeError, ValueError):
pass
return "per_device"
@classmethod @classmethod
async def queue_worker(cls): async def queue_worker(cls):
"""Persistent dispatcher scheduling pending tasks onto devices. """Persistent dispatcher scheduling pending tasks onto devices.
Scans the queue and launches each eligible task as an independent Scans the queue and launches each eligible task as an independent
coroutine. Admission is governed by _concurrency_mode(): "global" admits coroutine. Admission is governed by _concurrency_limit(): 0 admits one
one task at a time overall, "per_device" admits one task per device so task per device so distinct devices execute concurrently, N>=1 admits
distinct devices execute concurrently. Per-device FIFO ordering and at most N tasks across all devices. Per-device FIFO ordering and
cross-process mutual exclusion remain enforced by DeviceExecutionLock cross-process mutual exclusion remain enforced by DeviceExecutionLock
inside each worker process. inside each worker process.
""" """
print( print(
f"[QueueWorker] Dispatcher initialized (concurrency mode: {cls._concurrency_mode()})." f"[QueueWorker] Dispatcher initialized (concurrency limit: {cls._concurrency_limit()})."
) )
try: try:
DeviceExecutionLock.cleanup_stale_locks() DeviceExecutionLock.cleanup_stale_locks()
@@ -404,10 +387,10 @@ class TaskQueueService:
@classmethod @classmethod
def _dispatch_pending_tasks(cls) -> None: def _dispatch_pending_tasks(cls) -> None:
"""Launch every pending task admissible under the current concurrency mode.""" """Launch every pending task admissible under the current concurrency limit."""
mode = cls._concurrency_mode() limit = cls._concurrency_limit()
state.prune_finished_runs() state.prune_finished_runs()
if mode == "global" and state.is_running: if limit == 1 and state.is_running:
return return
# Dispatched-but-not-yet-spawned runs are only visible as queue items in # Dispatched-but-not-yet-spawned runs are only visible as queue items in
@@ -416,6 +399,20 @@ class TaskQueueService:
in_flight = [ in_flight = [
i for i in state.queue_items if isinstance(i, dict) and i.get("status") == "running" i for i in state.queue_items if isinstance(i, dict) and i.get("status") == "running"
] ]
capacity = None
if limit >= 1:
# Registered workers still have running queue rows until finalization.
active_pids = {
getattr(run.get("process"), "pid", None) for run in state.active_runs.values()
} - {None}
starting = sum(
str(item.get("session_id")) not in state.active_runs
and item.get("pid") not in active_pids
for item in in_flight
)
capacity = limit - len(state.active_runs) - starting
if capacity <= 0:
return
busy_devices = state.busy_device_ids | { busy_devices = state.busy_device_ids | {
cls._task_target(i).lock_key for i in in_flight if i.get("device_serial") cls._task_target(i).lock_key for i in in_flight if i.get("device_serial")
} }
@@ -431,7 +428,7 @@ class TaskQueueService:
device = item.get("device_serial") device = item.get("device_serial")
target = cls._task_target(item) target = cls._task_target(item)
if mode == "per_device": if limit == 0:
# A task without a resolved device may bind to any serial, so it # A task without a resolved device may bind to any serial, so it
# only launches on an otherwise idle scheduler; the device lock # only launches on an otherwise idle scheduler; the device lock
# then allocates freely without contending against active runs. # then allocates freely without contending against active runs.
@@ -439,6 +436,9 @@ class TaskQueueService:
continue continue
if device is not None and target.lock_key in busy_devices: if device is not None and target.lock_key in busy_devices:
continue continue
elif limit > 1 and device is not None and target.lock_key in busy_devices:
# A second worker for this device would wait on its lock.
continue
item["status"] = "running" item["status"] = "running"
dispatched_any = True dispatched_any = True
@@ -449,8 +449,10 @@ class TaskQueueService:
# tasks, and a collected run would strand its queue item forever. # tasks, and a collected run would strand its queue item forever.
cls._run_tasks.add(run_task) cls._run_tasks.add(run_task)
run_task.add_done_callback(cls._run_tasks.discard) run_task.add_done_callback(cls._run_tasks.discard)
if mode == "global": if capacity is not None:
break capacity -= 1
if capacity <= 0:
break
@classmethod @classmethod
def _begin_task_run( def _begin_task_run(
@@ -584,10 +586,8 @@ class TaskQueueService:
} }
if sess_id: if sess_id:
try: try:
st = trace_store.read_status(str(sess_id)) # Preserve status updates written concurrently by the worker.
if st: trace_store.update_trace_pid(str(sess_id), proc.pid)
st["pid"] = proc.pid
trace_store.write_status(str(sess_id), st)
except OSError as exc: except OSError as exc:
# Status probes fall back to DB PID bookkeeping, but note it. # Status probes fall back to DB PID bookkeeping, but note it.
print( print(
@@ -595,15 +595,22 @@ class TaskQueueService:
) )
cls._broadcast_startup_progress(sess_id, "process_ready", "Execution process started") cls._broadcast_startup_progress(sess_id, "process_ready", "Execution process started")
ingress_type = str(task_item.get("ingress", "frontend")) ingress_type = str(task_item.get("ingress", "frontend"))
DeviceExecutionLock.transfer_reservation( queue_ticket = task_item.get("queue_ticket")
str(task_item.get("queue_ticket")), if queue_ticket:
proc.pid, transferred = DeviceExecutionLock.transfer_reservation(
description=f"{ingress_type} task: {goal[:120]}", str(queue_ticket),
device_id=device_serial or "pending", proc.pid,
session_id=str(sess_id) if sess_id else None, description=f"{ingress_type} task: {goal[:120]}",
ingress=ingress_type, device_id=device_serial or "pending",
lock_scope=target.lock_scope, session_id=str(sess_id) if sess_id else None,
) ingress=ingress_type,
lock_scope=target.lock_scope,
)
if not transferred:
print(
f"[QueueWorker] Could not transfer queue ticket {queue_ticket} to worker"
f" pid {proc.pid}; the worker will queue a fresh ticket itself."
)
@classmethod @classmethod
def _start_output_forwarder( def _start_output_forwarder(
@@ -876,8 +883,19 @@ class TaskQueueService:
if proc is not None and proc.returncode is None: if proc is not None and proc.returncode is None:
await cls._terminate_worker_process(proc) await cls._terminate_worker_process(proc)
raise raise
except Exception as e: except Exception:
print(f"[QueueWorker] Unexpected error executing task [{sess_id}]: {e}") logger.exception(f"[QueueWorker] Unexpected error executing task [{sess_id}]")
# A spawn failure must also leave a terminal session status.
if sess_id:
try:
new_status = await cls._persist_terminal_session_status(
sess_id, returncode=1, manual_stop=False
)
cls._announce_session_end(task_item, sess_id, goal or "", new_status, False)
except (OSError, RuntimeError, ValueError):
logger.exception(
f"[QueueWorker] Could not persist failure status for [{sess_id}]"
)
finally: finally:
await cls._finish_output_forwarder(output_task) await cls._finish_output_forwarder(output_task)
# 5. Clean up the finished task and release this run's scheduling slot # 5. Clean up the finished task and release this run's scheduling slot
@@ -989,14 +1007,8 @@ class TaskQueueService:
) -> dict[str, Any]: ) -> dict[str, Any]:
"""Reserve a device slot and build one pending queue item for a goal.""" """Reserve a device slot and build one pending queue item for a goal."""
sess_id = single_session_id if single_session_id else str(uuid.uuid4()) sess_id = single_session_id if single_session_id else str(uuid.uuid4())
# enqueue_tasks resolves the device before creating queue items.
assigned_serial = device_serial assigned_serial = device_serial
if not assigned_serial:
try:
from artemis.runtime import device_pool
assigned_serial = device_pool.select_device()
except Exception:
assigned_serial = None
queue_ticket = DeviceExecutionLock.reserve( queue_ticket = DeviceExecutionLock.reserve(
description=f"{ingress} task: {goal[:120]}", description=f"{ingress} task: {goal[:120]}",
@@ -1068,6 +1080,14 @@ class TaskQueueService:
return rejection_response return rejection_response
single_session_id = session_id if (session_id and len(goals) == 1) else None single_session_id = session_id if (session_id and len(goals) == 1) else None
if not device_serial:
# Device enumeration may block on ADB.
from artemis.runtime import device_pool
try:
device_serial = await device_pool.select_device_async()
except Exception:
device_serial = None
for i, goal in enumerate(goals): for i, goal in enumerate(goals):
task_item = cls._create_queue_item( task_item = cls._create_queue_item(
goal, goal,
@@ -1426,10 +1446,8 @@ class TaskQueueService:
global_queued = DeviceExecutionLock.get_queued_tasks() global_queued = DeviceExecutionLock.get_queued_tasks()
for q_item in global_queued: for q_item in global_queued:
if str(q_item.get("session_id")) == target_sid: if str(q_item.get("session_id")) == target_sid:
ticket = q_item.get("queue_ticket") # get_queued_tasks exposes the reservation as "token".
if ticket: stopped = DeviceExecutionLock.cancel_reservation(q_item.get("token"))
DeviceExecutionLock.cancel_reservation(ticket)
stopped = True
break break
# Fallback 2: check session repository for a running session with a live worker PID # Fallback 2: check session repository for a running session with a live worker PID
if not stopped: if not stopped:
-3
View File
@@ -22,7 +22,6 @@ from artemis_client import Capabilities, Device, TaskHandle, TaskResult
from artemis.sdk.agent import Agent from artemis.sdk.agent import Agent
from artemis.sdk.builders import Builders from artemis.sdk.builders import Builders
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.tools.base import artemis_tool, ToolRegistry
__all__ = [ __all__ = [
"__version__", "__version__",
@@ -38,6 +37,4 @@ __all__ = [
"TaskHandle", "TaskHandle",
"TaskResult", "TaskResult",
"BaseDeviceDriver", "BaseDeviceDriver",
"artemis_tool",
"ToolRegistry",
] ]
+392 -330
View File
@@ -20,7 +20,7 @@ from pathlib import Path
from typing import Any from typing import Any
import uuid import uuid
from langchain_core.messages import HumanMessage, SystemMessage, ToolMessage from langchain_core.messages import BaseMessage, HumanMessage, SystemMessage, ToolMessage
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.data_engine.trace import ( from artemis.data_engine.trace import (
@@ -52,6 +52,12 @@ from artemis.utils.task_tree import (
logger = get_logger(__name__) logger = get_logger(__name__)
_MAX_ITERATIONS = 30
_FINAL_TURN_WARNING = (
"[WARNING] This is your final iteration. Call 'submit_answer' to provide your final diagnosis."
)
class Diagnoser: class Diagnoser:
def __init__(self, ctx: ArtemisContext): def __init__(self, ctx: ArtemisContext):
@@ -69,11 +75,8 @@ class Diagnoser:
except Exception: except Exception:
return False return False
@trace(type="agent", name="diagnoser") def _load_prompt_config(self) -> tuple[str, str]:
async def run(self, prompt: str, state: State) -> str: """Loads the system prompt and checker-feedback template from disk."""
"""Runs the Diagnoser and returns its summary."""
# 1. Load prompt
prompt_path = Path(__file__).parent.joinpath("diagnoser.json") prompt_path = Path(__file__).parent.joinpath("diagnoser.json")
if not prompt_path.exists(): if not prompt_path.exists():
raise FileNotFoundError(f"Prompt file not found at {prompt_path}") raise FileNotFoundError(f"Prompt file not found at {prompt_path}")
@@ -87,27 +90,18 @@ class Diagnoser:
checker_feedback_template = prompt_data.get("checker_feedback_template", "") checker_feedback_template = prompt_data.get("checker_feedback_template", "")
if isinstance(checker_feedback_template, list): if isinstance(checker_feedback_template, list):
checker_feedback_template = "\n".join(checker_feedback_template) checker_feedback_template = "\n".join(checker_feedback_template)
return system_prompt, checker_feedback_template
# 2. Prepare LLM def _build_traced_tools(self) -> list:
llm = get_llm(ctx=self.ctx, name="diagnoser") """Assembles the tool set (honoring the offline/video gates) and wraps it in tracing."""
log_tool = get_analyze_logs_tool(self.ctx)
read_note_tool = get_read_note_tool(self.ctx)
list_notes_tool = get_list_notes_tool(self.ctx)
adb_command_tool = get_run_short_adb_command_tool(self.ctx)
wait_tool = get_wait_tool(self.ctx)
ui_hierarchy_tool = get_ui_hierarchy_tool(self.ctx)
submit_answer_tool = get_submit_answer_tool(self.ctx)
all_tools = [ all_tools = [
log_tool, get_analyze_logs_tool(self.ctx),
read_note_tool, get_read_note_tool(self.ctx),
list_notes_tool, get_list_notes_tool(self.ctx),
adb_command_tool, get_run_short_adb_command_tool(self.ctx),
wait_tool, get_wait_tool(self.ctx),
ui_hierarchy_tool, get_ui_hierarchy_tool(self.ctx),
submit_answer_tool, get_submit_answer_tool(self.ctx),
] ]
if not self.is_device_online: if not self.is_device_online:
logger.info( logger.info(
@@ -123,17 +117,12 @@ class Diagnoser:
] ]
if self.ctx.execution_setup and self.ctx.execution_setup.video_recording_tools_enabled: if self.ctx.execution_setup and self.ctx.execution_setup.video_recording_tools_enabled:
video_tool = get_video_analyzer_tool(self.ctx, role="diagnoser") all_tools.append(get_video_analyzer_tool(self.ctx, role="diagnoser"))
all_tools.append(video_tool)
traced_tools = [trace_langchain_tool(t, self.ctx) for t in all_tools] return [trace_langchain_tool(t, self.ctx) for t in all_tools]
# Bind custom tools
base_llm = llm
# 4. Get context from DataEngine and State
initial_goal = state.initial_goal
def _build_plan_and_history(self) -> str:
"""Renders the task plan and recent step history from the DataEngine."""
task_plan = "No task plan yet." task_plan = "No task plan yet."
steps = [] steps = []
subgoal_hash = "default" subgoal_hash = "default"
@@ -153,7 +142,6 @@ class Diagnoser:
steps = self.ctx.data_engine.get_agent_friendly_steps() steps = self.ctx.data_engine.get_agent_friendly_steps()
# Build task tree
plan_and_history = "No plan or history available." plan_and_history = "No plan or history available."
if self.ctx.data_engine and task_plan != "No task plan yet.": if self.ctx.data_engine and task_plan != "No task plan yet.":
try: try:
@@ -174,30 +162,38 @@ class Diagnoser:
except Exception as e: except Exception as e:
logger.error(f"Failed to build plan and history in Diagnoser: {e}") logger.error(f"Failed to build plan and history in Diagnoser: {e}")
plan_and_history = f"Error building plan and history: {e}" plan_and_history = f"Error building plan and history: {e}"
return plan_and_history
# Get verification findings injected by the checkpoint harvest, if any def _collect_checker_feedback(self, state: State) -> str:
checker_feedback = "" """Renders verification findings injected by the checkpoint harvest, if any."""
findings = getattr(state, "operator_feedback", None) findings = getattr(state, "operator_feedback", None)
if findings: if findings:
checker_feedback = "\n".join(f"- {f}" for f in findings) return "\n".join(f"- {f}" for f in findings)
return ""
# Get Current Screenshot and UI Hierarchy
latest_screenshot_b64 = None
minimal_list = ""
def _read_screenshot_b64(self, state: State) -> str | None:
"""Reads the latest screenshot as base64, or ``None`` when unavailable."""
if state.latest_screenshot and os.path.exists(state.latest_screenshot): if state.latest_screenshot and os.path.exists(state.latest_screenshot):
try: try:
with open(state.latest_screenshot, "rb") as f: with open(state.latest_screenshot, "rb") as f:
latest_screenshot_b64 = base64.b64encode(f.read()).decode("utf-8") return base64.b64encode(f.read()).decode("utf-8")
except Exception as e: except Exception as e:
logger.error(f"Failed to read latest screenshot in Diagnoser: {e}") logger.error(f"Failed to read latest screenshot in Diagnoser: {e}")
return None
if state.latest_ui_hierarchy: def _build_initial_messages(
minimal_list = self._format_minimal_list(state.latest_ui_hierarchy) self,
prompt: str,
# Construct rich human message state: State,
system_prompt: str,
checker_feedback_template: str,
plan_and_history: str,
checker_feedback: str,
minimal_list: str,
) -> list[BaseMessage]:
"""Build the initial prompt with history, device state and screenshot."""
content = [] content = []
content.append({"type": "text", "text": f"Initial Goal: {initial_goal}\n"}) content.append({"type": "text", "text": f"Initial Goal: {state.initial_goal}\n"})
content.append( content.append(
{ {
"type": "text", "type": "text",
@@ -217,6 +213,7 @@ class Diagnoser:
} }
) )
latest_screenshot_b64 = self._read_screenshot_b64(state)
if latest_screenshot_b64: if latest_screenshot_b64:
content.append({"type": "text", "text": "--- Current Screenshot ---"}) content.append({"type": "text", "text": "--- Current Screenshot ---"})
content.append( content.append(
@@ -228,117 +225,358 @@ class Diagnoser:
content.append({"type": "text", "text": f"--- Diagnostic Query ---\n{prompt}"}) content.append({"type": "text", "text": f"--- Diagnostic Query ---\n{prompt}"})
current_messages = [ return [
SystemMessage(content=system_prompt), SystemMessage(content=system_prompt),
HumanMessage(content=content), HumanMessage(content=content),
] ]
self.ctx.background_jobs = {} async def _await_running_jobs(self) -> None:
"""Blocks until every still-running background job has settled."""
running_jobs = [
job for job in self.ctx.background_jobs.values() if job.get("status") == "running"
]
if running_jobs:
await asyncio.gather(
*(job["task"] for job in running_jobs if job.get("task") is not None),
return_exceptions=True,
)
max_iterations = 30 def _drain_finished_jobs(self) -> list[ToolMessage]:
"""Converts finished, unconsumed background jobs into tool messages."""
new_tool_messages = []
for job in self.ctx.background_jobs.values():
if job.get("status") in (
"completed",
"failed",
) and not job.get("consumed", False):
tm_status = "success" if job["status"] == "completed" else "error"
tm = ToolMessage(
tool_call_id=job["tool_call_id"],
content=job["result"] or "",
status=tm_status,
)
new_tool_messages.append(tm)
job["consumed"] = True
return new_tool_messages
def _cancel_running_jobs(self) -> None:
"""Cancels any background job still running when the loop exits."""
for job in self.ctx.background_jobs.values():
if job.get("status") == "running" and job.get("task") is not None:
job["task"].cancel()
def _prepare_iteration_llm(
self,
base_llm,
traced_tools: list,
iteration: int,
current_messages: list[BaseMessage],
):
"""Appends the iteration notice and binds the tools available this turn.
The final iteration is restricted to ``submit_answer`` so the model
must conclude; earlier iterations get a progress nudge and the full
tool set.
"""
if iteration == _MAX_ITERATIONS - 1:
current_messages.append(HumanMessage(content=_FINAL_TURN_WARNING))
submit_tool = next(
(t for t in traced_tools if t.name == "submit_answer"),
None,
)
return base_llm.bind_tools(tools=[submit_tool] if submit_tool else [])
if iteration > 0:
current_messages.append(
HumanMessage(
content=(
"You have not completed the diagnosis yet"
f" (iteration {iteration + 1} of {_MAX_ITERATIONS})."
)
)
)
return base_llm.bind_tools(tools=traced_tools)
def _token_usage_payload(self, response) -> dict | None:
"""Extracts token-usage counters from the response metadata, if present."""
if not hasattr(response, "usage_metadata") or response.usage_metadata is None:
return None
usage = response.usage_metadata
if isinstance(usage, dict):
prompt_token_count = usage.get("prompt_token_count")
candidates_token_count = usage.get("candidates_token_count")
cached_content_token_count = usage.get("cached_content_token_count")
else:
prompt_token_count = getattr(usage, "prompt_token_count", None)
candidates_token_count = getattr(usage, "candidates_token_count", None)
cached_content_token_count = getattr(usage, "cached_content_token_count", None)
return {
"prompt_token_count": prompt_token_count,
"candidates_token_count": candidates_token_count,
"cached_content_token_count": (cached_content_token_count),
}
async def _invoke_model(
self,
llm,
current_messages: list[BaseMessage],
context_components: dict,
):
"""Invokes the model inside a trace span carrying the context payload."""
with TraceSpan(name="gemini_diagnoser_call", ctx=self.ctx) as span:
span.payload = {"context_components": context_components}
response = await invoke_llm_with_timeout_message(acomplete(llm, current_messages))
span.result = response.content if hasattr(response, "content") else str(response)
token_usage = self._token_usage_payload(response)
if token_usage is not None:
if span.payload is None:
span.payload = {}
span.payload["token_usage"] = token_usage
return response
def _find_submit_call(self, tool_calls: list) -> dict | None:
"""Finds a ``submit_answer`` call among the response's tool calls."""
return next(
(
tc
for tc in tool_calls
if tc["name"] == "submit_answer" or tc["name"].endswith(":submit_answer")
),
None,
)
def _handle_submit_call(self, submit_call: dict, traced_tools: list) -> str:
"""Records the submitted answer and renders it as the run's outcome."""
args = submit_call["args"]
analysis = args.get("analysis", "No analysis provided.")
steps = args.get("actionable_steps", [])
submit_tool = next(
(
t
for t in traced_tools
if t.name == "submit_answer" or t.name.endswith(":submit_answer")
),
None,
)
if submit_tool:
submit_tool.invoke(args)
outcome = f"Analysis: {analysis} | Actionable Steps: "
for step in steps:
outcome += f"{step} "
return outcome
def _max_iteration_outcome(self, response, outcome: str) -> str:
"""Renders the outcome when the loop cap is hit with tool calls pending."""
tool_names = ", ".join(tc["name"] for tc in response.tool_calls)
warning = (
"\n\n[Warning: Diagnoser reached the maximum iteration"
f" limit of {_MAX_ITERATIONS} and could not execute"
f" tool(s): {tool_names}]"
)
if outcome == "No result":
return (
"Diagnoser reached the maximum iteration limit of"
f" {_MAX_ITERATIONS} while attempting to call tools:"
f" {tool_names}"
)
return outcome + warning
async def _run_video_job(self, job_id: str, tc: dict, traced_tools: list, state: State) -> None:
"""Runs a ``video_analyzer`` call in the background and records its result."""
try:
tool_to_run = next(
(t for t in traced_tools if t.name == "video_analyzer"),
None,
)
if tool_to_run:
args = dict(tc["args"])
result_obj = await invoke_tool_with_injection(
tool=tool_to_run,
args=args,
tool_call_id=tc["id"],
state=state,
)
result_content = get_tool_result_content(result_obj)
self.ctx.background_jobs[job_id]["result"] = result_content
self.ctx.background_jobs[job_id]["status"] = "completed"
if self.ctx.data_engine:
self.ctx.data_engine.unregister_background_task(
task_id=job_id,
status="completed",
)
else:
self.ctx.background_jobs[job_id]["result"] = "Error: video_analyzer tool not found"
self.ctx.background_jobs[job_id]["status"] = "failed"
if self.ctx.data_engine:
self.ctx.data_engine.unregister_background_task(task_id=job_id, status="failed")
except asyncio.CancelledError:
logger.info(f"Background job {job_id} cancelled.")
raise
except Exception as e:
logger.error(f"Background job {job_id} failed: {e}")
self.ctx.background_jobs[job_id]["result"] = str(e)
self.ctx.background_jobs[job_id]["status"] = "failed"
if self.ctx.data_engine:
self.ctx.data_engine.unregister_background_task(task_id=job_id, status="failed")
def _start_video_job(self, tc: dict, traced_tools: list, state: State) -> ToolMessage:
"""Registers a background job for ``video_analyzer`` and acknowledges it."""
job_id = f"job_{uuid.uuid4().hex}"
self.ctx.background_jobs[job_id] = {
"tool_call_id": tc["id"],
"status": "running",
"result": None,
"consumed": False,
"task": None,
}
if self.ctx.data_engine:
self.ctx.data_engine.register_background_task(
task_id=job_id,
summary=(f"Diagnoser Video Analyzer Tool Call: {tc['id']}"),
)
task = asyncio.create_task(self._run_video_job(job_id, tc, traced_tools, state))
self.ctx.background_jobs[job_id]["task"] = task
return ToolMessage(
tool_call_id=tc["id"],
content=(
f"Video analyzer started. Job ID: {job_id}."
" [Warning] No background logs, status"
" updates, or errors will be logged."
),
status="success",
)
async def _run_tool(self, tc: dict, traced_tools: list, state: State) -> ToolMessage:
"""Executes one requested tool call and wraps its result as a tool message."""
tool_name = tc["name"].split(":")[-1] if ":" in tc["name"] else tc["name"]
logger.info(f"Diagnoser requested tool: {tool_name}")
result = ""
status = "success"
try:
if tool_name == "video_analyzer":
return self._start_video_job(tc, traced_tools, state)
if ":" in tool_name:
tool_to_run = get_tool_by_name(tool_name, traced_tools)
else:
tool_to_run = next(
(t for t in traced_tools if t.name == tool_name),
None,
)
if tool_to_run:
args = dict(tc["args"])
with TraceSpan(name=tool_name, ctx=self.ctx) as span:
span.payload = {"args": args}
try:
result_obj = await invoke_tool_with_injection(
tool=tool_to_run,
args=args,
tool_call_id=tc["id"],
state=state,
)
result = get_tool_result_content(result_obj)
if isinstance(result, list):
result_str = "\n".join(map(str, result))
elif not isinstance(result, str):
result_str = str(result)
else:
result_str = result
span.result = result
if result_str.startswith("Error"):
status = "error"
span.status = "failed"
span.error = result
except Exception as e:
status = "error"
span.status = "failed"
span.error = str(e)
raise e
else:
result = f"Error: Tool {tool_name} not supported"
status = "error"
except Exception as e:
logger.error(f"Error running tool {tool_name}: {e}")
result = f"Error running tool {tool_name}: {e}"
status = "error"
return ToolMessage(
tool_call_id=tc["id"],
content=result,
status=status,
)
async def _execute_tool_calls(
self, tool_calls: list, traced_tools: list, state: State
) -> list[ToolMessage]:
"""Executes all requested tools in parallel, skipping ``google_search``."""
active_tool_calls = [
tc
for tc in tool_calls
if (tc["name"].split(":")[-1] if ":" in tc["name"] else tc["name"]) != "google_search"
]
return list(
await asyncio.gather(
*(self._run_tool(tc, traced_tools, state) for tc in active_tool_calls)
)
)
@trace(type="agent", name="diagnoser")
async def run(self, prompt: str, state: State) -> str:
"""Runs the Diagnoser and returns its summary."""
system_prompt, checker_feedback_template = self._load_prompt_config()
base_llm = get_llm(ctx=self.ctx, name="diagnoser")
traced_tools = self._build_traced_tools()
plan_and_history = self._build_plan_and_history()
checker_feedback = self._collect_checker_feedback(state)
minimal_list = (
self._format_minimal_list(state.latest_ui_hierarchy)
if state.latest_ui_hierarchy
else ""
)
current_messages = self._build_initial_messages(
prompt,
state,
system_prompt,
checker_feedback_template,
plan_and_history,
checker_feedback,
minimal_list,
)
context_components = {
"system_prompt": system_prompt,
"plan_and_history": plan_and_history,
"checker_feedback": checker_feedback,
"visible_ui_elements": minimal_list,
"diagnostic_query": prompt,
}
self.ctx.background_jobs = {}
outcome = "No result" outcome = "No result"
try: try:
for i in range(max_iterations): for i in range(_MAX_ITERATIONS):
# 5. Agent Loop Injection & Final Turn Guard # Include background results before asking for the final answer.
if i == max_iterations - 1: if i == _MAX_ITERATIONS - 1:
# Identify all jobs in the registry with status "running" await self._await_running_jobs()
running_jobs = [
job
for job in self.ctx.background_jobs.values()
if job.get("status") == "running"
]
if running_jobs:
# Await all associated task objects
await asyncio.gather(
*(job["task"] for job in running_jobs if job.get("task") is not None),
return_exceptions=True,
)
# Iterate through the background_jobs registry for all jobs where status is "completed" or "failed" and consumed is false
new_tool_messages = []
for job in self.ctx.background_jobs.values():
if job.get("status") in (
"completed",
"failed",
) and not job.get("consumed", False):
tm_status = "success" if job["status"] == "completed" else "error"
tm = ToolMessage(
tool_call_id=job["tool_call_id"],
content=job["result"] or "",
status=tm_status,
)
new_tool_messages.append(tm)
job["consumed"] = True
new_tool_messages = self._drain_finished_jobs()
if new_tool_messages: if new_tool_messages:
current_messages.extend(new_tool_messages) current_messages.extend(new_tool_messages)
if i == max_iterations - 1: llm = self._prepare_iteration_llm(base_llm, traced_tools, i, current_messages)
current_messages.append(
HumanMessage(
content=(
"[WARNING] This is your final iteration. Call"
" 'submit_answer' to provide your final"
" diagnosis."
)
)
)
submit_tool = next(
(t for t in traced_tools if t.name == "submit_answer"),
None,
)
llm = base_llm.bind_tools(tools=[submit_tool] if submit_tool else [])
else:
if i > 0:
current_messages.append(
HumanMessage(
content=(
"You have not completed the diagnosis yet"
f" (iteration {i + 1} of {max_iterations})."
)
)
)
llm = base_llm.bind_tools(tools=traced_tools)
with TraceSpan(name="gemini_diagnoser_call", ctx=self.ctx) as span: response = await self._invoke_model(llm, current_messages, context_components)
span.payload = {
"context_components": {
"system_prompt": system_prompt,
"plan_and_history": plan_and_history,
"checker_feedback": checker_feedback,
"visible_ui_elements": minimal_list,
"diagnostic_query": prompt,
}
}
response = await invoke_llm_with_timeout_message(
acomplete(llm, current_messages)
)
span.result = (
response.content if hasattr(response, "content") else str(response)
)
if hasattr(response, "usage_metadata") and response.usage_metadata is not None:
usage = response.usage_metadata
if isinstance(usage, dict):
prompt_token_count = usage.get("prompt_token_count")
candidates_token_count = usage.get("candidates_token_count")
cached_content_token_count = usage.get("cached_content_token_count")
else:
prompt_token_count = getattr(usage, "prompt_token_count", None)
candidates_token_count = getattr(usage, "candidates_token_count", None)
cached_content_token_count = getattr(
usage, "cached_content_token_count", None
)
if span.payload is None:
span.payload = {}
span.payload["token_usage"] = {
"prompt_token_count": prompt_token_count,
"candidates_token_count": candidates_token_count,
"cached_content_token_count": (cached_content_token_count),
}
if response.content: if response.content:
outcome = response.content outcome = response.content
@@ -346,197 +584,21 @@ class Diagnoser:
if not response.tool_calls: if not response.tool_calls:
break break
submit_call = next( submit_call = self._find_submit_call(response.tool_calls)
(
tc
for tc in response.tool_calls
if tc["name"] == "submit_answer" or tc["name"].endswith(":submit_answer")
),
None,
)
if submit_call: if submit_call:
args = submit_call["args"] outcome = self._handle_submit_call(submit_call, traced_tools)
analysis = args.get("analysis", "No analysis provided.")
steps = args.get("actionable_steps", [])
submit_tool = next(
(
t
for t in traced_tools
if t.name == "submit_answer" or t.name.endswith(":submit_answer")
),
None,
)
if submit_tool:
submit_tool.invoke(args)
outcome = f"Analysis: {analysis} | Actionalble Steps: "
for step in steps:
outcome += f"{step} "
break break
if i == max_iterations - 1: if i == _MAX_ITERATIONS - 1:
tool_names = ", ".join(tc["name"] for tc in response.tool_calls) outcome = self._max_iteration_outcome(response, outcome)
warning = (
"\n\n[Warning: Diagnoser reached the maximum iteration"
f" limit of {max_iterations} and could not execute"
f" tool(s): {tool_names}]"
)
if outcome == "No result":
outcome = (
"Diagnoser reached the maximum iteration limit of"
f" {max_iterations} while attempting to call tools:"
f" {tool_names}"
)
else:
outcome += warning
break break
current_messages.append(response) current_messages.append(response)
current_messages.extend(
async def run_tool(tc): await self._execute_tool_calls(response.tool_calls, traced_tools, state)
tool_name = tc["name"].split(":")[-1] if ":" in tc["name"] else tc["name"] )
logger.info(f"Diagnoser requested tool: {tool_name}")
result = ""
status = "success"
try:
if tool_name == "video_analyzer":
job_id = f"job_{uuid.uuid4().hex}"
self.ctx.background_jobs[job_id] = {
"tool_call_id": tc["id"],
"status": "running",
"result": None,
"consumed": False,
"task": None,
}
if self.ctx.data_engine:
self.ctx.data_engine.register_background_task(
task_id=job_id,
summary=(f"Diagnoser Video Analyzer Tool Call: {tc['id']}"),
)
async def run_bg_job():
try:
tool_to_run = next(
(t for t in traced_tools if t.name == "video_analyzer"),
None,
)
if tool_to_run:
args = dict(tc["args"])
result_obj = await invoke_tool_with_injection(
tool=tool_to_run,
args=args,
tool_call_id=tc["id"],
state=state,
)
result_content = get_tool_result_content(result_obj)
self.ctx.background_jobs[job_id]["result"] = result_content
self.ctx.background_jobs[job_id]["status"] = "completed"
if self.ctx.data_engine:
self.ctx.data_engine.unregister_background_task(
task_id=job_id,
status="completed",
)
else:
self.ctx.background_jobs[job_id]["result"] = (
"Error: video_analyzer tool not found"
)
self.ctx.background_jobs[job_id]["status"] = "failed"
if self.ctx.data_engine:
self.ctx.data_engine.unregister_background_task(
task_id=job_id, status="failed"
)
except asyncio.CancelledError:
logger.info(f"Background job {job_id} cancelled.")
raise
except Exception as e:
logger.error(f"Background job {job_id} failed: {e}")
self.ctx.background_jobs[job_id]["result"] = str(e)
self.ctx.background_jobs[job_id]["status"] = "failed"
if self.ctx.data_engine:
self.ctx.data_engine.unregister_background_task(
task_id=job_id, status="failed"
)
task = asyncio.create_task(run_bg_job())
self.ctx.background_jobs[job_id]["task"] = task
return ToolMessage(
tool_call_id=tc["id"],
content=(
f"Video analyzer started. Job ID: {job_id}."
" [Warning] No background logs, status"
" updates, or errors will be logged."
),
status="success",
)
if ":" in tool_name:
tool_to_run = get_tool_by_name(tool_name, traced_tools)
else:
tool_to_run = next(
(t for t in traced_tools if t.name == tool_name),
None,
)
if tool_to_run:
args = dict(tc["args"])
with TraceSpan(name=tool_name, ctx=self.ctx) as span:
span.payload = {"args": args}
try:
result_obj = await invoke_tool_with_injection(
tool=tool_to_run,
args=args,
tool_call_id=tc["id"],
state=state,
)
result = get_tool_result_content(result_obj)
if isinstance(result, list):
result_str = "\n".join(map(str, result))
elif not isinstance(result, str):
result_str = str(result)
else:
result_str = result
span.result = result
if result_str.startswith("Error"):
status = "error"
span.status = "failed"
span.error = result
except Exception as e:
status = "error"
span.status = "failed"
span.error = str(e)
raise e
else:
result = f"Error: Tool {tool_name} not supported"
status = "error"
except Exception as e:
logger.error(f"Error running tool {tool_name}: {e}")
result = f"Error running tool {tool_name}: {e}"
status = "error"
return ToolMessage(
tool_call_id=tc["id"],
content=result,
status=status,
)
# Execute all requested tools in parallel
active_tool_calls = [
tc
for tc in response.tool_calls
if (tc["name"].split(":")[-1] if ":" in tc["name"] else tc["name"])
!= "google_search"
]
tool_outputs = await asyncio.gather(*(run_tool(tc) for tc in active_tool_calls))
for tm in tool_outputs:
current_messages.append(tm)
finally: finally:
# 6. Cleanup on Exit self._cancel_running_jobs()
for job in self.ctx.background_jobs.values():
if job.get("status") == "running" and job.get("task") is not None:
job["task"].cancel()
return outcome return outcome
-34
View File
@@ -1,34 +0,0 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Late-bound access to the ``artemis.agents.explorer.explorer`` facade module.
The Explorer implementation is split across several modules, but external
callers (and ``unittest.mock.patch`` targets in the test suite) address
collaborators such as ``settings``, ``StorageManager``, ``draw_dots``,
``get_llm`` etc. through the historical module path
``artemis.agents.explorer.explorer``. Split-out code therefore resolves those
names at call time via :func:`facade` instead of importing them directly, so
patches applied to the facade module keep affecting the split-out code.
The import happens inside the function (not at module top level) to stay safe
regardless of which module of the package is imported first.
"""
def facade():
"""Return the ``artemis.agents.explorer.explorer`` module object."""
import artemis.agents.explorer.explorer as explorer_module
return explorer_module
+3
View File
@@ -22,6 +22,9 @@ Explorer tier the user configured. Tier behavior lives in
ASK_EXPLORER_TOOL_NAME = "ask_explorer" ASK_EXPLORER_TOOL_NAME = "ask_explorer"
#: Model used when the LLM configuration carries no Explorer entry.
DEFAULT_EXPLORER_MODEL = "gemini-3.8-flash"
ASK_EXPLORER_DESCRIPTION = ( ASK_EXPLORER_DESCRIPTION = (
"[EXPLORER] Ask the UI Explorer to locate elements on the current screen" "[EXPLORER] Ask the UI Explorer to locate elements on the current screen"
" that are missing from the indexed element list or whose listed" " that are missing from the indexed element list or whose listed"
+7 -121
View File
@@ -12,26 +12,18 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
"""Explorer agent facade. """Explorer agent entry point.
This module is the stable entry point (and ``mock.patch`` target namespace) The :class:`Explorer` class combines the following modules:
for the Explorer agent. The implementation is split across sibling modules:
- ``tiers``: the flash / pro / ultra tier table (single source of truth). - ``tiers``: engine, tools and budgets for flash / pro / ultra.
- ``tool_declarations``: static tool schemas (universal + native). - ``tool_declarations``: static tool schemas (universal + native).
- ``perception_tools``: the ``exec_*`` perception/vision tool method group. - ``perception_tools``: the ``exec_*`` perception/vision tool method group.
- ``universal_runner``: the LangChain-based ``_run_universal`` loop. - ``universal_runner``: the LangChain-based ``_run_universal`` loop.
- ``run_setup``: flash mode and the pre-loop setup phases of ``run``. - ``run_setup``: flash mode and the pre-loop setup phases of ``run``.
- ``native_runner``: the native Gemini reasoning loop of ``run``. - ``native_runner``: the native Gemini reasoning loop of ``run``.
All historical module-level names (``settings``, ``StorageManager``,
``genai``, ``_run_object_detection``, ``draw_dots``, ``perform_ocr``,
``is_ocr_configured``, ``get_llm``, ``UNIVERSAL_EXPLORER_TOOLS``, ...) remain
importable and patchable here; split-out code resolves them through this
module at call time (see ``artemis.agents.explorer._facade``).
""" """
import asyncio
import json import json
import os import os
from typing import Any, Literal from typing import Any, Literal
@@ -39,6 +31,7 @@ from typing import Any, Literal
from google import genai from google import genai
from google.genai import types from google.genai import types
from artemis.agents.explorer.constants import DEFAULT_EXPLORER_MODEL
from artemis.agents.explorer.geometry import ( from artemis.agents.explorer.geometry import (
FALLBACK_SCREEN_SIZE, FALLBACK_SCREEN_SIZE,
is_valid_norm_point, is_valid_norm_point,
@@ -50,51 +43,18 @@ from artemis.agents.explorer.perception_tools import PerceptionToolsMixin
from artemis.agents.explorer.run_setup import RunSetupMixin from artemis.agents.explorer.run_setup import RunSetupMixin
from artemis.agents.explorer.screen_index import normalize_text, ScreenElement, ScreenIndex from artemis.agents.explorer.screen_index import normalize_text, ScreenElement, ScreenIndex
from artemis.agents.explorer.tiers import ExplorerTier, get_tier from artemis.agents.explorer.tiers import ExplorerTier, get_tier
from artemis.agents.explorer.tool_declarations import ( from artemis.agents.explorer.tool_declarations import NATIVE_EXPLORER_TOOL_DECLARATIONS
NATIVE_EXPLORER_TOOL_DECLARATIONS,
UNIVERSAL_EXPLORER_TOOLS,
)
from artemis.agents.explorer.universal_runner import UniversalRunnerMixin from artemis.agents.explorer.universal_runner import UniversalRunnerMixin
from artemis.agents.object_detector.object_detector import _run_object_detection
from artemis.config import settings from artemis.config import settings
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.data_engine.storage import StorageManager
from artemis.data_engine.trace import trace from artemis.data_engine.trace import trace
from artemis.graph.state import State from artemis.graph.state import State
from artemis.llm.reliability import (
LLMExhaustedError,
LLMPermanentError,
classify_failure,
retry_policy_for,
)
from artemis.services.llm import _record_llm_event, _record_llm_retry, get_llm
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
from artemis.utils.ocr_api import is_ocr_configured, perform_ocr from artemis.utils.ocr_api import is_ocr_configured
from artemis.utils.visualization import draw_dots
logger = get_logger(__name__) logger = get_logger(__name__)
#: Public surface plus the late-bound collaborators the split-out modules __all__ = ["Explorer"]
#: resolve through this facade (``mock.patch`` targets for the test suite).
__all__ = [
"DEFAULT_EXPLORER_MODEL",
"Explorer",
"NATIVE_EXPLORER_TOOL_DECLARATIONS",
"StorageManager",
"UNIVERSAL_EXPLORER_TOOLS",
"_generate_content_with_reliability",
"_run_object_detection",
"draw_dots",
"genai",
"get_llm",
"is_ocr_configured",
"logger",
"perform_ocr",
"settings",
]
#: Model used when the LLM configuration carries no Explorer entry.
DEFAULT_EXPLORER_MODEL = "gemini-3.8-flash"
#: Environment override for Gemini explicit context caching ("true" / "false"). #: Environment override for Gemini explicit context caching ("true" / "false").
CACHING_ENV_VAR = "ARTEMIS_EXPLORER_CACHING" CACHING_ENV_VAR = "ARTEMIS_EXPLORER_CACHING"
@@ -104,80 +64,6 @@ CACHING_ENV_VAR = "ARTEMIS_EXPLORER_CACHING"
LABEL_TOLERANCE_RATIO = 0.02 LABEL_TOLERANCE_RATIO = 0.02
async def _generate_content_with_reliability(operation, *, label: str = "Explorer model call"):
"""Run one native google-genai model call under the shared reliability layer.
Retry decisions are owned by ``classify_failure``/``retry_policy_for``
(artemis.llm.reliability) instead of a blanket exponential-backoff loop:
non-retryable categories (auth, bad request) are raised immediately as
``LLMPermanentError`` and exhausted retryable categories surface as
``LLMExhaustedError``. Only the retry/error-classification policy is
centralized here; the google-genai transport itself stays untouched.
``operation`` must be a zero-argument callable returning a fresh awaitable
per attempt.
"""
attempt = 0
while True:
try:
return await operation()
except Exception as call_err:
attempt += 1
failure = classify_failure(call_err)
if not failure.retryable:
logger.error(f"{label} permanently failed [{failure.category.value}]: {call_err}")
_record_llm_event(
"llm_gave_up",
{
"source": "explorer",
"error": str(call_err)[:1000],
"category": failure.category.value,
"retryable": False,
},
status="failed",
)
raise LLMPermanentError(
f"{label} failed [{failure.category.value}]: {call_err}",
failure=failure,
cause=call_err,
) from call_err
policy = retry_policy_for(failure.category)
if attempt >= policy.max_attempts:
logger.error(
f"{label} exhausted {attempt} attempt(s) [{failure.category.value}]: {call_err}"
)
_record_llm_event(
"llm_gave_up",
{
"source": "explorer",
"error": str(call_err)[:1000],
"category": failure.category.value,
"retryable": True,
"attempts": attempt,
},
status="failed",
)
raise LLMExhaustedError(
f"{label} exhausted {attempt} attempt(s)"
f" [{failure.category.value}]: {call_err}",
failure=failure,
cause=call_err,
) from call_err
delay = policy.delay_for(attempt)
logger.warning(
f"{label} failed [{failure.category.value}] on attempt"
f" {attempt}/{policy.max_attempts}: {call_err}."
f" Retrying in {delay:.2f}s..."
)
_record_llm_retry(
str(call_err),
delay,
attempt=attempt,
max_retries=policy.max_attempts,
source="explorer",
)
await asyncio.sleep(delay)
class Explorer(PerceptionToolsMixin, UniversalRunnerMixin, RunSetupMixin, NativeRunnerMixin): class Explorer(PerceptionToolsMixin, UniversalRunnerMixin, RunSetupMixin, NativeRunnerMixin):
"""Locates UI elements on a screenshot for the ``ask_explorer`` tool. """Locates UI elements on a screenshot for the ``ask_explorer`` tool.
+99 -30
View File
@@ -19,9 +19,9 @@ loop and its named phases (model invocation, submit_answer interception and
validation, tool dispatching, failure mapping, resource cleanup), packaged as validation, tool dispatching, failure mapping, resource cleanup), packaged as
a mixin consumed by ``Explorer``. Every google-genai call goes through the a mixin consumed by ``Explorer``. Every google-genai call goes through the
SDK's ``client.aio`` surface so uploads, cache management and generation SDK's ``client.aio`` surface so uploads, cache management and generation
never block the event loop. Patched collaborators (``logger``, never block the event loop. This module also owns
``_generate_content_with_reliability``) are resolved through the facade :func:`_generate_content_with_reliability`, the shared reliability wrapper
module at call time; see ``artemis.agents.explorer._facade``. for native google-genai model calls.
""" """
import asyncio import asyncio
@@ -33,16 +33,94 @@ from typing import TYPE_CHECKING, Any
from google.genai import types from google.genai import types
from artemis.agents.explorer._facade import facade
from artemis.agents.explorer.geometry import is_valid_norm_point from artemis.agents.explorer.geometry import is_valid_norm_point
from artemis.agents.explorer.tiers import SUBMIT_TOOL from artemis.agents.explorer.tiers import SUBMIT_TOOL
from artemis.constants import SAFETY_SETTINGS_BLOCK_NONE from artemis.constants import SAFETY_SETTINGS_BLOCK_NONE
from artemis.data_engine.trace import TraceSpan from artemis.data_engine.trace import TraceSpan
from artemis.llm.reliability import (
LLMExhaustedError,
LLMPermanentError,
classify_failure,
retry_policy_for,
)
from artemis.services.llm import _record_llm_event, _record_llm_retry
from artemis.utils.logger import get_logger
logger = get_logger(__name__)
#: Loads a local image as a ``Part`` (inline bytes or a File API reference). #: Loads a local image as a ``Part`` (inline bytes or a File API reference).
ImagePartGetter = Callable[[str], Awaitable[types.Part]] ImagePartGetter = Callable[[str], Awaitable[types.Part]]
async def _generate_content_with_reliability(operation, *, label: str = "Explorer model call"):
"""Run one native google-genai model call under the shared reliability layer.
``operation`` must return a fresh awaitable on each call. Non-retryable
failures raise ``LLMPermanentError``; exhausted retries raise
``LLMExhaustedError`` according to the shared category policy.
"""
attempt = 0
while True:
try:
return await operation()
except Exception as call_err:
attempt += 1
failure = classify_failure(call_err)
if not failure.retryable:
logger.error(f"{label} permanently failed [{failure.category.value}]: {call_err}")
_record_llm_event(
"llm_gave_up",
{
"source": "explorer",
"error": str(call_err)[:1000],
"category": failure.category.value,
"retryable": False,
},
status="failed",
)
raise LLMPermanentError(
f"{label} failed [{failure.category.value}]: {call_err}",
failure=failure,
cause=call_err,
) from call_err
policy = retry_policy_for(failure.category)
if attempt >= policy.max_attempts:
logger.error(
f"{label} exhausted {attempt} attempt(s) [{failure.category.value}]: {call_err}"
)
_record_llm_event(
"llm_gave_up",
{
"source": "explorer",
"error": str(call_err)[:1000],
"category": failure.category.value,
"retryable": True,
"attempts": attempt,
},
status="failed",
)
raise LLMExhaustedError(
f"{label} exhausted {attempt} attempt(s)"
f" [{failure.category.value}]: {call_err}",
failure=failure,
cause=call_err,
) from call_err
delay = policy.delay_for(attempt)
logger.warning(
f"{label} failed [{failure.category.value}] on attempt"
f" {attempt}/{policy.max_attempts}: {call_err}."
f" Retrying in {delay:.2f}s..."
)
_record_llm_retry(
str(call_err),
delay,
attempt=attempt,
max_retries=policy.max_attempts,
source="explorer",
)
await asyncio.sleep(delay)
def _bare_tool_name(name: str) -> str: def _bare_tool_name(name: str) -> str:
"""Strips a namespace prefix (``ns:tool``) some models add to tool names.""" """Strips a namespace prefix (``ns:tool``) some models add to tool names."""
return name.split(":")[-1] if ":" in name else name return name.split(":")[-1] if ":" in name else name
@@ -145,9 +223,8 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
self, client, model_name: str, prompt_template: str, contents: list self, client, model_name: str, prompt_template: str, contents: list
): ):
"""Creates the explicit cache resource; returns None on failure.""" """Creates the explicit cache resource; returns None on failure."""
_ex = facade()
try: try:
_ex.logger.info("Creating cache resource for Explorer...") logger.info("Creating cache resource for Explorer...")
cached_content = await client.aio.caches.create( cached_content = await client.aio.caches.create(
model=model_name, model=model_name,
config=types.CreateCachedContentConfig( config=types.CreateCachedContentConfig(
@@ -163,10 +240,10 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
ttl="300s", ttl="300s",
), ),
) )
_ex.logger.info(f"Cache resource created successfully: {cached_content.name}") logger.info(f"Cache resource created successfully: {cached_content.name}")
return cached_content return cached_content
except Exception as cache_err: except Exception as cache_err:
_ex.logger.error(f"Failed to create cache resource: {cache_err}") logger.error(f"Failed to create cache resource: {cache_err}")
return None return None
async def _run_native( async def _run_native(
@@ -234,7 +311,6 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
max_turns: int, max_turns: int,
) -> str: ) -> str:
"""Main native reasoning loop: one model turn per iteration.""" """Main native reasoning loop: one model turn per iteration."""
_ex = facade()
turn = 0 turn = 0
agent_outcome = "" agent_outcome = ""
self.turn_latencies = [] self.turn_latencies = []
@@ -243,7 +319,7 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
while turn < max_turns: while turn < max_turns:
turn += 1 turn += 1
_ex.logger.info(f"Turn {turn}/{max_turns}: Invoking Native Gemini SDK for Explorer...") logger.info(f"Turn {turn}/{max_turns}: Invoking Native Gemini SDK for Explorer...")
self._prune_historical_images(contents, keep_last=1) self._prune_historical_images(contents, keep_last=1)
@@ -413,7 +489,6 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
thinking_level, thinking_level,
): ):
"""Invokes the model for one turn under a trace span; returns response and texts.""" """Invokes the model for one turn under a trace span; returns response and texts."""
_ex = facade()
ctx = self.ctx ctx = self.ctx
start_turn = time.perf_counter() start_turn = time.perf_counter()
with TraceSpan(name="gemini_explorer_call", ctx=ctx) as span: with TraceSpan(name="gemini_explorer_call", ctx=ctx) as span:
@@ -425,7 +500,7 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
thinking_level=thinking_level, thinking_level=thinking_level,
) )
response = await _ex._generate_content_with_reliability( response = await _generate_content_with_reliability(
lambda: asyncio.wait_for( lambda: asyncio.wait_for(
client.aio.models.generate_content( client.aio.models.generate_content(
model=model_name, model=model_name,
@@ -476,8 +551,7 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
recorded as a synthetic model text part so the conversation history recorded as a synthetic model text part so the conversation history
stays well-formed for the retry. stays well-formed for the retry.
""" """
_ex = facade() logger.warning(f"Explorer turn {turn}: Model hallucinated plain text. Forcing retry.")
_ex.logger.warning(f"Explorer turn {turn}: Model hallucinated plain text. Forcing retry.")
model_text = "\n".join(text_parts) if text_parts else "" model_text = "\n".join(text_parts) if text_parts else ""
turn_record["tool_calls"].append( turn_record["tool_calls"].append(
{ {
@@ -573,7 +647,6 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
On validation failure the error is fed back as a tool response and On validation failure the error is fed back as a tool response and
None is returned so the ReAct loop can continue and self-correct. None is returned so the ReAct loop can continue and self-correct.
""" """
_ex = facade()
submit_call = next( submit_call = next(
(fc for fc in function_calls if _bare_tool_name(fc.name) == SUBMIT_TOOL), (fc for fc in function_calls if _bare_tool_name(fc.name) == SUBMIT_TOOL),
None, None,
@@ -586,7 +659,7 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
errors = self._validate_submit_args(function_calls, args, candidates) errors = self._validate_submit_args(function_calls, args, candidates)
if errors: if errors:
_ex.logger.warning(f"Explorer submit_answer validation failed: {errors}") logger.warning(f"Explorer submit_answer validation failed: {errors}")
turn_record["tool_calls"].append( turn_record["tool_calls"].append(
{ {
"name": SUBMIT_TOOL, "name": SUBMIT_TOOL,
@@ -611,7 +684,7 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
# Allow the ReAct loop to continue so the model can self-correct # Allow the ReAct loop to continue so the model can self-correct
return None return None
_ex.logger.info("Explorer submit_answer validation passed successfully!") logger.info("Explorer submit_answer validation passed successfully!")
# Candidates submitted by a registered label inherit that element's # Candidates submitted by a registered label inherit that element's
# bounds; the rest of the model's arguments are passed through as is. # bounds; the rest of the model's arguments are passed through as is.
outcome_args = dict(args) outcome_args = dict(args)
@@ -637,7 +710,6 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
Image loading failures are logged and skipped: the textual result is Image loading failures are logged and skipped: the textual result is
still delivered, so one unreadable annotation cannot sink the turn. still delivered, so one unreadable annotation cannot sink the turn.
""" """
_ex = facade()
tool_response_parts.append( tool_response_parts.append(
types.Part.from_function_response(name=name, response={result_key: res.get("text")}) types.Part.from_function_response(name=name, response={result_key: res.get("text")})
) )
@@ -646,7 +718,7 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
try: try:
tool_response_parts.append(await get_image_part(img_p)) tool_response_parts.append(await get_image_part(img_p))
except Exception as e: except Exception as e:
_ex.logger.warning(f"Failed to load image response part for {img_p}: {e}") logger.warning(f"Failed to load image response part for {img_p}: {e}")
async def _execute_native_tool( async def _execute_native_tool(
self, self,
@@ -730,7 +802,6 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
absent from the declarations, because models occasionally call tools absent from the declarations, because models occasionally call tools
they were never offered. they were never offered.
""" """
_ex = facade()
for fc in function_calls: for fc in function_calls:
name = _bare_tool_name(fc.name) name = _bare_tool_name(fc.name)
if name == SUBMIT_TOOL: if name == SUBMIT_TOOL:
@@ -738,7 +809,7 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
args = fc.args or {} args = fc.args or {}
tool_call_trace = {"name": name, "args": args} tool_call_trace = {"name": name, "args": args}
if name in self.denylisted_tools: if name in self.denylisted_tools:
_ex.logger.warning( logger.warning(
f"Explorer attempted to call denylisted tool '{name}'. Blocking execution." f"Explorer attempted to call denylisted tool '{name}'. Blocking execution."
) )
error = f"Tool '{name}' is denylisted and unavailable." error = f"Tool '{name}' is denylisted and unavailable."
@@ -749,14 +820,14 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
) )
continue continue
_ex.logger.info(f"Explorer executing tool '{name}' sequentially...") logger.info(f"Explorer executing tool '{name}' sequentially...")
try: try:
await self._execute_native_tool( await self._execute_native_tool(
name, args, get_image_part, tool_call_trace, tool_response_parts name, args, get_image_part, tool_call_trace, tool_response_parts
) )
except Exception as e: except Exception as e:
_ex.logger.error(f"Explorer tool {name} execution failed: {e}") logger.error(f"Explorer tool {name} execution failed: {e}")
tool_call_trace["response"] = {"error": str(e)} tool_call_trace["response"] = {"error": str(e)}
tool_response_parts.append( tool_response_parts.append(
types.Part.from_function_response(name=name, response={"error": str(e)}) types.Part.from_function_response(name=name, response={"error": str(e)})
@@ -766,8 +837,7 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
def _format_native_failure(self, e: Exception, model_name: str) -> str: def _format_native_failure(self, e: Exception, model_name: str) -> str:
"""Maps a loop failure to the user-facing fallback outcome JSON.""" """Maps a loop failure to the user-facing fallback outcome JSON."""
_ex = facade() logger.error(f"Explorer execution loop failed: {e}")
_ex.logger.error(f"Explorer execution loop failed: {e}")
err_msg = str(e) err_msg = str(e)
if "preempted" in err_msg.lower(): if "preempted" in err_msg.lower():
@@ -794,16 +864,15 @@ Initial marked UI elements list (corresponding to numbers ①, ②... in the ima
async def _cleanup_native_resources(self, client, cached_content, uploaded_files: list) -> None: async def _cleanup_native_resources(self, client, cached_content, uploaded_files: list) -> None:
"""Deletes the cache resource and File API uploads created for this run.""" """Deletes the cache resource and File API uploads created for this run."""
_ex = facade()
if cached_content: if cached_content:
try: try:
_ex.logger.info(f"Deleting cache resource: {cached_content.name}") logger.info(f"Deleting cache resource: {cached_content.name}")
await client.aio.caches.delete(name=cached_content.name) await client.aio.caches.delete(name=cached_content.name)
except Exception as cleanup_cache_err: except Exception as cleanup_cache_err:
_ex.logger.warning(f"Failed to delete cache resource: {cleanup_cache_err}") logger.warning(f"Failed to delete cache resource: {cleanup_cache_err}")
for file_ref in uploaded_files: for file_ref in uploaded_files:
try: try:
await client.aio.files.delete(name=file_ref.name) await client.aio.files.delete(name=file_ref.name)
except Exception as cleanup_err: except Exception as cleanup_err:
_ex.logger.warning(f"Failed to delete uploaded file {file_ref.name}: {cleanup_err}") logger.warning(f"Failed to delete uploaded file {file_ref.name}: {cleanup_err}")
_ex.logger.info(f"Explorer turn latencies: {self.turn_latencies}") logger.info(f"Explorer turn latencies: {self.turn_latencies}")
+16 -18
View File
@@ -19,9 +19,7 @@ group plus its search helpers, packaged as a mixin consumed by ``Explorer``.
Text search, the coordinate audit and the OCR inventory all answer from the Text search, the coordinate audit and the OCR inventory all answer from the
run's in-memory :class:`~artemis.agents.explorer.screen_index.ScreenIndex`; run's in-memory :class:`~artemis.agents.explorer.screen_index.ScreenIndex`;
no Data Engine round trip is involved, so an unsynced frame never degrades no Data Engine round trip is involved, so an unsynced frame never degrades
to "no UI data". Patched collaborators (``settings``, ``draw_dots``, to "no UI data".
``_run_object_detection``, ``logger``) are resolved through the facade module
at call time; see ``artemis.agents.explorer._facade``.
""" """
import asyncio import asyncio
@@ -33,11 +31,16 @@ from typing import TYPE_CHECKING, Any
import cv2 import cv2
from artemis.agents.explorer._facade import facade
from artemis.agents.explorer.geometry import norm_to_pixel, pixel_to_norm from artemis.agents.explorer.geometry import norm_to_pixel, pixel_to_norm
from artemis.agents.explorer.screen_index import ScreenElement, ScreenIndex, normalize_text from artemis.agents.explorer.screen_index import ScreenElement, ScreenIndex, normalize_text
from artemis.agents.image_processor.image_processor import ImageProcessor from artemis.agents.image_processor.image_processor import ImageProcessor
from artemis.agents.object_detector.object_detector import _run_object_detection
from artemis.config import settings
from artemis.data_engine.trace import trace from artemis.data_engine.trace import trace
from artemis.utils.logger import get_logger
from artemis.utils.visualization import draw_dots
logger = get_logger(__name__)
#: Text-search answer when the screen could not be indexed at all. #: Text-search answer when the screen could not be indexed at all.
NO_UI_TREE_MESSAGE = "No UI-tree data is available for this screen; rely on visual detection." NO_UI_TREE_MESSAGE = "No UI-tree data is available for this screen; rely on visual detection."
@@ -49,7 +52,6 @@ def load_detector_templates() -> tuple[list[str], float]:
Shared by ``exec_detect_objects`` and the flash-mode ``run`` path; the two Shared by ``exec_detect_objects`` and the flash-mode ``run`` path; the two
call sites historically carried an identical inline copy of this block. call sites historically carried an identical inline copy of this block.
""" """
_ex = facade()
detector_prompt_path = Path(__file__).parent.parent / "object_detector" / "object_detector.json" detector_prompt_path = Path(__file__).parent.parent / "object_detector" / "object_detector.json"
global_timeout = 30.0 global_timeout = 30.0
try: try:
@@ -61,7 +63,7 @@ def load_detector_templates() -> tuple[list[str], float]:
if isinstance(raw_timeout, (int, float)) and raw_timeout > 0: if isinstance(raw_timeout, (int, float)) and raw_timeout > 0:
global_timeout = float(raw_timeout) global_timeout = float(raw_timeout)
except Exception as e: except Exception as e:
_ex.logger.warning(f"Failed to load detector prompt config: {e}") logger.warning(f"Failed to load detector prompt config: {e}")
detector_templates = ["Point to the following objects in the provided image: {labels_str}."] detector_templates = ["Point to the following objects in the provided image: {labels_str}."]
detector_instructions = "" detector_instructions = ""
@@ -127,8 +129,7 @@ class PerceptionToolsMixin:
def _next_output_path(self, subdir: str) -> Path: def _next_output_path(self, subdir: str) -> Path:
"""Next free ``images/<subdir>/<image>_<n>.jpg`` under the traces directory.""" """Next free ``images/<subdir>/<image>_<n>.jpg`` under the traces directory."""
_ex = facade() out_dir = Path(settings.TRACES_PATH) / "images" / subdir
out_dir = Path(_ex.settings.TRACES_PATH) / "images" / subdir
out_dir.mkdir(parents=True, exist_ok=True) out_dir.mkdir(parents=True, exist_ok=True)
stem = self.image_name or "temp_image" stem = self.image_name or "temp_image"
max_seq = 0 max_seq = 0
@@ -147,15 +148,14 @@ class PerceptionToolsMixin:
textual result is still delivered, so one bad annotation never sinks textual result is still delivered, so one bad annotation never sinks
the tool call. the tool call.
""" """
_ex = facade()
if not self.screenshot_path: if not self.screenshot_path:
return None return None
try: try:
output_path = self._next_output_path(subdir) output_path = self._next_output_path(subdir)
_ex.draw_dots(self.screenshot_path, points, labels, str(output_path), color=color) draw_dots(self.screenshot_path, points, labels, str(output_path), color=color)
return str(output_path) return str(output_path)
except Exception as e: except Exception as e:
_ex.logger.warning(f"Failed to draw {subdir} dots: {e}") logger.warning(f"Failed to draw {subdir} dots: {e}")
return None return None
# ------------------------------------------------------------------ # # ------------------------------------------------------------------ #
@@ -237,7 +237,6 @@ class PerceptionToolsMixin:
prefix: str = "D", prefix: str = "D",
color: str = "red", color: str = "red",
) -> dict: ) -> dict:
_ex = facade()
try: try:
if not self.screenshot_path: if not self.screenshot_path:
return { return {
@@ -257,7 +256,7 @@ class PerceptionToolsMixin:
# Load object detector templates # Load object detector templates
templates, global_timeout = load_detector_templates() templates, global_timeout = load_detector_templates()
result = await _ex._run_object_detection( result = await _run_object_detection(
self.ctx, self.ctx,
target_path, target_path,
queries, queries,
@@ -280,7 +279,7 @@ class PerceptionToolsMixin:
"image_path": str(target_path), "image_path": str(target_path),
} }
base_dir = _ex.settings.TRACES_PATH base_dir = settings.TRACES_PATH
images_dir = base_dir / "images" images_dir = base_dir / "images"
object_detect_dir = images_dir / "object_detect" object_detect_dir = images_dir / "object_detect"
object_detect_dir.mkdir(parents=True, exist_ok=True) object_detect_dir.mkdir(parents=True, exist_ok=True)
@@ -341,7 +340,7 @@ class PerceptionToolsMixin:
f'[{label_id}] "{item.get("label")}" at [{x_orig_norm},{y_orig_norm}]' f'[{label_id}] "{item.get("label")}" at [{x_orig_norm},{y_orig_norm}]'
) )
_ex.draw_dots( draw_dots(
self.screenshot_path, self.screenshot_path,
points, points,
d_labels, d_labels,
@@ -361,7 +360,7 @@ class PerceptionToolsMixin:
} }
except Exception as e: except Exception as e:
_ex.logger.warning(f"Failed to process detection output for annotation: {e}") logger.warning(f"Failed to process detection output for annotation: {e}")
return {"text": str(result), "image_path": None} return {"text": str(result), "image_path": None}
except Exception as e: except Exception as e:
return { return {
@@ -569,7 +568,6 @@ class PerceptionToolsMixin:
y_max: int, y_max: int,
zoom_factor: float = 2.0, zoom_factor: float = 2.0,
) -> dict: ) -> dict:
_ex = facade()
try: try:
if not self.screenshot_path: if not self.screenshot_path:
return { return {
@@ -613,7 +611,7 @@ class PerceptionToolsMixin:
if new_w > 0 and new_h > 0: if new_w > 0 and new_h > 0:
cropped = cv2.resize(cropped, (new_w, new_h)) cropped = cv2.resize(cropped, (new_w, new_h))
base_dir = _ex.settings.TRACES_PATH base_dir = settings.TRACES_PATH
images_dir = base_dir / "images" images_dir = base_dir / "images"
inspect_region_dir = images_dir / "inspect_region" inspect_region_dir = images_dir / "inspect_region"
inspect_region_dir.mkdir(parents=True, exist_ok=True) inspect_region_dir.mkdir(parents=True, exist_ok=True)
+32 -38
View File
@@ -19,11 +19,7 @@ detection path, the per-run screen loading shared by every tier (image record
resolution, screen dimensions, fused hierarchy, in-memory screen index) and resolution, screen dimensions, fused hierarchy, in-memory screen index) and
the named preparation phases executed before a reasoning loop (image pool, the named preparation phases executed before a reasoning loop (image pool,
model parameters, tier-aware prompt construction, initial screenshot model parameters, tier-aware prompt construction, initial screenshot
annotation), packaged as a mixin consumed by ``Explorer``. Patched annotation), packaged as a mixin consumed by ``Explorer``.
collaborators (``settings``, ``StorageManager``, ``is_ocr_configured``,
``perform_ocr``, ``draw_dots``, ``_run_object_detection``, ``logger``) are
resolved through the facade module at call time; see
``artemis.agents.explorer._facade``.
""" """
import base64 import base64
@@ -37,15 +33,24 @@ from typing import TYPE_CHECKING, Any
import httpx import httpx
from artemis.agents.explorer._facade import facade from artemis.agents.explorer.constants import (
from artemis.agents.explorer.constants import EXECUTION_CONSTRAINT_TEMPLATE DEFAULT_EXPLORER_MODEL,
EXECUTION_CONSTRAINT_TEMPLATE,
)
from artemis.agents.explorer.geometry import resolve_screen_size from artemis.agents.explorer.geometry import resolve_screen_size
from artemis.agents.explorer.perception_tools import load_detector_templates from artemis.agents.explorer.perception_tools import load_detector_templates
from artemis.agents.explorer.screen_index import ScreenElement, ScreenIndex from artemis.agents.explorer.screen_index import ScreenElement, ScreenIndex
from artemis.agents.explorer.tiers import SUBMIT_TOOL, ExplorerTier from artemis.agents.explorer.tiers import SUBMIT_TOOL, ExplorerTier
from artemis.agents.object_detector.object_detector import _run_object_detection
from artemis.config import settings
from artemis.data_engine.storage import StorageManager
from artemis.graph.state import State from artemis.graph.state import State
from artemis.utils.logger import get_logger
from artemis.utils.ocr_api import is_ocr_configured, perform_ocr
from artemis.utils.ocr_xml_fusion import fuse_ocr_with_xml from artemis.utils.ocr_xml_fusion import fuse_ocr_with_xml
from artemis.utils.visualization import format_minimal_list_with_elements from artemis.utils.visualization import draw_dots, format_minimal_list_with_elements
logger = get_logger(__name__)
#: Prompt bullets may be plain strings or ``{"text": ..., "requires": [...]}`` #: Prompt bullets may be plain strings or ``{"text": ..., "requires": [...]}``
#: objects; the latter are emitted only when every listed tool is exposed. #: objects; the latter are emitted only when every listed tool is exposed.
@@ -109,13 +114,12 @@ class RunSetupMixin:
Several targets may be listed in ``query`` separated by ``|``; each Several targets may be listed in ``query`` separated by ``|``; each
detection becomes a ``D<n>`` candidate described by its detected label. detection becomes a ``D<n>`` candidate described by its detected label.
""" """
_ex = facade()
templates, global_timeout = load_detector_templates() templates, global_timeout = load_detector_templates()
queries = [q.strip() for q in query.split("|") if q.strip()] queries = [q.strip() for q in query.split("|") if q.strip()]
try: try:
result = await _ex._run_object_detection( result = await _run_object_detection(
self.ctx, self.ctx,
screenshot_path, screenshot_path,
queries, queries,
@@ -140,12 +144,11 @@ class RunSetupMixin:
ensure_ascii=False, ensure_ascii=False,
) )
except Exception as e: except Exception as e:
_ex.logger.error(f"Flash mode object detection failed: {e}") logger.error(f"Flash mode object detection failed: {e}")
return self._failure_outcome(f"Flash mode detection error: {e}") return self._failure_outcome(f"Flash mode detection error: {e}")
def _resolve_image_record(self, screenshot_path: str) -> tuple: def _resolve_image_record(self, screenshot_path: str) -> tuple:
"""Computes the screenshot hash and looks it up in the Data Engine DB.""" """Computes the screenshot hash and looks it up in the Data Engine DB."""
_ex = facade()
image_name = None image_name = None
record = None record = None
try: try:
@@ -154,24 +157,24 @@ class RunSetupMixin:
for byte_block in iter(lambda: f.read(4096), b""): for byte_block in iter(lambda: f.read(4096), b""):
sha256_hash.update(byte_block) sha256_hash.update(byte_block)
computed_hash = sha256_hash.hexdigest() computed_hash = sha256_hash.hexdigest()
_ex.logger.info(f"Computed screenshot hash: {computed_hash}") logger.info(f"Computed screenshot hash: {computed_hash}")
# Check if it exists in DB # Check if it exists in DB
db_path = _ex.settings.DATA_ENGINE_DB_PATH db_path = settings.DATA_ENGINE_DB_PATH
base_dir = _ex.settings.TRACES_PATH base_dir = settings.TRACES_PATH
storage = _ex.StorageManager(db_path, base_dir) storage = StorageManager(db_path, base_dir)
record = storage.get_image(computed_hash) record = storage.get_image(computed_hash)
if record: if record:
image_name = computed_hash image_name = computed_hash
else: else:
_ex.logger.warning( logger.warning(
f"Image hash {computed_hash} not found in Data Engine DB." f"Image hash {computed_hash} not found in Data Engine DB."
" Data Engine might not be synced yet." " Data Engine might not be synced yet."
) )
except Exception as e: except Exception as e:
_ex.logger.warning(f"Failed to compute hash or check DB: {e}") logger.warning(f"Failed to compute hash or check DB: {e}")
return image_name, record return image_name, record
@@ -216,7 +219,6 @@ class RunSetupMixin:
def _resolve_model_params(self) -> tuple: def _resolve_model_params(self) -> tuple:
"""Resolves model name, temperature, thinking level, and fallback model.""" """Resolves model name, temperature, thinking level, and fallback model."""
_ex = facade()
llm_config = getattr(self.ctx, "llm_config", None) llm_config = getattr(self.ctx, "llm_config", None)
llm_cfg = getattr(llm_config, "explorer", None) if llm_config else None llm_cfg = getattr(llm_config, "explorer", None) if llm_config else None
temperature = 0.1 temperature = 0.1
@@ -235,7 +237,7 @@ class RunSetupMixin:
if "/" in fallback_model: if "/" in fallback_model:
fallback_model = fallback_model.split("/")[-1] fallback_model = fallback_model.split("/")[-1]
else: else:
model_name = _ex.DEFAULT_EXPLORER_MODEL model_name = DEFAULT_EXPLORER_MODEL
return model_name, temperature, thinking_level, fallback_model return model_name, temperature, thinking_level, fallback_model
@@ -303,32 +305,27 @@ class RunSetupMixin:
HTTP client backing on-the-fly OCR is created here on first need and HTTP client backing on-the-fly OCR is created here on first need and
released by ``Explorer.run`` regardless of the engine used. released by ``Explorer.run`` regardless of the engine used.
""" """
_ex = facade()
fused_xml: Any = [] fused_xml: Any = []
if record and getattr(record, "ui_tree", None): if record and getattr(record, "ui_tree", None):
ui_tree = record.ui_tree ui_tree = record.ui_tree
ocr_results = getattr(record, "ocr_result", None) ocr_results = getattr(record, "ocr_result", None)
if ocr_results is None: if ocr_results is None:
if allow_ocr and _ex.is_ocr_configured(): if allow_ocr and is_ocr_configured():
try: try:
_ex.logger.info( logger.info("Previous screenshot OCR is missing. Running OCR on-the-fly...")
"Previous screenshot OCR is missing. Running OCR on-the-fly..."
)
with open(screenshot_path, "rb") as img_file: with open(screenshot_path, "rb") as img_file:
img_b64 = base64.b64encode(img_file.read()).decode("utf-8") img_b64 = base64.b64encode(img_file.read()).decode("utf-8")
if self.http_client is None: if self.http_client is None:
self.http_client = httpx.AsyncClient() self.http_client = httpx.AsyncClient()
ocr_results = await _ex.perform_ocr(img_b64, client=self.http_client) ocr_results = await perform_ocr(img_b64, client=self.http_client)
except Exception as ocr_err: except Exception as ocr_err:
_ex.logger.error( logger.error(f"On-the-fly OCR failed for previous screenshot: {ocr_err}")
f"On-the-fly OCR failed for previous screenshot: {ocr_err}"
)
ocr_results = [] ocr_results = []
else: else:
ocr_results = [] ocr_results = []
fused_xml = fuse_ocr_with_xml(ui_tree, ocr_results or []) fused_xml = fuse_ocr_with_xml(ui_tree, ocr_results or [])
_ex.logger.info("Successfully loaded and fused UI hierarchy for previous screenshot.") logger.info("Successfully loaded and fused UI hierarchy for previous screenshot.")
elif screenshot_path == getattr(state, "latest_screenshot", None): elif screenshot_path == getattr(state, "latest_screenshot", None):
fused_xml = getattr(state, "latest_ui_hierarchy", None) fused_xml = getattr(state, "latest_ui_hierarchy", None)
return list(fused_xml) if isinstance(fused_xml, (list, tuple)) else [] return list(fused_xml) if isinstance(fused_xml, (list, tuple)) else []
@@ -341,13 +338,10 @@ class RunSetupMixin:
Every numbered label is registered against its element so a Every numbered label is registered against its element so a
candidate the model later submits by number inherits real bounds. candidate the model later submits by number inherits real bounds.
""" """
_ex = facade()
ctx = self.ctx ctx = self.ctx
marked_path = None marked_path = None
try: try:
_ex.logger.info( logger.info("Explorer self-annotating initial screenshot using latest_ui_hierarchy...")
"Explorer self-annotating initial screenshot using latest_ui_hierarchy..."
)
formatted_list, elements, labels = format_minimal_list_with_elements( formatted_list, elements, labels = format_minimal_list_with_elements(
fused_xml, self.width, self.height fused_xml, self.width, self.height
) )
@@ -363,7 +357,7 @@ class RunSetupMixin:
else None else None
) )
if not base_dir: if not base_dir:
base_dir = _ex.settings.TRACES_PATH base_dir = settings.TRACES_PATH
images_dir = base_dir / "images" images_dir = base_dir / "images"
initial_marked_dir = images_dir / "initial_marked" initial_marked_dir = images_dir / "initial_marked"
initial_marked_dir.mkdir(parents=True, exist_ok=True) initial_marked_dir.mkdir(parents=True, exist_ok=True)
@@ -380,12 +374,12 @@ class RunSetupMixin:
marked_path = initial_marked_dir / f"{image_name or 'temp_image'}_{seq}.jpg" marked_path = initial_marked_dir / f"{image_name or 'temp_image'}_{seq}.jpg"
# Draw dots on the raw screenshot # Draw dots on the raw screenshot
_ex.draw_dots(screenshot_path, points, labels, str(marked_path)) draw_dots(screenshot_path, points, labels, str(marked_path))
_ex.logger.info( logger.info(
f"Successfully drew {len(points)} dots and saved marked image to {marked_path}" f"Successfully drew {len(points)} dots and saved marked image to {marked_path}"
) )
except Exception as e: except Exception as e:
_ex.logger.error(f"Failed to self-annotate initial screenshot: {e}") logger.error(f"Failed to self-annotate initial screenshot: {e}")
return minimal_list, marked_path return minimal_list, marked_path
def _prepare_initial_annotation( def _prepare_initial_annotation(
+1 -2
View File
@@ -17,8 +17,7 @@
Split out of ``artemis.agents.explorer.explorer`` as pure data: Split out of ``artemis.agents.explorer.explorer`` as pure data:
``UNIVERSAL_EXPLORER_TOOLS`` (OpenAI-style dict schemas for the universal ``UNIVERSAL_EXPLORER_TOOLS`` (OpenAI-style dict schemas for the universal
LangChain path) and ``NATIVE_EXPLORER_TOOL_DECLARATIONS`` (google-genai LangChain path) and ``NATIVE_EXPLORER_TOOL_DECLARATIONS`` (google-genai
``FunctionDeclaration`` objects for the native Gemini path). Both are ``FunctionDeclaration`` objects for the native Gemini path).
re-exported by the ``explorer`` facade module.
""" """
from google.genai import types from google.genai import types
+11 -14
View File
@@ -15,10 +15,7 @@
"""Universal (LangChain ChatModel) execution loop for the Explorer agent. """Universal (LangChain ChatModel) execution loop for the Explorer agent.
Split out of ``artemis.agents.explorer.explorer``: the ``_run_universal`` Split out of ``artemis.agents.explorer.explorer``: the ``_run_universal``
reasoning loop, packaged as a mixin consumed by ``Explorer``. Patched reasoning loop, packaged as a mixin consumed by ``Explorer``.
collaborators (``get_llm``, ``logger``, ``UNIVERSAL_EXPLORER_TOOLS``) are
resolved through the facade module at call time; see
``artemis.agents.explorer._facade``.
""" """
import asyncio import asyncio
@@ -33,10 +30,14 @@ from langchain_core.messages import (
ToolMessage, ToolMessage,
) )
from artemis.agents.explorer._facade import facade
from artemis.agents.explorer.geometry import is_valid_norm_point from artemis.agents.explorer.geometry import is_valid_norm_point
from artemis.agents.explorer.tiers import SUBMIT_TOOL from artemis.agents.explorer.tiers import SUBMIT_TOOL
from artemis.agents.explorer.tool_declarations import UNIVERSAL_EXPLORER_TOOLS
from artemis.graph.state import State from artemis.graph.state import State
from artemis.services.llm import get_llm
from artemis.utils.logger import get_logger
logger = get_logger(__name__)
class UniversalRunnerMixin: class UniversalRunnerMixin:
@@ -72,9 +73,8 @@ class UniversalRunnerMixin:
def _universal_exposed_tools(self) -> list[dict[str, Any]]: def _universal_exposed_tools(self) -> list[dict[str, Any]]:
"""OpenAI-style tool schemas the model may see (tier-hidden ones excluded).""" """OpenAI-style tool schemas the model may see (tier-hidden ones excluded)."""
_ex = facade()
hidden = self._hidden_tool_names() hidden = self._hidden_tool_names()
return [t for t in _ex.UNIVERSAL_EXPLORER_TOOLS if t["function"]["name"] not in hidden] return [t for t in UNIVERSAL_EXPLORER_TOOLS if t["function"]["name"] not in hidden]
async def _run_universal( async def _run_universal(
self, self,
@@ -88,8 +88,7 @@ class UniversalRunnerMixin:
max_turns: int, max_turns: int,
) -> str: ) -> str:
"""Executes the Explorer reasoning loop via a universal LangChain ChatModel.""" """Executes the Explorer reasoning loop via a universal LangChain ChatModel."""
_ex = facade() llm = get_llm(self.ctx, name="explorer")
llm = _ex.get_llm(self.ctx, name="explorer")
exposed_tools = self._universal_exposed_tools() exposed_tools = self._universal_exposed_tools()
bound_llm = llm.bind_tools(exposed_tools) bound_llm = llm.bind_tools(exposed_tools)
@@ -124,7 +123,7 @@ class UniversalRunnerMixin:
tool_calls = getattr(response, "tool_calls", None) or [] tool_calls = getattr(response, "tool_calls", None) or []
if not tool_calls: if not tool_calls:
_ex.logger.warning(f"Universal Explorer turn {turn}: No tool calls generated.") logger.warning(f"Universal Explorer turn {turn}: No tool calls generated.")
if is_final_turn: if is_final_turn:
return json.dumps( return json.dumps(
{ {
@@ -256,7 +255,6 @@ class UniversalRunnerMixin:
the images ride on a follow-up human turn instead; unreadable files the images ride on a follow-up human turn instead; unreadable files
are skipped so a missing annotation never aborts the loop. are skipped so a missing annotation never aborts the loop.
""" """
_ex = facade()
blocks: list[dict[str, Any]] = [] blocks: list[dict[str, Any]] = []
tool_names: list[str] = [] tool_names: list[str] = []
for tool_name, path in images: for tool_name, path in images:
@@ -264,7 +262,7 @@ class UniversalRunnerMixin:
with open(path, "rb") as f: with open(path, "rb") as f:
img_b64 = base64.b64encode(f.read()).decode("utf-8") img_b64 = base64.b64encode(f.read()).decode("utf-8")
except OSError as read_err: except OSError as read_err:
_ex.logger.warning(f"Skipping unreadable tool image {path}: {read_err}") logger.warning(f"Skipping unreadable tool image {path}: {read_err}")
continue continue
if tool_name not in tool_names: if tool_name not in tool_names:
tool_names.append(tool_name) tool_names.append(tool_name)
@@ -283,7 +281,6 @@ class UniversalRunnerMixin:
self, tool_calls: list, messages: list[BaseMessage], turn: int self, tool_calls: list, messages: list[BaseMessage], turn: int
) -> None: ) -> None:
"""Executes non-submit tool calls, appending ToolMessages and their images.""" """Executes non-submit tool calls, appending ToolMessages and their images."""
_ex = facade()
images: list[tuple[str, str]] = [] images: list[tuple[str, str]] = []
for tc in tool_calls: for tc in tool_calls:
name = tc.get("name") name = tc.get("name")
@@ -306,7 +303,7 @@ class UniversalRunnerMixin:
messages.append(ToolMessage(tool_call_id=call_id, name=name, content=res_text)) messages.append(ToolMessage(tool_call_id=call_id, name=name, content=res_text))
images.extend((name, path) for path in self._tool_image_paths(res)) images.extend((name, path) for path in self._tool_image_paths(res))
except Exception as tool_err: except Exception as tool_err:
_ex.logger.error(f"Error executing tool '{name}': {tool_err}") logger.error(f"Error executing tool '{name}': {tool_err}")
messages.append( messages.append(
ToolMessage( ToolMessage(
tool_call_id=call_id, tool_call_id=call_id,
+3 -5
View File
@@ -82,7 +82,7 @@ from artemis.agents.operator.prompts import (
InjectedInstructionPromptComponent, InjectedInstructionPromptComponent,
render_transcript_static_system, render_transcript_static_system,
) )
from artemis.agents.operator.prompt_builder import load_operator_prompts from artemis.agents.operator.prompts import load_operator_prompts
class OperatorNode: class OperatorNode:
@@ -101,8 +101,7 @@ class OperatorNode:
try: try:
self.prompts = load_operator_prompts() self.prompts = load_operator_prompts()
except (OSError, ValueError, json.JSONDecodeError) as e: except (OSError, ValueError, json.JSONDecodeError) as e:
logger.error(f"Failed to load operator prompts: {e}") raise RuntimeError(f"Failed to load operator prompts: {e}") from e
self.prompts = {}
# M2 transcript flag (agent.memory.transcript.enabled). Off keeps the # M2 transcript flag (agent.memory.transcript.enabled). Off keeps the
# legacy 2-message prompt path byte-for-byte; an explicit # legacy 2-message prompt path byte-for-byte; an explicit
@@ -488,8 +487,7 @@ class OperatorNode:
additional_kwargs = getattr(response, "additional_kwargs", None) additional_kwargs = getattr(response, "additional_kwargs", None)
if ( if (
not response.tool_calls not response.tool_calls
and isinstance(additional_kwargs, dict) and type(additional_kwargs) is dict
and not hasattr(additional_kwargs, "assert_called_with") # Filter out mocks
and additional_kwargs.get("function_call") and additional_kwargs.get("function_call")
): ):
fc = additional_kwargs["function_call"] fc = additional_kwargs["function_call"]
-71
View File
@@ -1,71 +0,0 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Compatibility prompt builder backed by the canonical Operator templates."""
import json
from functools import lru_cache
from pathlib import Path
from jinja2 import Template
OPERATOR_HUMAN_TEMPLATE = """Goal: {{ goal }}
Active Sub-Goal: {{ sub_goal }}
Current Turn: {{ current_turn }}
Execution History:
{{ history }}
"""
@lru_cache(maxsize=1)
def load_operator_prompts() -> dict[str, str]:
"""Load the single canonical prompt source shared by all Operator entry points."""
prompts_path = Path(__file__).with_name("operator.json")
return json.loads(prompts_path.read_text(encoding="utf-8"))
class OperatorPromptBuilder:
"""Builds prompt messages and multimodal contents for the Operator Agent."""
@classmethod
def build_system_message(
cls,
template_name: str = "main_template",
available_tools: frozenset[str] | None = None,
) -> str:
from artemis.agents.operator.prompts import apply_operator_prompt_contract
prompts = load_operator_prompts()
try:
return apply_operator_prompt_contract(
prompts[template_name], available_tools=available_tools
)
except KeyError as exc:
raise ValueError(f"Unknown Operator template: {template_name}") from exc
@classmethod
def build_human_message(
cls,
goal: str,
sub_goal: str = "",
current_turn: int = 1,
history: str = "",
) -> str:
template = Template(OPERATOR_HUMAN_TEMPLATE)
return template.render(
goal=goal,
sub_goal=sub_goal,
current_turn=current_turn,
history=history,
)
+10
View File
@@ -13,7 +13,9 @@
# limitations under the License. # limitations under the License.
import base64 import base64
from functools import lru_cache
import io import io
import json
from pathlib import Path from pathlib import Path
from jinja2 import Environment, StrictUndefined, Template from jinja2 import Environment, StrictUndefined, Template
@@ -36,6 +38,14 @@ logger = get_logger(__name__)
from artemis.agents.prompt_assembly import render_tool_enum, resolve_available from artemis.agents.prompt_assembly import render_tool_enum, resolve_available
from artemis.mcp.action_specs import OPERATOR_SHELL_ORDER from artemis.mcp.action_specs import OPERATOR_SHELL_ORDER
@lru_cache(maxsize=1)
def load_operator_prompts() -> dict[str, str]:
"""Load and cache the Operator templates from operator.json."""
prompts_path = Path(__file__).with_name("operator.json")
return json.loads(prompts_path.read_text(encoding="utf-8"))
# --- Assembled tool references ------------------------------------------------------- # --- Assembled tool references -------------------------------------------------------
# The operator.json templates carry availability slots rendered by # The operator.json templates carry availability slots rendered by
# ``apply_operator_prompt_contract``: ``[[ tool_enum(...) ]]`` expands an ordered, # ``apply_operator_prompt_contract``: ``[[ tool_enum(...) ]]`` expands an ordered,
+31 -18
View File
@@ -31,6 +31,7 @@ from PIL import Image
from pydantic import BaseModel from pydantic import BaseModel
import uiautomator2 as u2 import uiautomator2 as u2
from artemis.runtime.adb_endpoint import adb_command
from artemis.runtime.awake_service import ensure_device_awake from artemis.runtime.awake_service import ensure_device_awake
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -173,7 +174,7 @@ def _is_package_installed(device_id: str, pkg: str) -> bool:
"""Check if a package is installed on the device.""" """Check if a package is installed on the device."""
try: try:
result = subprocess.run( result = subprocess.run(
["adb", "-s", device_id, "shell", "pm", "list", "packages"], adb_command(["-s", device_id, "shell", "pm", "list", "packages"]),
stdin=subprocess.DEVNULL, stdin=subprocess.DEVNULL,
capture_output=True, capture_output=True,
text=True, text=True,
@@ -198,17 +199,18 @@ def _uninstall_package(device_id: str, pkg: str) -> bool:
"""Uninstall a package from the device for the current user.""" """Uninstall a package from the device for the current user."""
try: try:
result = subprocess.run( result = subprocess.run(
[ adb_command(
"adb", [
"-s", "-s",
device_id, device_id,
"shell", "shell",
"pm", "pm",
"uninstall", "uninstall",
"--user", "--user",
"0", "0",
pkg, pkg,
], ]
),
stdin=subprocess.DEVNULL, stdin=subprocess.DEVNULL,
capture_output=True, capture_output=True,
text=True, text=True,
@@ -285,13 +287,24 @@ class UIAutomatorClient:
if self._awake_strategy is None: if self._awake_strategy is None:
self._awake_strategy = ensure_device_awake(self._device_id) self._awake_strategy = ensure_device_awake(self._device_id)
# Connect to device # Retry connections while ADB recovers from a reboot or USB disconnect.
logger.info(f"Connecting UIAutomator2 to device: {self._device_id}") logger.info(f"Connecting UIAutomator2 to device: {self._device_id}")
try: last_error: Exception | None = None
self._device = u2.connect(self._device_id) for attempt in range(3):
except Exception: if attempt:
time.sleep(1.0 * attempt)
try:
self._device = u2.connect(self._device_id)
break
except Exception as exc:
last_error = exc
logger.warning(
f"UIAutomator2 connect attempt {attempt + 1}/3 to"
f" {self._device_id} failed: {exc}"
)
else:
self._awake_strategy = None self._awake_strategy = None
raise raise last_error
logger.info("UIAutomator2 connected successfully") logger.info("UIAutomator2 connected successfully")
return self._device return self._device
@@ -380,7 +393,7 @@ class UIAutomatorClient:
""" """
try: try:
result = subprocess.run( result = subprocess.run(
["adb", "-s", self._device_id, "exec-out", "screencap", "-p"], adb_command(["-s", self._device_id, "exec-out", "screencap", "-p"]),
stdin=subprocess.DEVNULL, stdin=subprocess.DEVNULL,
capture_output=True, capture_output=True,
timeout=10, timeout=10,
+4 -7
View File
@@ -18,7 +18,7 @@ from typing import Any
class ToolDeclaration(dict): class ToolDeclaration(dict):
"""Standardized tool declaration adhering to JSON Schema format with property accessors.""" """OpenAI function schema with name, description and parameters properties."""
def __init__(self, name: str, description: str, parameters: dict[str, Any]): def __init__(self, name: str, description: str, parameters: dict[str, Any]):
super().__init__( super().__init__(
@@ -28,19 +28,16 @@ class ToolDeclaration(dict):
"description": description, "description": description,
"parameters": parameters, "parameters": parameters,
}, },
name=name,
description=description,
parameters=parameters,
) )
@property @property
def name(self) -> str: def name(self) -> str:
return self.get("name") or self.get("function", {}).get("name", "") return self.get("function", {}).get("name", "")
@property @property
def description(self) -> str: def description(self) -> str:
return self.get("description") or self.get("function", {}).get("description", "") return self.get("function", {}).get("description", "")
@property @property
def parameters(self) -> dict[str, Any]: def parameters(self) -> dict[str, Any]:
return self.get("parameters") or self.get("function", {}).get("parameters", {}) return self.get("function", {}).get("parameters", {})
+53 -56
View File
@@ -718,6 +718,50 @@ async def _process_plan_write(
return result return result
async def _intercept_plan_write(
ctx: ArtemisContext,
original_tool,
args: dict,
tool_call_id,
state,
*,
declared_intent: bool,
content_after_fallback: str = "",
):
"""Run a note write and process any resulting task-plan changes."""
rejection = _reject_checker_note_write(args["key"], tool_call_id)
if rejection is not None:
return rejection
if args["key"] != "task_plan" or not ctx.data_engine:
return await invoke_tool_with_injection(
original_tool, args, tool_call_id, state, record_trace=False
)
task_plan_path = get_note_file_path(ctx.data_engine.base_dir, "task_plan")
content_before = ""
if task_plan_path.exists():
content_before = task_plan_path.read_text(encoding="utf-8")
result = await invoke_tool_with_injection(
original_tool, args, tool_call_id, state, record_trace=False
)
content_after = content_after_fallback
if task_plan_path.exists():
content_after = task_plan_path.read_text(encoding="utf-8")
return await _process_plan_write(
ctx,
state,
task_plan_path,
content_before,
content_after,
result,
declared_intent=declared_intent,
)
def wrap_note_tool(ctx: ArtemisContext, original_tool): def wrap_note_tool(ctx: ArtemisContext, original_tool):
async def wrapped_note_tool( async def wrapped_note_tool(
@@ -727,37 +771,14 @@ def wrap_note_tool(ctx: ArtemisContext, original_tool):
state: Annotated[State, InjectedState] = None, state: Annotated[State, InjectedState] = None,
): ):
"""Wrapped tool to intercept task plan updates.""" """Wrapped tool to intercept task plan updates."""
rejection = _reject_checker_note_write(key, tool_call_id) return await _intercept_plan_write(
if rejection is not None:
return rejection
args = {"key": key, "content": content}
if key != "task_plan" or not ctx.data_engine:
return await invoke_tool_with_injection(
original_tool, args, tool_call_id, state, record_trace=False
)
task_plan_path = get_note_file_path(ctx.data_engine.base_dir, "task_plan")
content_before = ""
if task_plan_path.exists():
content_before = task_plan_path.read_text(encoding="utf-8")
result = await invoke_tool_with_injection(
original_tool, args, tool_call_id, state, record_trace=False
)
content_after = content
if task_plan_path.exists():
content_after = task_plan_path.read_text(encoding="utf-8")
return await _process_plan_write(
ctx, ctx,
original_tool,
{"key": key, "content": content},
tool_call_id,
state, state,
task_plan_path,
content_before,
content_after,
result,
declared_intent=False, declared_intent=False,
content_after_fallback=content,
) )
return StructuredTool.from_function( return StructuredTool.from_function(
@@ -786,36 +807,12 @@ def wrap_update_note_tool(ctx: ArtemisContext, original_tool):
state: Annotated[State, InjectedState] = None, state: Annotated[State, InjectedState] = None,
): ):
"""Wrapped tool to intercept task plan updates via update_note.""" """Wrapped tool to intercept task plan updates via update_note."""
rejection = _reject_checker_note_write(key, tool_call_id) return await _intercept_plan_write(
if rejection is not None:
return rejection
args = {"key": key, "target": target, "replacement": replacement}
if key != "task_plan" or not ctx.data_engine:
return await invoke_tool_with_injection(
original_tool, args, tool_call_id, state, record_trace=False
)
task_plan_path = get_note_file_path(ctx.data_engine.base_dir, "task_plan")
content_before = ""
if task_plan_path.exists():
content_before = task_plan_path.read_text(encoding="utf-8")
result = await invoke_tool_with_injection(
original_tool, args, tool_call_id, state, record_trace=False
)
content_after = ""
if task_plan_path.exists():
content_after = task_plan_path.read_text(encoding="utf-8")
return await _process_plan_write(
ctx, ctx,
original_tool,
{"key": key, "target": target, "replacement": replacement},
tool_call_id,
state, state,
task_plan_path,
content_before,
content_after,
result,
declared_intent=True, declared_intent=True,
) )
+23 -3
View File
@@ -20,6 +20,7 @@ Anthropic, OpenRouter, and local Ollama/vLLM endpoints.
""" """
from enum import StrEnum from enum import StrEnum
import hashlib
import os import os
from typing import Any from typing import Any
@@ -46,10 +47,19 @@ class ModelProvider(StrEnum):
@classmethod @classmethod
def from_string(cls, val: Any) -> "ModelProvider": def from_string(cls, val: Any) -> "ModelProvider":
"""Converts any string, enum, or mock representation into a canonical ModelProvider.""" """Converts a string or enum into a canonical ModelProvider.
``None``/empty means "use the default" (Google); an unrecognized
non-empty value raises instead of silently routing to Gemini with
the wrong credentials.
"""
if isinstance(val, cls): if isinstance(val, cls):
return val return val
if val is None:
return cls.GOOGLE
s = str(val).lower().replace("_", "").replace("-", "").strip() s = str(val).lower().replace("_", "").replace("-", "").strip()
if not s:
return cls.GOOGLE
mapping = { mapping = {
"google": cls.GOOGLE, "google": cls.GOOGLE,
"gemini": cls.GOOGLE, "gemini": cls.GOOGLE,
@@ -65,7 +75,12 @@ class ModelProvider(StrEnum):
"vllm": cls.VLLM, "vllm": cls.VLLM,
"custom": cls.CUSTOM, "custom": cls.CUSTOM,
} }
return mapping.get(s, cls.GOOGLE) provider = mapping.get(s)
if provider is None:
raise ValueError(
f"Unknown LLM provider {val!r}. Valid providers: {sorted(set(mapping))}"
)
return provider
class ModelEndpoint(BaseModel): class ModelEndpoint(BaseModel):
@@ -97,11 +112,15 @@ class ModelEndpoint(BaseModel):
) )
def cache_key(self) -> tuple: def cache_key(self) -> tuple:
"""Returns a deterministic hashable cache key for connection pooling.""" """Key the client cache by endpoint settings, hashing the API key."""
api_key_digest = (
hashlib.sha256(self.api_key.encode("utf-8")).hexdigest()[:16] if self.api_key else None
)
return ( return (
self.provider.value, self.provider.value,
self.model_name, self.model_name,
self.temperature, self.temperature,
self.max_tokens,
self.timeout_seconds, self.timeout_seconds,
self.thinking_budget, self.thinking_budget,
self.thinking_level, self.thinking_level,
@@ -109,6 +128,7 @@ class ModelEndpoint(BaseModel):
self.reasoning_effort, self.reasoning_effort,
self.enable_grounding, self.enable_grounding,
self.api_base, self.api_base,
api_key_digest,
) )
+5
View File
@@ -166,3 +166,8 @@ def current_adb_endpoint() -> AdbEndpoint:
host = settings.ADB_HOST or os.environ.get("ADB_HOST") or DEFAULT_ADB_HOST host = settings.ADB_HOST or os.environ.get("ADB_HOST") or DEFAULT_ADB_HOST
port = settings.ADB_PORT or os.environ.get("ADB_PORT") or DEFAULT_ADB_PORT port = settings.ADB_PORT or os.environ.get("ADB_PORT") or DEFAULT_ADB_PORT
return AdbEndpoint.create(str(host), int(port)) return AdbEndpoint.create(str(host), int(port))
def adb_command(arguments: Sequence[str]) -> list[str]:
"""Resolve the ADB binary and add the configured server's host and port."""
return AdbSession(current_adb_endpoint()).command(arguments)
+2 -1
View File
@@ -28,6 +28,7 @@ import time
import uuid import uuid
from artemis.config.paths import get_temp_dir from artemis.config.paths import get_temp_dir
from artemis.runtime.adb_endpoint import adb_command
from artemis.runtime.process_probe import pid_is_alive from artemis.runtime.process_probe import pid_is_alive
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -148,7 +149,7 @@ class ScreenAwakeLease:
def _run(self, args: list[str], description: str) -> subprocess.CompletedProcess[str] | None: def _run(self, args: list[str], description: str) -> subprocess.CompletedProcess[str] | None:
try: try:
result = subprocess.run( result = subprocess.run(
["adb", "-s", self.device_id, *args], adb_command(["-s", self.device_id, *args]),
stdin=subprocess.DEVNULL, stdin=subprocess.DEVNULL,
capture_output=True, capture_output=True,
text=True, text=True,
+2 -1
View File
@@ -25,6 +25,7 @@ from typing import Iterable
from adbutils import AdbClient from adbutils import AdbClient
from artemis.config import settings from artemis.config import settings
from artemis.runtime.adb_endpoint import adb_command
from artemis.runtime.awake_lease import ScreenAwakeLease from artemis.runtime.awake_lease import ScreenAwakeLease
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -47,7 +48,7 @@ def _run_awake_adb_command(
"""Run one non-fatal ADB command used by the USB awake policy.""" """Run one non-fatal ADB command used by the USB awake policy."""
try: try:
result = subprocess.run( result = subprocess.run(
["adb", "-s", device_id, *args], adb_command(["-s", device_id, *args]),
stdin=subprocess.DEVNULL, stdin=subprocess.DEVNULL,
capture_output=True, capture_output=True,
text=True, text=True,
+37 -19
View File
@@ -261,6 +261,20 @@ class DeviceExecutionLock:
payload["lock_scope"] = str(lock_scope) payload["lock_scope"] = str(lock_scope)
return payload return payload
@classmethod
def _atomic_write_json(cls, path: Path, payload: dict) -> bool:
"""Replace a ticket atomically so queue scans cannot read partial JSON."""
temp_path = path.with_name(f"{path.name}.{uuid.uuid4().hex}.tmp")
try:
temp_path.write_text(json.dumps(payload, ensure_ascii=False), encoding="utf-8")
if not cls._safe_replace(temp_path, path):
return False
except OSError:
return False
finally:
cls._safe_unlink(temp_path)
return True
@classmethod @classmethod
def _ticket_targets_device( def _ticket_targets_device(
cls, cls,
@@ -454,11 +468,7 @@ class DeviceExecutionLock:
effective_scope = lock_scope or os.getenv(cls.LOCK_SCOPE_ENV) or None effective_scope = lock_scope or os.getenv(cls.LOCK_SCOPE_ENV) or None
if effective_scope: if effective_scope:
payload["lock_scope"] = str(effective_scope) payload["lock_scope"] = str(effective_scope)
try: return cls._atomic_write_json(path, payload)
path.write_text(json.dumps(payload, ensure_ascii=False), encoding="utf-8")
except OSError:
return False
return True
def _find_reserved_ticket(self) -> Path | None: def _find_reserved_ticket(self) -> Path | None:
if not self.queue_ticket: if not self.queue_ticket:
@@ -482,7 +492,10 @@ class DeviceExecutionLock:
ingress=self.ingress, ingress=self.ingress,
lock_scope=self.lock_scope, lock_scope=self.lock_scope,
) )
path.write_text(json.dumps(payload, ensure_ascii=False), encoding="utf-8") if not self._atomic_write_json(path, payload):
raise DeviceBusyError(
"The Artemis queue reservation could not be claimed (ticket rewrite failed)."
)
return path return path
self.queue_ticket = self.reserve( self.queue_ticket = self.reserve(
@@ -567,6 +580,15 @@ class DeviceExecutionLock:
return 0 return 0
if self.max_concurrency is not None: if self.max_concurrency is not None:
return self.max_concurrency return self.max_concurrency
return self.resolve_env_concurrency()
@classmethod
def resolve_env_concurrency(cls) -> int:
"""Resolve the concurrency limit from the environment.
Shared with the admin scheduler. Returns 0 for per-device concurrency,
or a positive global limit.
"""
env_mode = os.environ.get("ARTEMIS_CONCURRENCY_MODE", "").strip().lower() env_mode = os.environ.get("ARTEMIS_CONCURRENCY_MODE", "").strip().lower()
if env_mode in ("global", "serial", "1"): if env_mode in ("global", "serial", "1"):
return 1 return 1
@@ -690,9 +712,14 @@ class DeviceExecutionLock:
return return
try: try:
owner = self._read_owner(self.path) owner = self._read_owner(self.path)
if owner is not None and ( # A matching session id cannot release another process's lease.
owner.token == self.token if (
or (self.session_id and owner.session_id == self.session_id) owner is not None
and owner.pid == os.getpid()
and (
owner.token == self.token
or (self.session_id and owner.session_id == self.session_id)
)
): ):
self._safe_unlink(self.path) self._safe_unlink(self.path)
finally: finally:
@@ -933,16 +960,7 @@ class DeviceExecutionLock:
"session_id": str(session_id), "session_id": str(session_id),
"ingress": ingress or owner.ingress or "sdk", "ingress": ingress or owner.ingress or "sdk",
} }
temp_path = path.with_name(f"{path.name}.{uuid.uuid4().hex}.tmp") return cls._atomic_write_json(path, payload)
try:
temp_path.write_text(json.dumps(payload, ensure_ascii=False), encoding="utf-8")
if not cls._safe_replace(temp_path, path):
return False
except OSError:
return False
finally:
cls._safe_unlink(temp_path)
return True
@classmethod @classmethod
def cleanup_stale_locks(cls, device_id: str | None = None) -> int: def cleanup_stale_locks(cls, device_id: str | None = None) -> int:
+9 -1
View File
@@ -436,7 +436,15 @@ class DevicePool:
selects the first ready device so the task will queue on it. selects the first ready device so the task will queue on it.
Returns None if no devices are attached. Returns None if no devices are attached.
""" """
all_devs = self.list_devices() return self._pick_device(self.list_devices(), preferred_serial)
async def select_device_async(self, preferred_serial: str | None = None) -> str | None:
"""Select a device without blocking the caller on ADB enumeration."""
return self._pick_device(await self.list_devices_async(), preferred_serial)
def _pick_device(
self, all_devs: list[DeviceStatus], preferred_serial: str | None
) -> str | None:
ready_devs = [d for d in all_devs if d.state == "device"] ready_devs = [d for d in all_devs if d.state == "device"]
if preferred_serial: if preferred_serial:
+17
View File
@@ -326,6 +326,23 @@ def update_trace_status(
return data return data
def update_trace_pid(trace_id: str, pid: int) -> dict[str, Any] | None:
"""Updates the pid field of the status.json for a given trace_id."""
path = get_status_path(trace_id)
with _status_lock(path):
data = read_status(trace_id)
if not data:
if os.path.exists(path) or os.path.exists(f"{path}.corrupt"):
logger.warning(
f"Dropping pid update for trace {trace_id}: existing status.json is unreadable"
)
return None
data["pid"] = pid
write_status(trace_id, data)
return data
def update_trace_device_serial(trace_id: str, device_serial: str) -> dict[str, Any] | None: def update_trace_device_serial(trace_id: str, device_serial: str) -> dict[str, Any] | None:
"""Updates the device_serial field of the status.json for a given trace_id.""" """Updates the device_serial field of the status.json for a given trace_id."""
path = get_status_path(trace_id) path = get_status_path(trace_id)
+20 -4
View File
@@ -21,7 +21,6 @@ thought stream recording, and role-based dynamic dispatching.
import asyncio import asyncio
from collections.abc import Awaitable, Callable, Coroutine from collections.abc import Awaitable, Callable, Coroutine
from contextvars import ContextVar, Token from contextvars import ContextVar, Token
from dataclasses import replace
import functools import functools
import logging import logging
from pathlib import Path from pathlib import Path
@@ -110,6 +109,9 @@ _ENDPOINT_BREAKER = CircuitBreaker(threshold=3, cooldown_seconds=30.0)
# remembered so subsequent calls go straight to non-streaming invocation. # remembered so subsequent calls go straight to non-streaming invocation.
_NON_STREAMING_ENDPOINTS: set[str] = set() _NON_STREAMING_ENDPOINTS: set[str] = set()
# Total retry limit when failures switch categories within one recovery cycle.
_MAX_TOTAL_RETRY_ATTEMPTS = 8
def _get_current_data_engine(): def _get_current_data_engine():
if _CURRENT_DATA_ENGINE is not None: if _CURRENT_DATA_ENGINE is not None:
@@ -442,6 +444,13 @@ async def _run_with_recovery[T](
policy = retry_policy_for(failure.category) policy = retry_policy_for(failure.category)
if attempt >= policy.max_attempts: if attempt >= policy.max_attempts:
break break
total_attempts = sum(attempts.values())
if total_attempts >= _MAX_TOTAL_RETRY_ATTEMPTS:
llm_logger.warning(
"LLM retry total across failure categories reached"
f" {total_attempts}; treating as exhausted."
)
break
delay = policy.delay_for(attempt) delay = policy.delay_for(attempt)
_record_llm_retry( _record_llm_retry(
str(e), str(e),
@@ -753,10 +762,17 @@ class RobustChatModelWrapper:
def _is_stream_unsupported_error(error: BaseException) -> bool: def _is_stream_unsupported_error(error: BaseException) -> bool:
"""Detect 'this endpoint/model cannot stream' as opposed to a transient failure.""" """Detect 'this endpoint/model cannot stream' as opposed to a transient failure.
if isinstance(error, (NotImplementedError, AttributeError, TypeError)):
A positive here permanently disables streaming for the endpoint in this
process, so a bare AttributeError/TypeError from unrelated code must not
qualify — the message has to actually implicate streaming.
"""
if isinstance(error, NotImplementedError):
return True return True
message = str(error).lower() message = str(error).lower()
if isinstance(error, (AttributeError, TypeError)):
return "stream" in message
return "stream" in message and any( return "stream" in message and any(
marker in message marker in message
for marker in ("not support", "unsupported", "not implemented", "not available") for marker in ("not support", "unsupported", "not implemented", "not available")
@@ -1106,7 +1122,7 @@ def get_llm(
"""Resolves and instantiates the appropriate LLM wrapper for the given agent role.""" """Resolves and instantiates the appropriate LLM wrapper for the given agent role."""
endpoint = _resolve_endpoint(ctx, str(name), is_utils=is_utils, use_fallback=use_fallback) endpoint = _resolve_endpoint(ctx, str(name), is_utils=is_utils, use_fallback=use_fallback)
if temperature is not None: if temperature is not None:
endpoint = replace(endpoint, temperature=temperature) endpoint = endpoint.model_copy(update={"temperature": temperature})
raw_model = ModelFactory.get_model(endpoint) raw_model = ModelFactory.get_model(endpoint)
handler = DataEngineCallbackHandler(ctx) handler = DataEngineCallbackHandler(ctx)
+1 -89
View File
@@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
"""Universal Tool Protocol and Registry for ARTEMIS. """Universal Tool Protocol for ARTEMIS.
Enables tools to be authored once using standard Pydantic schemas and async handlers, Enables tools to be authored once using standard Pydantic schemas and async handlers,
then automatically exported to LangChain Tools (Pro Graph), Google GenAI FunctionDeclarations then automatically exported to LangChain Tools (Pro Graph), Google GenAI FunctionDeclarations
@@ -197,91 +197,3 @@ class ArtemisTool:
required=required, required=required,
), ),
) )
class ToolRegistry:
"""Global registry managing universal tools."""
_tools: dict[str, ArtemisTool] = {}
@classmethod
def register(cls, tool: ArtemisTool) -> ArtemisTool:
"""Registers a tool in the global registry."""
cls._tools[tool.name] = tool
return tool
@classmethod
def get(cls, name: str) -> ArtemisTool | None:
"""Retrieves a tool by name from the registry."""
normalized = name.split(":")[-1] if ":" in name else name
return cls._tools.get(normalized)
@classmethod
def list_tools(
cls, category: ToolCategory | None = None, available_only: bool = True
) -> list[ArtemisTool]:
"""Lists all registered tools, optionally filtered by category and availability."""
tools = [t for t in cls._tools.values() if not available_only or t.is_available()]
if category:
return [t for t in tools if t.category == category]
return list(tools)
@classmethod
def get_langchain_tools(
cls, ctx: Any, names: list[str] | None = None, available_only: bool = True
) -> list[BaseTool]:
"""Returns LangChain tool wrappers for the requested or all registered tools."""
tools = (
[cls._tools[n] for n in names if n in cls._tools]
if names
else list(cls._tools.values())
)
if available_only:
tools = [t for t in tools if t.is_available(ctx)]
return [t.to_langchain_tool(ctx) for t in tools]
@classmethod
def get_genai_declarations(
cls, names: list[str] | None = None, available_only: bool = True
) -> list[genai_types.FunctionDeclaration]:
"""Returns Google GenAI function declarations for registered tools."""
tools = (
[cls._tools[n] for n in names if n in cls._tools]
if names
else list(cls._tools.values())
)
if available_only:
tools = [t for t in tools if t.is_available()]
return [t.to_genai_declaration() for t in tools]
@classmethod
async def execute(
cls, name: str, args: dict[str, Any], driver: BaseDeviceDriver, ctx: Any
) -> Any:
"""Executes a registered tool by name with provided arguments, driver, and context."""
tool = cls.get(name)
if not tool:
raise ValueError(f"Tool '{name}' not found in ToolRegistry.")
return await tool.execute(driver=driver, ctx=ctx, **args)
def artemis_tool(
name: str,
description: str,
args_schema: type[BaseModel],
category: ToolCategory = "action",
):
"""Decorator to define and register a universal ARTEMIS tool."""
def decorator(fn: Callable[..., Any]) -> ArtemisTool:
tool_obj = ArtemisTool(
name=name,
description=description,
args_schema=args_schema,
handler=fn,
category=category,
)
ToolRegistry.register(tool_obj)
return tool_obj
return decorator
+1 -5
View File
@@ -54,7 +54,7 @@ from artemis.controllers.platform_specific_commands_controller import (
) )
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -832,7 +832,6 @@ class RunAdbCommandTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
run_adb_command = RunAdbCommandTool() run_adb_command = RunAdbCommandTool()
RunAdbCommand = RunAdbCommandTool RunAdbCommand = RunAdbCommandTool
ToolRegistry.register(run_adb_command)
def get_run_adb_command_tool(ctx: ArtemisContext) -> BaseTool: def get_run_adb_command_tool(ctx: ArtemisContext) -> BaseTool:
@@ -978,7 +977,6 @@ class ManageTaskTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
manage_task = ManageTaskTool() manage_task = ManageTaskTool()
ManageTask = ManageTaskTool ManageTask = ManageTaskTool
ToolRegistry.register(manage_task)
def get_manage_task_tool(ctx: ArtemisContext) -> BaseTool: def get_manage_task_tool(ctx: ArtemisContext) -> BaseTool:
@@ -1111,7 +1109,6 @@ class RunShortAdbCommandTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
run_short_adb_command = RunShortAdbCommandTool() run_short_adb_command = RunShortAdbCommandTool()
RunShortAdbCommand = RunShortAdbCommandTool RunShortAdbCommand = RunShortAdbCommandTool
ToolRegistry.register(run_short_adb_command)
def get_run_short_adb_command_tool(ctx: ArtemisContext) -> BaseTool: def get_run_short_adb_command_tool(ctx: ArtemisContext) -> BaseTool:
@@ -1198,7 +1195,6 @@ class AnalyzeTaskOutputTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
analyze_task_output = AnalyzeTaskOutputTool() analyze_task_output = AnalyzeTaskOutputTool()
AnalyzeTaskOutput = AnalyzeTaskOutputTool AnalyzeTaskOutput = AnalyzeTaskOutputTool
ToolRegistry.register(analyze_task_output)
def get_analyze_task_output_tool(ctx: ArtemisContext) -> BaseTool: def get_analyze_task_output_tool(ctx: ArtemisContext) -> BaseTool:
+1 -2
View File
@@ -36,7 +36,7 @@ from artemis.data_engine.trace import (
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.services.llm import get_llm, invoke_llm_with_timeout_message from artemis.services.llm import get_llm, invoke_llm_with_timeout_message
from artemis.tools.base import ArtemisTool, ToolCategory, ToolRegistry from artemis.tools.base import ArtemisTool, ToolCategory
from artemis.tools.log_tool import get_analyze_logs_tool from artemis.tools.log_tool import get_analyze_logs_tool
from artemis.tools.scratchpad import get_list_notes_tool, get_read_note_tool from artemis.tools.scratchpad import get_list_notes_tool, get_read_note_tool
from artemis.tools.tool_wrapper import ( from artemis.tools.tool_wrapper import (
@@ -108,7 +108,6 @@ class AskCommitteeTool(ArtemisTool):
ask_committee = AskCommitteeTool() ask_committee = AskCommitteeTool()
AskCommittee = AskCommitteeTool AskCommittee = AskCommitteeTool
AskCommitteeToolAlias = AskCommitteeTool AskCommitteeToolAlias = AskCommitteeTool
ToolRegistry.register(ask_committee)
def get_ask_committee_tool(ctx: ArtemisContext) -> BaseTool: def get_ask_committee_tool(ctx: ArtemisContext) -> BaseTool:
@@ -22,7 +22,7 @@ from pydantic import BaseModel, Field
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
logger = get_logger(__name__) logger = get_logger(__name__)
@@ -80,7 +80,6 @@ class SubmitAnswerTool(ArtemisTool):
submit_answer = SubmitAnswerTool() submit_answer = SubmitAnswerTool()
SubmitAnswer = SubmitAnswerTool SubmitAnswer = SubmitAnswerTool
DiagnoserSubmitAnswerTool = SubmitAnswerTool DiagnoserSubmitAnswerTool = SubmitAnswerTool
ToolRegistry.register(submit_answer)
def get_submit_answer_tool(ctx: ArtemisContext) -> BaseTool: def get_submit_answer_tool(ctx: ArtemisContext) -> BaseTool:
+1 -2
View File
@@ -24,7 +24,7 @@ from artemis.context import ArtemisContext
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.tools.types import CyFunctionDetector from artemis.tools.types import CyFunctionDetector
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -100,7 +100,6 @@ class AskDiagnoserTool(ArtemisTool):
ask_diagnoser = AskDiagnoserTool() ask_diagnoser = AskDiagnoserTool()
AskDiagnoser = AskDiagnoserTool AskDiagnoser = AskDiagnoserTool
DiagnosticTool = AskDiagnoserTool DiagnosticTool = AskDiagnoserTool
ToolRegistry.register(ask_diagnoser)
def get_ask_diagnostic_agent_tool(ctx: ArtemisContext) -> BaseTool: def get_ask_diagnostic_agent_tool(ctx: ArtemisContext) -> BaseTool:
+1 -2
View File
@@ -56,7 +56,7 @@ from artemis.config import ExplorerVersion, resolve_explorer_version, settings
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolCategory, ToolRegistry from artemis.tools.base import ArtemisTool, ToolCategory
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.tools.types import CyFunctionDetector from artemis.tools.types import CyFunctionDetector
from artemis.utils.element_hit_test import find_element_at_point from artemis.utils.element_hit_test import find_element_at_point
@@ -527,7 +527,6 @@ class AskExplorerTool(ArtemisTool):
ask_explorer = AskExplorerTool() ask_explorer = AskExplorerTool()
ToolRegistry.register(ask_explorer)
def get_ask_explorer_tool( def get_ask_explorer_tool(
+1 -2
View File
@@ -45,7 +45,7 @@ from pydantic import BaseModel, Field
from artemis.core.tool_declaration import ToolDeclaration from artemis.core.tool_declaration import ToolDeclaration
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -547,7 +547,6 @@ def _recall_config(warn: bool = True) -> Any:
recall_history = RecallHistoryTool() recall_history = RecallHistoryTool()
ToolRegistry.register(recall_history)
_DECLARATION_TYPES = { _DECLARATION_TYPES = {
"query": {"type": "string"}, "query": {"type": "string"},
+1 -2
View File
@@ -23,7 +23,7 @@ from artemis.context import ArtemisContext
from artemis.data_engine.trace import trace, trace_langchain_tool from artemis.data_engine.trace import trace, trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.tools.types import CyFunctionDetector from artemis.tools.types import CyFunctionDetector
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -90,7 +90,6 @@ ask_image_processor = AskImageProcessorTool()
AskImageProcessor = AskImageProcessorTool AskImageProcessor = AskImageProcessorTool
AskVisionCoderTool = AskImageProcessorTool AskVisionCoderTool = AskImageProcessorTool
ImageProcessorTool = AskImageProcessorTool ImageProcessorTool = AskImageProcessorTool
ToolRegistry.register(ask_image_processor)
def get_ask_image_processor_tool(ctx: ArtemisContext) -> BaseTool: def get_ask_image_processor_tool(ctx: ArtemisContext) -> BaseTool:
+1 -2
View File
@@ -24,7 +24,7 @@ from artemis.context import ArtemisContext
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.tools.types import CyFunctionDetector from artemis.tools.types import CyFunctionDetector
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -93,7 +93,6 @@ class AnalyzeLogsTool(ArtemisTool):
analyze_logs = AnalyzeLogsTool() analyze_logs = AnalyzeLogsTool()
AnalyzeLogs = AnalyzeLogsTool AnalyzeLogs = AnalyzeLogsTool
LogTool = AnalyzeLogsTool LogTool = AnalyzeLogsTool
ToolRegistry.register(analyze_logs)
def get_analyze_logs_tool(ctx: ArtemisContext) -> BaseTool: def get_analyze_logs_tool(ctx: ArtemisContext) -> BaseTool:
-66
View File
@@ -1,66 +0,0 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Memory and Scratchpad Note Management tools."""
from typing import Any
from pydantic import BaseModel, Field
from artemis.tools.base import artemis_tool
_IN_MEMORY_NOTES: dict[str, str] = {}
class ReadNoteArgs(BaseModel):
"""Arguments schema for reading a note."""
title: str = Field(..., description="Note title to read.")
class SaveNoteArgs(BaseModel):
"""Arguments schema for saving a note."""
title: str = Field(..., description="Note title to create/save.")
content: str = Field(..., description="Content text of the note.")
@artemis_tool(
name="read_note",
description="[MEMORY] Reads content of an existing scratchpad note.",
args_schema=ReadNoteArgs,
category="memory",
)
async def read_note(
title: str,
ctx: Any = None, # pylint: disable=unused-argument
) -> str:
"""Reads content of an existing scratchpad note."""
return _IN_MEMORY_NOTES.get(title, f"Note '{title}' not found.")
@artemis_tool(
name="save_note",
description="[MEMORY] Saves content into the scratchpad notes system.",
args_schema=SaveNoteArgs,
category="memory",
)
async def save_note(
title: str,
content: str,
ctx: Any = None, # pylint: disable=unused-argument
) -> str:
"""Saves content into the scratchpad notes system."""
_IN_MEMORY_NOTES[title] = content
return f"Note '{title}' saved successfully."
+1 -2
View File
@@ -26,7 +26,7 @@ from artemis.controllers.platform_specific_commands_controller import (
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolCategory, ToolRegistry from artemis.tools.base import ArtemisTool, ToolCategory
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.tools.types import CyFunctionDetector from artemis.tools.types import CyFunctionDetector
from artemis.utils.app_launch_utils import launch_app_with_retries from artemis.utils.app_launch_utils import launch_app_with_retries
@@ -189,7 +189,6 @@ class LaunchAppTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
launch_app = LaunchAppTool() launch_app = LaunchAppTool()
LaunchApp = LaunchAppTool LaunchApp = LaunchAppTool
ToolRegistry.register(launch_app)
def get_launch_app_tool(ctx: ArtemisContext) -> BaseTool: def get_launch_app_tool(ctx: ArtemisContext) -> BaseTool:
+1 -2
View File
@@ -25,7 +25,7 @@ from artemis.context import ArtemisContext
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolCategory, ToolRegistry from artemis.tools.base import ArtemisTool, ToolCategory
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
from artemis.utils.ocr_api import is_ocr_configured, perform_ocr from artemis.utils.ocr_api import is_ocr_configured, perform_ocr
@@ -187,7 +187,6 @@ ocr_recognition = OcrRecognitionTool()
OcrRecognition = OcrRecognitionTool OcrRecognition = OcrRecognitionTool
OCRRecognition = OcrRecognitionTool OCRRecognition = OcrRecognitionTool
OcrTool = OcrRecognitionTool OcrTool = OcrRecognitionTool
ToolRegistry.register(ocr_recognition)
def get_ocr_tool(ctx: ArtemisContext) -> BaseTool: def get_ocr_tool(ctx: ArtemisContext) -> BaseTool:
+1 -2
View File
@@ -22,7 +22,7 @@ from artemis.context import ArtemisContext
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolCategory, ToolRegistry from artemis.tools.base import ArtemisTool, ToolCategory
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.tools.types import CyFunctionDetector from artemis.tools.types import CyFunctionDetector
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -91,7 +91,6 @@ class GetUiHierarchyTool(ArtemisTool):
get_ui_hierarchy = GetUiHierarchyTool() get_ui_hierarchy = GetUiHierarchyTool()
GetUiHierarchy = GetUiHierarchyTool GetUiHierarchy = GetUiHierarchyTool
GetUIHierarchy = GetUiHierarchyTool GetUIHierarchy = GetUiHierarchyTool
ToolRegistry.register(get_ui_hierarchy)
def get_ui_hierarchy_tool(ctx: ArtemisContext) -> BaseTool: def get_ui_hierarchy_tool(ctx: ArtemisContext) -> BaseTool:
+1 -2
View File
@@ -21,7 +21,7 @@ from artemis.context import ArtemisContext
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolCategory, ToolRegistry from artemis.tools.base import ArtemisTool, ToolCategory
from artemis.tools.mobile.log_utils import fetch_and_filter_logs from artemis.tools.mobile.log_utils import fetch_and_filter_logs
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -108,7 +108,6 @@ class ReadLogsTool(ArtemisTool):
read_logs = ReadLogsTool() read_logs = ReadLogsTool()
ReadLogs = ReadLogsTool ReadLogs = ReadLogsTool
ReadLogsToolAlias = ReadLogsTool ReadLogsToolAlias = ReadLogsTool
ToolRegistry.register(read_logs)
def get_read_logs_tool(ctx: ArtemisContext) -> BaseTool: def get_read_logs_tool(ctx: ArtemisContext) -> BaseTool:
+1 -2
View File
@@ -22,7 +22,7 @@ from artemis.context import ArtemisContext
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolCategory, ToolRegistry from artemis.tools.base import ArtemisTool, ToolCategory
from artemis.tools.mobile.log_utils import fetch_and_filter_logs from artemis.tools.mobile.log_utils import fetch_and_filter_logs
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -229,7 +229,6 @@ class SearchLogsTool(ArtemisTool):
search_logs = SearchLogsTool() search_logs = SearchLogsTool()
SearchLogs = SearchLogsTool SearchLogs = SearchLogsTool
SearchLogsToolAlias = SearchLogsTool SearchLogsToolAlias = SearchLogsTool
ToolRegistry.register(search_logs)
def get_search_logs_tool(ctx: ArtemisContext) -> BaseTool: def get_search_logs_tool(ctx: ArtemisContext) -> BaseTool:
+1 -3
View File
@@ -33,7 +33,7 @@ from artemis.data_engine.trace import (
) )
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolCategory, ToolRegistry from artemis.tools.base import ArtemisTool, ToolCategory
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.tools.types import CyFunctionDetector from artemis.tools.types import CyFunctionDetector
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -220,8 +220,6 @@ operator_object_detection = OperatorObjectDetectionTool()
OperatorObjectDetection = OperatorObjectDetectionTool OperatorObjectDetection = OperatorObjectDetectionTool
OperatorObjectDetectorTool = OperatorObjectDetectionTool OperatorObjectDetectorTool = OperatorObjectDetectionTool
ToolRegistry.register(object_detection)
def get_object_detector_tool(ctx: ArtemisContext) -> BaseTool: def get_object_detector_tool(ctx: ArtemisContext) -> BaseTool:
"""Exports object_detection as a LangChain BaseTool.""" """Exports object_detection as a LangChain BaseTool."""
-43
View File
@@ -1,43 +0,0 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Visual Object and Icon Detection perception tool."""
from pydantic import BaseModel, Field
from artemis.tools.base import artemis_tool
from artemis.drivers.base import BaseDeviceDriver
class ObjectDetectArgs(BaseModel):
"""Arguments schema for object detection."""
icon_description: str = Field(
..., description="Description of the icon, button, or graphic element."
)
@artemis_tool(
name="detect_object",
description=(
"[PERCEPTION] Detects visual icon or UI element on screen using multimodal localization."
),
args_schema=ObjectDetectArgs,
category="perception",
)
async def detect_object(
icon_description: str,
driver: BaseDeviceDriver | None = None, # pylint: disable=unused-argument
) -> str:
"""Detects visual icon or UI element on screen using multimodal localization."""
return f"Object Detect: Found '{icon_description}' at normalized [500, 500]"
-46
View File
@@ -1,46 +0,0 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Optical Character Recognition (OCR) perception tool."""
from pydantic import BaseModel, Field
from artemis.tools.base import artemis_tool
from artemis.drivers.base import BaseDeviceDriver
class OCRRecognitionArgs(BaseModel):
"""Arguments schema for OCR recognition."""
query_text: str | None = Field(
default=None,
description="Optional target text snippet to search on screen.",
)
@artemis_tool(
name="ocr_recognize",
description=(
"[PERCEPTION] Performs OCR on the active screen to extract visible text and coordinates."
),
args_schema=OCRRecognitionArgs,
category="perception",
)
async def ocr_recognize(
query_text: str | None = None,
driver: BaseDeviceDriver | None = None, # pylint: disable=unused-argument
) -> str:
"""Performs OCR on the active screen to extract visible text and coordinates."""
if query_text:
return f"OCR: Text '{query_text}' located at center [500, 500]"
return "OCR: Extracted visible text items from screen."
-45
View File
@@ -1,45 +0,0 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""XML Layout Search perception tool."""
from pydantic import BaseModel, Field
from artemis.tools.base import artemis_tool
from artemis.drivers.base import BaseDeviceDriver
class XMLSearchArgs(BaseModel):
"""Arguments schema for XML layout search."""
query: str = Field(
...,
description="Text, resource ID, or class pattern to search in UI hierarchy.",
)
@artemis_tool(
name="xml_search",
description=(
"[PERCEPTION] Searches Android UI layout hierarchy for elements"
" matching text or resource ID."
),
args_schema=XMLSearchArgs,
category="perception",
)
async def xml_search(
query: str,
driver: BaseDeviceDriver | None = None, # pylint: disable=unused-argument
) -> str:
"""Searches Android UI layout hierarchy for elements matching text or resource ID."""
return f"XML Search: Found element matching '{query}'"
+1 -11
View File
@@ -22,7 +22,7 @@ from artemis.context import ArtemisContext
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.tools.types import CyFunctionDetector from artemis.tools.types import CyFunctionDetector
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -166,7 +166,6 @@ class SaveNoteTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
save_note = SaveNoteTool() save_note = SaveNoteTool()
SaveNote = SaveNoteTool SaveNote = SaveNoteTool
ToolRegistry.register(save_note)
def get_save_note_tool(ctx: ArtemisContext) -> BaseTool: def get_save_note_tool(ctx: ArtemisContext) -> BaseTool:
@@ -246,7 +245,6 @@ class AppendNoteTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
append_note = AppendNoteTool() append_note = AppendNoteTool()
AppendNote = AppendNoteTool AppendNote = AppendNoteTool
ToolRegistry.register(append_note)
def get_append_note_tool(ctx: ArtemisContext) -> BaseTool: def get_append_note_tool(ctx: ArtemisContext) -> BaseTool:
@@ -331,7 +329,6 @@ class UpdateNoteTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
update_note = UpdateNoteTool() update_note = UpdateNoteTool()
UpdateNote = UpdateNoteTool UpdateNote = UpdateNoteTool
ToolRegistry.register(update_note)
def get_update_note_tool(ctx: ArtemisContext) -> BaseTool: def get_update_note_tool(ctx: ArtemisContext) -> BaseTool:
@@ -416,7 +413,6 @@ class ReadNoteTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
read_note = ReadNoteTool() read_note = ReadNoteTool()
ReadNote = ReadNoteTool ReadNote = ReadNoteTool
ToolRegistry.register(read_note)
def get_read_note_tool(ctx: ArtemisContext) -> BaseTool: def get_read_note_tool(ctx: ArtemisContext) -> BaseTool:
@@ -478,7 +474,6 @@ class ListNotesTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
list_notes = ListNotesTool() list_notes = ListNotesTool()
ListNotes = ListNotesTool ListNotes = ListNotesTool
ToolRegistry.register(list_notes)
def get_list_notes_tool(ctx: ArtemisContext) -> BaseTool: def get_list_notes_tool(ctx: ArtemisContext) -> BaseTool:
@@ -545,7 +540,6 @@ class ReadNotePureTool(ArtemisTool):
# Universal pure tool instance & aliases # Universal pure tool instance & aliases
read_note_pure = ReadNotePureTool() read_note_pure = ReadNotePureTool()
ReadNotePure = ReadNotePureTool ReadNotePure = ReadNotePureTool
ToolRegistry.register(read_note_pure)
def get_read_note_tool_pure(ctx: ArtemisContext) -> BaseTool: def get_read_note_tool_pure(ctx: ArtemisContext) -> BaseTool:
@@ -591,7 +585,6 @@ class ListNotesPureTool(ArtemisTool):
# Universal pure tool instance & aliases # Universal pure tool instance & aliases
list_notes_pure = ListNotesPureTool() list_notes_pure = ListNotesPureTool()
ListNotesPure = ListNotesPureTool ListNotesPure = ListNotesPureTool
ToolRegistry.register(list_notes_pure)
def get_list_notes_tool_pure(ctx: ArtemisContext) -> BaseTool: def get_list_notes_tool_pure(ctx: ArtemisContext) -> BaseTool:
@@ -656,7 +649,6 @@ class SaveNotePureTool(ArtemisTool):
# Universal pure tool instance & aliases # Universal pure tool instance & aliases
save_note_pure = SaveNotePureTool() save_note_pure = SaveNotePureTool()
SaveNotePure = SaveNotePureTool SaveNotePure = SaveNotePureTool
ToolRegistry.register(save_note_pure)
def get_save_note_tool_pure(ctx: ArtemisContext) -> BaseTool: def get_save_note_tool_pure(ctx: ArtemisContext) -> BaseTool:
@@ -725,7 +717,6 @@ class UpdateNotePureTool(ArtemisTool):
# Universal pure tool instance & aliases # Universal pure tool instance & aliases
update_note_pure = UpdateNotePureTool() update_note_pure = UpdateNotePureTool()
UpdateNotePure = UpdateNotePureTool UpdateNotePure = UpdateNotePureTool
ToolRegistry.register(update_note_pure)
def get_update_note_tool_pure(ctx: ArtemisContext) -> BaseTool: def get_update_note_tool_pure(ctx: ArtemisContext) -> BaseTool:
@@ -790,7 +781,6 @@ class AppendNotePureTool(ArtemisTool):
# Universal pure tool instance & aliases # Universal pure tool instance & aliases
append_note_pure = AppendNotePureTool() append_note_pure = AppendNotePureTool()
AppendNotePure = AppendNotePureTool AppendNotePure = AppendNotePureTool
ToolRegistry.register(append_note_pure)
def get_append_note_tool_pure(ctx: ArtemisContext) -> BaseTool: def get_append_note_tool_pure(ctx: ArtemisContext) -> BaseTool:
+16 -20
View File
@@ -13,10 +13,10 @@
# limitations under the License. # limitations under the License.
from collections.abc import Callable from collections.abc import Callable
import functools
import inspect import inspect
import time import time
from typing import Annotated, Any, get_args, get_origin from typing import Annotated, Any, get_args, get_origin
from unittest.mock import MagicMock, Mock
import uuid import uuid
from langchain_core.messages import ToolMessage from langchain_core.messages import ToolMessage
@@ -64,27 +64,19 @@ async def invoke_tool_with_injection(
""" """
final_args = dict(args) final_args = dict(args)
if isinstance(tool, (Mock, MagicMock)): def _real_callable(candidate: Any) -> Callable | None:
has_real_coro = hasattr(tool, "coroutine") and not isinstance( """Return a routine or partial whose signature supports direct injection."""
tool.coroutine, (Mock, MagicMock) target = candidate.func if isinstance(candidate, functools.partial) else candidate
) if inspect.isroutine(target):
has_real_func = hasattr(tool, "func") and not isinstance(tool.func, (Mock, MagicMock)) return candidate
if not has_real_coro and not has_real_func: return None
if (
state is not None
and hasattr(tool, "args")
and isinstance(tool.args, dict)
and "state" in tool.args
):
final_args["state"] = state
return await tool.ainvoke(final_args)
# For StructuredTool, the original function might be in tool.func or tool.coroutine # For StructuredTool, the original function might be in tool.func or tool.coroutine
func = None func = None
if hasattr(tool, "coroutine") and tool.coroutine: if getattr(tool, "coroutine", None):
func = tool.coroutine func = _real_callable(tool.coroutine)
elif hasattr(tool, "func") and tool.func: if func is None and getattr(tool, "func", None):
func = tool.func func = _real_callable(tool.func)
if func: if func:
try: try:
@@ -163,7 +155,11 @@ async def invoke_tool_with_injection(
) )
CURRENT_TRACE_ID.reset(token) CURRENT_TRACE_ID.reset(token)
else: else:
# Fallback to ainvoke if no direct func available # Fallback to ainvoke if no direct func available; tools that declare
# a "state" argument still receive the graph state.
tool_args = getattr(tool, "args", None)
if state is not None and isinstance(tool_args, dict) and "state" in tool_args:
final_args["state"] = state
return await tool.ainvoke(final_args) return await tool.ainvoke(final_args)
+1 -3
View File
@@ -31,7 +31,7 @@ from artemis.core.tool_declaration import ToolDeclaration
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolCategory, ToolRegistry from artemis.tools.base import ArtemisTool, ToolCategory
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.tools.types import CyFunctionDetector from artemis.tools.types import CyFunctionDetector
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -180,7 +180,6 @@ class VideoAnalyzerTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
video_analyzer = VideoAnalyzerTool() video_analyzer = VideoAnalyzerTool()
ToolRegistry.register(video_analyzer)
class VideoAnalyzerPureTool(ArtemisTool): class VideoAnalyzerPureTool(ArtemisTool):
@@ -231,7 +230,6 @@ class VideoAnalyzerPureTool(ArtemisTool):
# Universal pure tool instance & aliases # Universal pure tool instance & aliases
video_analyzer_pure = VideoAnalyzerPureTool() video_analyzer_pure = VideoAnalyzerPureTool()
VideoAnalyzerPure = VideoAnalyzerPureTool VideoAnalyzerPure = VideoAnalyzerPureTool
ToolRegistry.register(video_analyzer_pure)
def get_video_analyzer_tool( def get_video_analyzer_tool(
+1 -2
View File
@@ -21,7 +21,7 @@ from pydantic import BaseModel, Field
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.data_engine.trace import trace_langchain_tool from artemis.data_engine.trace import trace_langchain_tool
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.tools.base import ArtemisTool, ToolCategory, ToolRegistry from artemis.tools.base import ArtemisTool, ToolCategory
from artemis.tools.tool_wrapper import ToolWrapper from artemis.tools.tool_wrapper import ToolWrapper
from artemis.tools.types import CyFunctionDetector from artemis.tools.types import CyFunctionDetector
from artemis.utils.logger import get_logger from artemis.utils.logger import get_logger
@@ -82,7 +82,6 @@ class WaitTool(ArtemisTool):
# Universal tool instance & aliases # Universal tool instance & aliases
wait = WaitTool() wait = WaitTool()
Wait = WaitTool Wait = WaitTool
ToolRegistry.register(wait)
def get_wait_tool(ctx: ArtemisContext) -> BaseTool: def get_wait_tool(ctx: ArtemisContext) -> BaseTool:
-185
View File
@@ -27,31 +27,6 @@
"target" "target"
] ]
} }
},
"name": "click",
"description": "[ACTION] Tap/click on the target coordinate on the screen. The screen after click will be returned automatically. For buttons, checkboxes, tabs, icons, items in a list, tap ON the element. For text fields / search bars / input boxes, tap INSIDE the input box to focus it.",
"parameters": {
"type": "object",
"properties": {
"target": {
"type": "array",
"items": {
"type": "integer"
},
"description": "Normalized coordinates [x, y] in 0-1000 scale."
},
"times": {
"type": "integer",
"description": "Number of taps to perform (default 1). Set to 2 for double click."
},
"delay_ms": {
"type": "integer",
"description": "Delay between taps in milliseconds (default 100)."
}
},
"required": [
"target"
]
} }
}, },
"CLICK_SEQUENCE_TOOL": { "CLICK_SEQUENCE_TOOL": {
@@ -82,31 +57,6 @@
"sequence" "sequence"
] ]
} }
},
"name": "click_sequence",
"description": "[ACTION] Executes a sequence of taps one by one in order on the specified targets (e.g. [[500, 280], [885, 362]]). The screen will be returned ONLY after all clicks in the sequence have completed.",
"parameters": {
"type": "object",
"properties": {
"sequence": {
"type": "array",
"items": {
"type": "array",
"items": {
"type": "integer"
},
"description": "Normalized coordinates [x, y] in 0-1000 scale (e.g., [500, 280]), or a single integer element index."
},
"description": "List of targets to tap in sequence, e.g. [[500, 280], [885, 362]]."
},
"delay_ms": {
"type": "integer",
"description": "Delay between consecutive taps in milliseconds (default 50ms)."
}
},
"required": [
"sequence"
]
} }
}, },
"LONG_PRESS_TOOL": { "LONG_PRESS_TOOL": {
@@ -133,27 +83,6 @@
"target" "target"
] ]
} }
},
"name": "long_press",
"description": "[ACTION] Long press on a target coordinate on the screen. The screen after long pressing will be returned automatically.",
"parameters": {
"type": "object",
"properties": {
"target": {
"type": "array",
"items": {
"type": "integer"
},
"description": "Normalized coordinates [x, y] in 0-1000 scale."
},
"duration_ms": {
"type": "integer",
"description": "Duration of press in milliseconds (default 1000ms)."
}
},
"required": [
"target"
]
} }
}, },
"INPUT_TEXT_TOOL": { "INPUT_TEXT_TOOL": {
@@ -185,32 +114,6 @@
"target" "target"
] ]
} }
},
"name": "input_text",
"description": "[ACTION] Type text into an input field on the screen. The screen after typing will be returned automatically. Automatically taps inside the input box at target [x, y] to focus before typing.",
"parameters": {
"type": "object",
"properties": {
"text": {
"type": "string",
"description": "Text to type into the focused input field."
},
"target": {
"type": "array",
"items": {
"type": "integer"
},
"description": "Coordinates [x, y] of the input box in 0-1000 scale."
},
"clear_exist": {
"type": "boolean",
"description": "Whether to clear existing text in the input box before typing (default True)."
}
},
"required": [
"text",
"target"
]
} }
}, },
"SWIPE_TOOL": { "SWIPE_TOOL": {
@@ -257,47 +160,6 @@
} }
} }
} }
},
"name": "swipe",
"description": "[ACTION] Perform a swipe, drag, or slider-adjustment gesture on the screen. The screen and UI hierarchy after swipe will be returned automatically.\n\n• Directional Scrolling ('direction' or 'action'): Recommended for general browsing and standard page scrolling in most scenarios. Automatically computes safe swipe vectors and adaptive duration, retains a ~40% visual overlap anchor for zero-omission traversal, and prevents inertial flings. Supports scoping to a sub-container via 'target'. If it fails on certain custom layouts, fall back to specifying exact coordinates ('start' and 'end') directly.\n• Precise Coordinate Gestures ('start', 'end' or coordinates list): Best for local, fine-grained interactions such as adjusting sliders/SeekBars (e.g., volume, brightness, progress bars), drag-and-drop / list reordering, or as a reliable fallback when directional scrolling fails on specific containers. Always drag slightly PAST the target position to overcome touch slop and reliably trigger the update. When setting a slider to Maximum (100%) or Minimum (0%), swipe fully to the extreme boundary.",
"parameters": {
"type": "object",
"properties": {
"direction": {
"type": "string",
"enum": [
"up",
"down",
"left",
"right"
],
"description": "Direction for scrolling and swiping: 'up' (drags bottom-to-top, scrolling down to reveal content below), 'down' (drags top-to-bottom, scrolling up to reveal content above), 'left' (drags right-to-left, scrolling right), 'right' (drags left-to-right, scrolling left)."
},
"start": {
"type": "array",
"items": {
"type": "integer"
},
"description": "Start normalized coordinates [start_x, start_y] in 0-1000 scale."
},
"end": {
"type": "array",
"items": {
"type": "integer"
},
"description": "End normalized coordinates [end_x, end_y] in 0-1000 scale."
},
"target": {
"description": "Optional target element index (e.g. 2) or container bounds [left, top, right, bottom] to scope the directional swipe within."
},
"action": {
"description": "Backward-compatible swipe gesture: smart direction string ('up', 'down', 'left', 'right') OR precise custom coordinates [start_x, start_y, end_x, end_y] in 0-1000 scale."
},
"duration": {
"type": "integer",
"description": "Optional swipe/drag duration in milliseconds (default 800). For drag-and-drop, list reordering, or sliding/adjusting sliders (e.g., volume, brightness, SeekBars), set duration >= 1000 (e.g. 1500). If omitted for directional swipe, duration is computed automatically."
}
}
} }
}, },
"PRESS_KEY_TOOL": { "PRESS_KEY_TOOL": {
@@ -317,20 +179,6 @@
"key" "key"
] ]
} }
},
"name": "press_key",
"description": "[ACTION] Press a physical or virtual system button. The screen after pressing will be returned automatically.",
"parameters": {
"type": "object",
"properties": {
"key": {
"type": "string",
"description": "Standard Android system button name (ENTER, BACK, HOME, APP_SWITCH)."
}
},
"required": [
"key"
]
} }
}, },
"MANAGE_APP_TOOL": { "MANAGE_APP_TOOL": {
@@ -355,25 +203,6 @@
"app_name" "app_name"
] ]
} }
},
"name": "manage_app",
"description": "[ACTION] Launch or force stop a specified application. The screen after launch/stop will be returned automatically.",
"parameters": {
"type": "object",
"properties": {
"action": {
"type": "string",
"description": "The action type ('launch' or 'stop')."
},
"app_name": {
"type": "string",
"description": "Display name or package name of the application."
}
},
"required": [
"action",
"app_name"
]
} }
}, },
"WAIT_FOR_DELAY_TOOL": { "WAIT_FOR_DELAY_TOOL": {
@@ -393,20 +222,6 @@
"time_in_ms" "time_in_ms"
] ]
} }
},
"name": "wait_for_delay",
"description": "[ACTION] Pause execution and wait for a specified duration in milliseconds. The screen after pause will be returned automatically.",
"parameters": {
"type": "object",
"properties": {
"time_in_ms": {
"type": "integer",
"description": "The exact duration to pause in milliseconds (e.g., 2000 for 2s, 60000 for 1 min, 180000 for 3 mins, 300000 for 5 mins). Convert any required waiting duration into milliseconds."
}
},
"required": [
"time_in_ms"
]
} }
} }
} }
@@ -87,7 +87,7 @@ async def test_explorer_all_tools_sequential_mocked():
logger.addHandler(handler) logger.addHandler(handler)
# Attach the main agent logger to capture internal step logs # Attach the main agent logger to capture internal step logs
agent_logger = logging.getLogger("artemis.agents.explorer.explorer") agent_logger = logging.getLogger("artemis.agents.explorer")
agent_logger.setLevel(logging.INFO) agent_logger.setLevel(logging.INFO)
agent_logger.addHandler(handler) agent_logger.addHandler(handler)
@@ -238,12 +238,13 @@ async def test_explorer_all_tools_sequential_mocked():
return_value=mock_client, return_value=mock_client,
), ),
patch( patch(
"artemis.agents.explorer.explorer.StorageManager", "artemis.agents.explorer.run_setup.StorageManager",
return_value=mock_storage, return_value=mock_storage,
), ),
# get_ocr_list is only exposed when an OCR backend is configured. # get_ocr_list is only exposed when an OCR backend is configured.
patch("artemis.agents.explorer.explorer.is_ocr_configured", return_value=True), patch("artemis.agents.explorer.explorer.is_ocr_configured", return_value=True),
patch("artemis.agents.explorer.explorer._run_object_detection", mock_detect), patch("artemis.agents.explorer.run_setup.is_ocr_configured", return_value=True),
patch("artemis.agents.explorer.perception_tools._run_object_detection", mock_detect),
): ):
explorer = Explorer(mock_ctx) explorer = Explorer(mock_ctx)
result = await explorer.run( result = await explorer.run(
@@ -84,7 +84,7 @@ async def test_explorer_ask_image_processor_tool():
logger.addHandler(handler) logger.addHandler(handler)
# Attach the main agent logger to capture internal step logs # Attach the main agent logger to capture internal step logs
agent_logger = logging.getLogger("artemis.agents.explorer.explorer") agent_logger = logging.getLogger("artemis.agents.explorer")
agent_logger.setLevel(logging.INFO) agent_logger.setLevel(logging.INFO)
agent_logger.addHandler(handler) agent_logger.addHandler(handler)
+9 -24
View File
@@ -31,9 +31,9 @@ def test_diagnoser_submit_answer_tool(artemis_context):
assert "error" not in result.lower() assert "error" not in result.lower()
def test_submit_answer_tool_subclass_and_registry(): def test_submit_answer_tool_subclass():
"""Verify SubmitAnswerTool is an ArtemisTool subclass and registered in ToolRegistry.""" """Verify SubmitAnswerTool is an ArtemisTool subclass."""
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.diagnoser_submit_answer_tool import ( from artemis.tools.diagnoser_submit_answer_tool import (
DiagnoserSubmitAnswerTool, DiagnoserSubmitAnswerTool,
SubmitAnswer, SubmitAnswer,
@@ -52,11 +52,6 @@ def test_submit_answer_tool_subclass_and_registry():
assert submit_answer.category == "custom" assert submit_answer.category == "custom"
assert submit_answer.args_schema == SubmitAnswerArgs assert submit_answer.args_schema == SubmitAnswerArgs
# Registry lookup
reg_tool = ToolRegistry.get("submit_answer")
assert reg_tool is not None
assert isinstance(reg_tool, SubmitAnswerTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = submit_answer.to_genai_declaration() declaration = submit_answer.to_genai_declaration()
assert declaration.name == "submit_answer" assert declaration.name == "submit_answer"
@@ -64,9 +59,9 @@ def test_submit_answer_tool_subclass_and_registry():
assert "actionable_steps" in declaration.parameters.properties assert "actionable_steps" in declaration.parameters.properties
def test_ask_diagnoser_tool_subclass_and_registry(): def test_ask_diagnoser_tool_subclass():
"""Verify AskDiagnoserTool is an ArtemisTool subclass and registered in ToolRegistry.""" """Verify AskDiagnoserTool is an ArtemisTool subclass."""
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.diagnostic_tool import ( from artemis.tools.diagnostic_tool import (
AskDiagnoser, AskDiagnoser,
AskDiagnoserArgs, AskDiagnoserArgs,
@@ -85,20 +80,15 @@ def test_ask_diagnoser_tool_subclass_and_registry():
assert ask_diagnoser.category == "custom" assert ask_diagnoser.category == "custom"
assert ask_diagnoser.args_schema == AskDiagnoserArgs assert ask_diagnoser.args_schema == AskDiagnoserArgs
# Registry lookup
reg_tool = ToolRegistry.get("ask_diagnoser")
assert reg_tool is not None
assert isinstance(reg_tool, AskDiagnoserTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = ask_diagnoser.to_genai_declaration() declaration = ask_diagnoser.to_genai_declaration()
assert declaration.name == "ask_diagnoser" assert declaration.name == "ask_diagnoser"
assert "query" in declaration.parameters.properties assert "query" in declaration.parameters.properties
def test_analyze_logs_tool_subclass_and_registry(): def test_analyze_logs_tool_subclass():
"""Verify AnalyzeLogsTool is an ArtemisTool subclass and registered in ToolRegistry.""" """Verify AnalyzeLogsTool is an ArtemisTool subclass."""
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.log_tool import ( from artemis.tools.log_tool import (
AnalyzeLogs, AnalyzeLogs,
AnalyzeLogsArgs, AnalyzeLogsArgs,
@@ -117,11 +107,6 @@ def test_analyze_logs_tool_subclass_and_registry():
assert analyze_logs.category == "custom" assert analyze_logs.category == "custom"
assert analyze_logs.args_schema == AnalyzeLogsArgs assert analyze_logs.args_schema == AnalyzeLogsArgs
# Registry lookup
reg_tool = ToolRegistry.get("analyze_logs")
assert reg_tool is not None
assert isinstance(reg_tool, AnalyzeLogsTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = analyze_logs.to_genai_declaration() declaration = analyze_logs.to_genai_declaration()
assert declaration.name == "analyze_logs" assert declaration.name == "analyze_logs"
@@ -14,7 +14,7 @@
"""Tests for object_detector universal tools.""" """Tests for object_detector universal tools."""
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.object_detection_tool import ( from artemis.tools.object_detection_tool import (
ObjectDetection, ObjectDetection,
ObjectDetectionArgs, ObjectDetectionArgs,
@@ -29,8 +29,8 @@ from artemis.tools.object_detection_tool import (
) )
def test_object_detector_tool_subclass_and_registry(): def test_object_detector_tool_subclass():
"""Verify ObjectDetectionTool is an ArtemisTool subclass and registered in ToolRegistry.""" """Verify ObjectDetectionTool is an ArtemisTool subclass."""
assert issubclass(ObjectDetectionTool, ArtemisTool) assert issubclass(ObjectDetectionTool, ArtemisTool)
assert issubclass(ObjectDetection, ArtemisTool) assert issubclass(ObjectDetection, ArtemisTool)
assert issubclass(ObjectDetectorTool, ArtemisTool) assert issubclass(ObjectDetectorTool, ArtemisTool)
@@ -51,8 +51,3 @@ def test_object_detector_tool_subclass_and_registry():
assert operator_object_detection.name == "object_detection" assert operator_object_detection.name == "object_detection"
assert operator_object_detection.category == "perception" assert operator_object_detection.category == "perception"
assert operator_object_detection.args_schema == OperatorObjectDetectionArgs assert operator_object_detection.args_schema == OperatorObjectDetectionArgs
# Registry lookup
reg_tool = ToolRegistry.get("object_detection")
assert reg_tool is not None
assert isinstance(reg_tool, ObjectDetectionTool)
@@ -112,7 +112,7 @@ async def test_enqueued_task_keeps_its_adb_endpoint_snapshot():
return_value=original, return_value=original,
), ),
patch( patch(
"artemis.runtime.device_pool.device_pool.select_device", "artemis.runtime.device_pool.device_pool.select_device_async",
return_value="emulator-5554", return_value="emulator-5554",
), ),
): ):
@@ -230,7 +230,7 @@ async def test_queue_worker_execution_lifecycle():
patch("apps.admin_console.services.task_queue_service.session_repo") as mock_repo, patch("apps.admin_console.services.task_queue_service.session_repo") as mock_repo,
patch("apps.admin_console.services.task_queue_service.media_service"), patch("apps.admin_console.services.task_queue_service.media_service"),
patch( patch(
"artemis.runtime.device_pool.device_pool.select_device", "artemis.runtime.device_pool.device_pool.select_device_async",
return_value="emulator-5554", return_value="emulator-5554",
), ),
): ):
@@ -276,7 +276,7 @@ async def test_queue_worker_cmd_construction():
patch("apps.admin_console.services.task_queue_service.session_repo") as mock_repo, patch("apps.admin_console.services.task_queue_service.session_repo") as mock_repo,
patch("apps.admin_console.services.task_queue_service.media_service"), patch("apps.admin_console.services.task_queue_service.media_service"),
patch( patch(
"artemis.runtime.device_pool.device_pool.select_device", "artemis.runtime.device_pool.device_pool.select_device_async",
return_value="emulator-5554", return_value="emulator-5554",
), ),
): ):
@@ -594,7 +594,7 @@ async def test_cancel_task_triggers_next_pending_task():
patch("apps.admin_console.services.task_queue_service.session_repo") as mock_repo, patch("apps.admin_console.services.task_queue_service.session_repo") as mock_repo,
patch("apps.admin_console.services.task_queue_service.media_service"), patch("apps.admin_console.services.task_queue_service.media_service"),
patch( patch(
"artemis.runtime.device_pool.device_pool.select_device", "artemis.runtime.device_pool.device_pool.select_device_async",
return_value="emulator-5554", return_value="emulator-5554",
), ),
): ):
@@ -645,7 +645,7 @@ async def test_immediate_cancel_ignores_stale_ipc_and_runs_next_task():
patch("apps.admin_console.services.task_queue_service.session_repo") as mock_repo, patch("apps.admin_console.services.task_queue_service.session_repo") as mock_repo,
patch("apps.admin_console.services.task_queue_service.media_service"), patch("apps.admin_console.services.task_queue_service.media_service"),
patch( patch(
"artemis.runtime.device_pool.device_pool.select_device", "artemis.runtime.device_pool.device_pool.select_device_async",
return_value="emulator-5554", return_value="emulator-5554",
), ),
): ):
+28 -28
View File
@@ -106,7 +106,7 @@ async def test_explorer_run():
return_value=mock_client, return_value=mock_client,
), ),
patch( patch(
"artemis.agents.explorer.explorer.StorageManager", "artemis.agents.explorer.run_setup.StorageManager",
return_value=mock_storage, return_value=mock_storage,
), ),
patch("pathlib.Path.exists", return_value=True), patch("pathlib.Path.exists", return_value=True),
@@ -193,7 +193,7 @@ async def test_explorer_submit_answer():
return_value=mock_client, return_value=mock_client,
), ),
patch( patch(
"artemis.agents.explorer.explorer.StorageManager", "artemis.agents.explorer.run_setup.StorageManager",
return_value=mock_storage, return_value=mock_storage,
), ),
patch("pathlib.Path.exists", return_value=True), patch("pathlib.Path.exists", return_value=True),
@@ -339,7 +339,7 @@ async def test_explorer_submit_answer_self_correction():
return_value=mock_client, return_value=mock_client,
), ),
patch( patch(
"artemis.agents.explorer.explorer.StorageManager", "artemis.agents.explorer.run_setup.StorageManager",
return_value=mock_storage, return_value=mock_storage,
), ),
patch("pathlib.Path.exists", return_value=True), patch("pathlib.Path.exists", return_value=True),
@@ -427,10 +427,10 @@ async def test_explorer_initial_visual_marking():
return_value=mock_client, return_value=mock_client,
), ),
patch( patch(
"artemis.agents.explorer.explorer.StorageManager", "artemis.agents.explorer.run_setup.StorageManager",
return_value=mock_storage, return_value=mock_storage,
), ),
patch("artemis.agents.explorer.explorer.draw_dots") as mock_draw_dots, patch("artemis.agents.explorer.run_setup.draw_dots") as mock_draw_dots,
patch("pathlib.Path.exists", return_value=True), patch("pathlib.Path.exists", return_value=True),
patch("pathlib.Path.read_text", return_value=mock_prompt), patch("pathlib.Path.read_text", return_value=mock_prompt),
patch("builtins.open", custom_open), patch("builtins.open", custom_open),
@@ -518,10 +518,10 @@ async def test_explorer_initial_visual_marking_previous_screenshot():
return_value=mock_client, return_value=mock_client,
), ),
patch( patch(
"artemis.agents.explorer.explorer.StorageManager", "artemis.agents.explorer.run_setup.StorageManager",
return_value=mock_storage, return_value=mock_storage,
), ),
patch("artemis.agents.explorer.explorer.draw_dots") as mock_draw_dots, patch("artemis.agents.explorer.run_setup.draw_dots") as mock_draw_dots,
patch("pathlib.Path.exists", return_value=True), patch("pathlib.Path.exists", return_value=True),
patch("pathlib.Path.read_text", return_value=mock_prompt), patch("pathlib.Path.read_text", return_value=mock_prompt),
patch("builtins.open", custom_open), patch("builtins.open", custom_open),
@@ -606,10 +606,10 @@ async def test_explorer_initial_visual_marking_previous_screenshot_no_ui_tree():
return_value=mock_client, return_value=mock_client,
), ),
patch( patch(
"artemis.agents.explorer.explorer.StorageManager", "artemis.agents.explorer.run_setup.StorageManager",
return_value=mock_storage, return_value=mock_storage,
), ),
patch("artemis.agents.explorer.explorer.draw_dots") as mock_draw_dots, patch("artemis.agents.explorer.run_setup.draw_dots") as mock_draw_dots,
patch("pathlib.Path.exists", return_value=True), patch("pathlib.Path.exists", return_value=True),
patch("pathlib.Path.read_text", return_value=mock_prompt), patch("pathlib.Path.read_text", return_value=mock_prompt),
patch("builtins.open", custom_open), patch("builtins.open", custom_open),
@@ -704,10 +704,10 @@ async def test_explorer_initial_visual_marking_previous_screenshot_ocr_fusion():
return_value=mock_client, return_value=mock_client,
), ),
patch( patch(
"artemis.agents.explorer.explorer.StorageManager", "artemis.agents.explorer.run_setup.StorageManager",
return_value=mock_storage, return_value=mock_storage,
), ),
patch("artemis.agents.explorer.explorer.draw_dots") as mock_draw_dots, patch("artemis.agents.explorer.run_setup.draw_dots") as mock_draw_dots,
patch("pathlib.Path.exists", return_value=True), patch("pathlib.Path.exists", return_value=True),
patch("pathlib.Path.read_text", return_value=mock_prompt), patch("pathlib.Path.read_text", return_value=mock_prompt),
patch("builtins.open", custom_open), patch("builtins.open", custom_open),
@@ -808,19 +808,19 @@ async def test_explorer_initial_visual_marking_previous_screenshot_on_the_fly_oc
return_value=mock_client, return_value=mock_client,
), ),
patch( patch(
"artemis.agents.explorer.explorer.StorageManager", "artemis.agents.explorer.run_setup.StorageManager",
return_value=mock_storage, return_value=mock_storage,
), ),
patch( patch(
"artemis.agents.explorer.explorer.perform_ocr", "artemis.agents.explorer.run_setup.perform_ocr",
new_callable=AsyncMock, new_callable=AsyncMock,
return_value=mock_ocr_result, return_value=mock_ocr_result,
) as mock_perform_ocr, ) as mock_perform_ocr,
patch( patch(
"artemis.agents.explorer.explorer.is_ocr_configured", "artemis.agents.explorer.run_setup.is_ocr_configured",
return_value=True, return_value=True,
), ),
patch("artemis.agents.explorer.explorer.draw_dots") as mock_draw_dots, patch("artemis.agents.explorer.run_setup.draw_dots") as mock_draw_dots,
patch("pathlib.Path.exists", return_value=True), patch("pathlib.Path.exists", return_value=True),
patch("pathlib.Path.read_text", return_value=mock_prompt), patch("pathlib.Path.read_text", return_value=mock_prompt),
patch("builtins.open", custom_open), patch("builtins.open", custom_open),
@@ -933,7 +933,7 @@ async def test_explorer_denylisted_tool():
return_value=mock_client, return_value=mock_client,
), ),
patch( patch(
"artemis.agents.explorer.explorer.StorageManager", "artemis.agents.explorer.run_setup.StorageManager",
return_value=mock_storage, return_value=mock_storage,
), ),
patch("pathlib.Path.exists", return_value=True), patch("pathlib.Path.exists", return_value=True),
@@ -1014,7 +1014,7 @@ async def test_explorer_inspect_region():
patch("cv2.imwrite", return_value=True) as mock_imwrite, patch("cv2.imwrite", return_value=True) as mock_imwrite,
patch("pathlib.Path.mkdir") as mock_mkdir, patch("pathlib.Path.mkdir") as mock_mkdir,
patch("glob.glob", return_value=[]), patch("glob.glob", return_value=[]),
patch("artemis.agents.explorer.explorer.settings") as mock_settings, patch("artemis.agents.explorer.perception_tools.settings") as mock_settings,
): ):
mock_settings.TRACES_PATH = pathlib.Path("/tmp/traces") mock_settings.TRACES_PATH = pathlib.Path("/tmp/traces")
res = await explorer.exec_inspect_region( res = await explorer.exec_inspect_region(
@@ -1181,12 +1181,12 @@ async def test_explorer_ask_perception_tool():
mock_draw_dots = MagicMock() mock_draw_dots = MagicMock()
with ( with (
patch("artemis.agents.explorer.explorer.StorageManager") as storage_cls, patch("artemis.agents.explorer.run_setup.StorageManager") as storage_cls,
patch( patch(
"artemis.agents.explorer.explorer._run_object_detection", "artemis.agents.explorer.perception_tools._run_object_detection",
return_value=mock_detector_res, return_value=mock_detector_res,
), ),
patch("artemis.agents.explorer.explorer.draw_dots", mock_draw_dots), patch("artemis.agents.explorer.perception_tools.draw_dots", mock_draw_dots),
patch("artemis.utils.visualization.draw_dots", mock_draw_dots), patch("artemis.utils.visualization.draw_dots", mock_draw_dots),
patch("pathlib.Path.mkdir"), patch("pathlib.Path.mkdir"),
patch("glob.glob", return_value=[]), patch("glob.glob", return_value=[]),
@@ -1277,7 +1277,7 @@ class _FakeGenaiError(Exception):
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_generate_content_reliability_permanent_error_is_not_retried(): async def test_generate_content_reliability_permanent_error_is_not_retried():
from artemis.agents.explorer.explorer import _generate_content_with_reliability from artemis.agents.explorer.native_runner import _generate_content_with_reliability
from artemis.llm.reliability import LLMPermanentError from artemis.llm.reliability import LLMPermanentError
calls = 0 calls = 0
@@ -1296,7 +1296,7 @@ async def test_generate_content_reliability_permanent_error_is_not_retried():
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_generate_content_reliability_bad_request_is_not_retried(): async def test_generate_content_reliability_bad_request_is_not_retried():
from artemis.agents.explorer.explorer import _generate_content_with_reliability from artemis.agents.explorer.native_runner import _generate_content_with_reliability
from artemis.llm.reliability import LLMPermanentError from artemis.llm.reliability import LLMPermanentError
calls = 0 calls = 0
@@ -1314,7 +1314,7 @@ async def test_generate_content_reliability_bad_request_is_not_retried():
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_generate_content_reliability_retries_transient_then_succeeds(): async def test_generate_content_reliability_retries_transient_then_succeeds():
from artemis.agents.explorer import explorer as explorer_module from artemis.agents.explorer import native_runner as native_runner_module
calls = 0 calls = 0
sentinel = object() sentinel = object()
@@ -1326,8 +1326,8 @@ async def test_generate_content_reliability_retries_transient_then_succeeds():
raise _FakeGenaiError("429 rate limit exceeded", code=429) raise _FakeGenaiError("429 rate limit exceeded", code=429)
return sentinel return sentinel
with patch.object(explorer_module.asyncio, "sleep", new=AsyncMock()) as sleep_mock: with patch.object(native_runner_module.asyncio, "sleep", new=AsyncMock()) as sleep_mock:
result = await explorer_module._generate_content_with_reliability(op) result = await native_runner_module._generate_content_with_reliability(op)
assert result is sentinel assert result is sentinel
assert calls == 2 assert calls == 2
assert sleep_mock.await_count == 1 assert sleep_mock.await_count == 1
@@ -1335,7 +1335,7 @@ async def test_generate_content_reliability_retries_transient_then_succeeds():
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_generate_content_reliability_exhausts_to_typed_error(): async def test_generate_content_reliability_exhausts_to_typed_error():
from artemis.agents.explorer import explorer as explorer_module from artemis.agents.explorer import native_runner as native_runner_module
from artemis.llm.reliability import ( from artemis.llm.reliability import (
FailureCategory, FailureCategory,
LLMExhaustedError, LLMExhaustedError,
@@ -1349,9 +1349,9 @@ async def test_generate_content_reliability_exhausts_to_typed_error():
calls += 1 calls += 1
raise _FakeGenaiError("503 service unavailable", code=503) raise _FakeGenaiError("503 service unavailable", code=503)
with patch.object(explorer_module.asyncio, "sleep", new=AsyncMock()): with patch.object(native_runner_module.asyncio, "sleep", new=AsyncMock()):
with pytest.raises(LLMExhaustedError) as exc_info: with pytest.raises(LLMExhaustedError) as exc_info:
await explorer_module._generate_content_with_reliability(op) await native_runner_module._generate_content_with_reliability(op)
assert calls == retry_policy_for(FailureCategory.PROVIDER_UNAVAILABLE).max_attempts assert calls == retry_policy_for(FailureCategory.PROVIDER_UNAVAILABLE).max_attempts
assert exc_info.value.failure.category.value == "provider_unavailable" assert exc_info.value.failure.category.value == "provider_unavailable"
assert isinstance(exc_info.value.__cause__, _FakeGenaiError) assert isinstance(exc_info.value.__cause__, _FakeGenaiError)
@@ -37,7 +37,7 @@ def _perception_host() -> PerceptionToolsMixin:
async def test_get_ocr_list_reads_the_screen_index_without_storage() -> None: async def test_get_ocr_list_reads_the_screen_index_without_storage() -> None:
host = _perception_host() host = _perception_host()
with patch("artemis.agents.explorer.explorer.StorageManager") as storage_cls: with patch("artemis.agents.explorer.run_setup.StorageManager") as storage_cls:
result = await host.exec_get_ocr_list() result = await host.exec_get_ocr_list()
assert result == { assert result == {
+16 -13
View File
@@ -25,7 +25,8 @@ from artemis.agents.explorer.screen_index import ScreenElement, ScreenIndex
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
FACADE = "artemis.agents.explorer.explorer" RUN_SETUP = "artemis.agents.explorer.run_setup"
PERCEPTION_TOOLS = "artemis.agents.explorer.perception_tools"
W, H = 1080, 2400 W, H = 1080, 2400
#: One "Settings" button, two "Send" buttons and two OCR-only texts. #: One "Settings" button, two "Send" buttons and two OCR-only texts.
@@ -108,8 +109,10 @@ def screenshot(tmp_path):
@pytest.fixture @pytest.fixture
def no_drawing(): def no_drawing():
"""Keeps the annotation helpers away from the file system.""" """Keeps the annotation helpers away from the file system."""
draw_dots = MagicMock()
with ( with (
patch(f"{FACADE}.draw_dots") as draw_dots, patch(f"{RUN_SETUP}.draw_dots", draw_dots),
patch(f"{PERCEPTION_TOOLS}.draw_dots", draw_dots),
patch("pathlib.Path.mkdir"), patch("pathlib.Path.mkdir"),
patch("glob.glob", return_value=[]), patch("glob.glob", return_value=[]),
): ):
@@ -127,8 +130,8 @@ async def test_index_is_built_from_state_hierarchy_when_record_is_missing(screen
explorer._run_flash = AsyncMock(return_value=_outcome(fallback="nothing")) explorer._run_flash = AsyncMock(return_value=_outcome(fallback="nothing"))
with ( with (
patch(f"{FACADE}.StorageManager", return_value=_storage(None)), patch(f"{RUN_SETUP}.StorageManager", return_value=_storage(None)),
patch(f"{FACADE}.perform_ocr", new_callable=AsyncMock) as perform_ocr, patch(f"{RUN_SETUP}.perform_ocr", new_callable=AsyncMock) as perform_ocr,
): ):
await explorer.run("gear icon", "", screenshot, _state(screenshot), version="flash") await explorer.run("gear icon", "", screenshot, _state(screenshot), version="flash")
text = (await explorer._search_ui_helper("Settings", prefix="X"))["text"] text = (await explorer._search_ui_helper("Settings", prefix="X"))["text"]
@@ -145,7 +148,7 @@ async def test_index_ignores_state_hierarchy_for_another_screenshot(screenshot):
explorer._run_flash = AsyncMock(return_value=_outcome()) explorer._run_flash = AsyncMock(return_value=_outcome())
state = _state("/tmp/other.jpg") state = _state("/tmp/other.jpg")
with patch(f"{FACADE}.StorageManager", return_value=_storage(None)): with patch(f"{RUN_SETUP}.StorageManager", return_value=_storage(None)):
await explorer.run("Settings", "", screenshot, state, version="flash") await explorer.run("Settings", "", screenshot, state, version="flash")
assert len(explorer.screen_index) == 0 assert len(explorer.screen_index) == 0
@@ -224,7 +227,7 @@ async def test_search_by_coords_helper_reports_innermost_first(no_drawing):
async def test_get_ocr_list_reads_the_index(no_drawing): async def test_get_ocr_list_reads_the_index(no_drawing):
explorer = _indexed_explorer() explorer = _indexed_explorer()
with patch(f"{FACADE}.StorageManager") as storage_cls: with patch(f"{RUN_SETUP}.StorageManager") as storage_cls:
result = await explorer.exec_get_ocr_list() result = await explorer.exec_get_ocr_list()
storage_cls.assert_not_called() storage_cls.assert_not_called()
@@ -369,7 +372,7 @@ async def test_prepass_answers_unique_exact_match_without_the_engine(screenshot,
explorer._run_flash = AsyncMock() explorer._run_flash = AsyncMock()
explorer._run_loop = AsyncMock() explorer._run_loop = AsyncMock()
with patch(f"{FACADE}.StorageManager", return_value=_storage(None)): with patch(f"{RUN_SETUP}.StorageManager", return_value=_storage(None)):
raw = await explorer.run(" settings ", "", screenshot, _state(screenshot), version=version) raw = await explorer.run(" settings ", "", screenshot, _state(screenshot), version=version)
explorer._run_flash.assert_not_called() explorer._run_flash.assert_not_called()
@@ -395,7 +398,7 @@ async def test_prepass_leaves_ambiguous_matches_to_the_engine(screenshot):
engine = _outcome([{"label": "D1", "coords": [185, 854], "description": "Send"}]) engine = _outcome([{"label": "D1", "coords": [185, 854], "description": "Send"}])
explorer._run_flash = AsyncMock(return_value=engine) explorer._run_flash = AsyncMock(return_value=engine)
with patch(f"{FACADE}.StorageManager", return_value=_storage(None)): with patch(f"{RUN_SETUP}.StorageManager", return_value=_storage(None)):
raw = await explorer.run("Send", "", screenshot, _state(screenshot), version="flash") raw = await explorer.run("Send", "", screenshot, _state(screenshot), version="flash")
explorer._run_flash.assert_awaited_once_with("Send", screenshot) explorer._run_flash.assert_awaited_once_with("Send", screenshot)
@@ -408,7 +411,7 @@ async def test_prepass_without_pipe_or_match_passes_the_query_through(screenshot
engine = _outcome(fallback="Failed to detect: gear icon") engine = _outcome(fallback="Failed to detect: gear icon")
explorer._run_flash = AsyncMock(return_value=engine) explorer._run_flash = AsyncMock(return_value=engine)
with patch(f"{FACADE}.StorageManager", return_value=_storage(None)): with patch(f"{RUN_SETUP}.StorageManager", return_value=_storage(None)):
raw = await explorer.run("gear icon", "", screenshot, _state(screenshot), version="flash") raw = await explorer.run("gear icon", "", screenshot, _state(screenshot), version="flash")
explorer._run_flash.assert_awaited_once_with("gear icon", screenshot) explorer._run_flash.assert_awaited_once_with("gear icon", screenshot)
@@ -421,7 +424,7 @@ async def test_prepass_merges_partial_results_with_the_engine_outcome(screenshot
detected = {"label": "D1", "coords": [185, 854], "description": "Send"} detected = {"label": "D1", "coords": [185, 854], "description": "Send"}
explorer._run_loop = AsyncMock(return_value=_outcome([detected], fallback="two Send buttons")) explorer._run_loop = AsyncMock(return_value=_outcome([detected], fallback="two Send buttons"))
with patch(f"{FACADE}.StorageManager", return_value=_storage(None)): with patch(f"{RUN_SETUP}.StorageManager", return_value=_storage(None)):
raw = await explorer.run( raw = await explorer.run(
"Settings | Send | Welcome", "", screenshot, _state(screenshot), version="pro" "Settings | Send | Welcome", "", screenshot, _state(screenshot), version="pro"
) )
@@ -451,9 +454,9 @@ async def test_prepass_never_runs_on_the_fly_ocr_for_flash(screenshot):
explorer._run_loop = AsyncMock(return_value=_outcome()) explorer._run_loop = AsyncMock(return_value=_outcome())
with ( with (
patch(f"{FACADE}.StorageManager", return_value=_storage(record)), patch(f"{RUN_SETUP}.StorageManager", return_value=_storage(record)),
patch(f"{FACADE}.is_ocr_configured", return_value=True), patch(f"{RUN_SETUP}.is_ocr_configured", return_value=True),
patch(f"{FACADE}.perform_ocr", new_callable=AsyncMock, return_value=[]) as perform_ocr, patch(f"{RUN_SETUP}.perform_ocr", new_callable=AsyncMock, return_value=[]) as perform_ocr,
): ):
await explorer.run("gear icon", "", screenshot, _state(screenshot, []), version="flash") await explorer.run("gear icon", "", screenshot, _state(screenshot, []), version="flash")
perform_ocr.assert_not_awaited() perform_ocr.assert_not_awaited()
+21 -19
View File
@@ -28,7 +28,9 @@ from artemis.config import settings
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
FACADE = "artemis.agents.explorer.explorer" EXPLORER = "artemis.agents.explorer.explorer"
RUN_SETUP = "artemis.agents.explorer.run_setup"
UNIVERSAL_RUNNER = "artemis.agents.explorer.universal_runner"
def _context(model: str = "gemini-3.8-flash", denylist: list[str] | None = None) -> MagicMock: def _context(model: str = "gemini-3.8-flash", denylist: list[str] | None = None) -> MagicMock:
@@ -108,7 +110,7 @@ def _isolated_env(monkeypatch):
def test_construction_creates_no_genai_client(): def test_construction_creates_no_genai_client():
with patch(f"{FACADE}.genai.Client") as client_cls: with patch(f"{EXPLORER}.genai.Client") as client_cls:
explorer = Explorer(_context()) explorer = Explorer(_context())
client_cls.assert_not_called() client_cls.assert_not_called()
assert explorer.client is None assert explorer.client is None
@@ -124,7 +126,7 @@ def test_construction_creates_no_genai_client():
) )
def test_tier_sets_turn_budget_and_exposed_tools(version, max_turns, expected_tools): def test_tier_sets_turn_budget_and_exposed_tools(version, max_turns, expected_tools):
explorer = Explorer(_context()) explorer = Explorer(_context())
with patch(f"{FACADE}.is_ocr_configured", return_value=True): with patch(f"{EXPLORER}.is_ocr_configured", return_value=True):
explorer._apply_tier(get_tier(version)) explorer._apply_tier(get_tier(version))
native_names = {t.name for t in explorer.get_exposed_tools()} native_names = {t.name for t in explorer.get_exposed_tools()}
universal_names = {t["function"]["name"] for t in explorer._universal_exposed_tools()} universal_names = {t["function"]["name"] for t in explorer._universal_exposed_tools()}
@@ -137,7 +139,7 @@ def test_tier_sets_turn_budget_and_exposed_tools(version, max_turns, expected_to
def test_unconfigured_ocr_and_user_denylist_hide_tools_on_ultra(): def test_unconfigured_ocr_and_user_denylist_hide_tools_on_ultra():
explorer = Explorer(_context(denylist=["inspect_region"])) explorer = Explorer(_context(denylist=["inspect_region"]))
with patch(f"{FACADE}.is_ocr_configured", return_value=False): with patch(f"{EXPLORER}.is_ocr_configured", return_value=False):
explorer._apply_tier(get_tier("ultra")) explorer._apply_tier(get_tier("ultra"))
names = {t.name for t in explorer.get_exposed_tools()} names = {t.name for t in explorer.get_exposed_tools()}
assert "get_ocr_list" not in names assert "get_ocr_list" not in names
@@ -190,9 +192,9 @@ async def test_universal_run_without_google_key_never_touches_genai(screenshot):
with ( with (
patch.object(settings, "GOOGLE_API_KEY", None), patch.object(settings, "GOOGLE_API_KEY", None),
patch(f"{FACADE}.genai.Client") as client_cls, patch(f"{EXPLORER}.genai.Client") as client_cls,
patch(f"{FACADE}.get_llm", return_value=llm), patch(f"{UNIVERSAL_RUNNER}.get_llm", return_value=llm),
patch(f"{FACADE}.StorageManager", return_value=storage), patch(f"{RUN_SETUP}.StorageManager", return_value=storage),
): ):
explorer = Explorer(ctx) explorer = Explorer(ctx)
raw = await explorer.run("find it", "", screenshot, _state(screenshot), version="pro") raw = await explorer.run("find it", "", screenshot, _state(screenshot), version="pro")
@@ -342,7 +344,7 @@ def test_pro_prompt_only_describes_exposed_tools():
def test_ultra_prompt_describes_all_tools(): def test_ultra_prompt_describes_all_tools():
explorer = Explorer(_context()) explorer = Explorer(_context())
with patch(f"{FACADE}.is_ocr_configured", return_value=True): with patch(f"{EXPLORER}.is_ocr_configured", return_value=True):
explorer._apply_tier(get_tier("ultra")) explorer._apply_tier(get_tier("ultra"))
prompt, error = explorer._build_prompt_template(get_tier("ultra")) prompt, error = explorer._build_prompt_template(get_tier("ultra"))
assert error is None assert error is None
@@ -355,7 +357,7 @@ def test_ultra_prompt_describes_all_tools():
def test_prompt_denylist_section_only_for_user_denied_tier_tools(): def test_prompt_denylist_section_only_for_user_denied_tier_tools():
explorer = Explorer(_context(denylist=["inspect_region", "search_xml_ocr"])) explorer = Explorer(_context(denylist=["inspect_region", "search_xml_ocr"]))
with patch(f"{FACADE}.is_ocr_configured", return_value=True): with patch(f"{EXPLORER}.is_ocr_configured", return_value=True):
explorer._apply_tier(get_tier("ultra")) explorer._apply_tier(get_tier("ultra"))
ultra_prompt, _ = explorer._build_prompt_template(get_tier("ultra")) ultra_prompt, _ = explorer._build_prompt_template(get_tier("ultra"))
explorer._apply_tier(get_tier("pro")) explorer._apply_tier(get_tier("pro"))
@@ -399,8 +401,8 @@ async def test_flash_run_returns_detected_candidates(screenshot):
} }
) )
with ( with (
patch(f"{FACADE}._run_object_detection", detection), patch(f"{RUN_SETUP}._run_object_detection", detection),
patch(f"{FACADE}.genai.Client") as client_cls, patch(f"{EXPLORER}.genai.Client") as client_cls,
): ):
explorer = Explorer(_context()) explorer = Explorer(_context())
raw = await explorer.run( raw = await explorer.run(
@@ -421,7 +423,7 @@ async def test_flash_run_returns_detected_candidates(screenshot):
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_flash_run_reports_missing_detection(screenshot): async def test_flash_run_reports_missing_detection(screenshot):
with patch(f"{FACADE}._run_object_detection", AsyncMock(return_value={"detected": []})): with patch(f"{RUN_SETUP}._run_object_detection", AsyncMock(return_value={"detected": []})):
raw = await Explorer(_context()).run( raw = await Explorer(_context()).run(
"ghost", "", screenshot, _state(screenshot), version="flash" "ghost", "", screenshot, _state(screenshot), version="flash"
) )
@@ -442,8 +444,8 @@ async def test_native_ultra_run_uses_async_cache_api(screenshot):
storage.get_image.return_value = None storage.get_image.return_value = None
with ( with (
patch(f"{FACADE}.genai.Client") as client_cls, patch(f"{EXPLORER}.genai.Client") as client_cls,
patch(f"{FACADE}.StorageManager", return_value=storage), patch(f"{RUN_SETUP}.StorageManager", return_value=storage),
patch.object(settings, "EXPLORER_CACHING", None), patch.object(settings, "EXPLORER_CACHING", None),
): ):
explorer = Explorer(ctx) explorer = Explorer(ctx)
@@ -466,7 +468,7 @@ async def test_native_pro_run_skips_cache_by_default(screenshot):
storage.get_image.return_value = None storage.get_image.return_value = None
with ( with (
patch(f"{FACADE}.StorageManager", return_value=storage), patch(f"{RUN_SETUP}.StorageManager", return_value=storage),
patch.object(settings, "EXPLORER_CACHING", None), patch.object(settings, "EXPLORER_CACHING", None),
): ):
await Explorer(ctx).run("target", "", screenshot, _state(screenshot), version="pro") await Explorer(ctx).run("target", "", screenshot, _state(screenshot), version="pro")
@@ -489,7 +491,7 @@ async def test_native_file_api_uploads_and_deletes_asynchronously(screenshot, mo
storage = MagicMock() storage = MagicMock()
storage.get_image.return_value = None storage.get_image.return_value = None
with patch(f"{FACADE}.StorageManager", return_value=storage): with patch(f"{RUN_SETUP}.StorageManager", return_value=storage):
await Explorer(ctx).run("target", "", screenshot, _state(screenshot), version="pro") await Explorer(ctx).run("target", "", screenshot, _state(screenshot), version="pro")
client.aio.files.upload.assert_awaited_once_with(file=screenshot) client.aio.files.upload.assert_awaited_once_with(file=screenshot)
@@ -507,7 +509,7 @@ async def test_run_closes_http_client_on_both_engines(screenshot):
ctx._genai_client = client ctx._genai_client = client
native = Explorer(ctx) native = Explorer(ctx)
native.http_client = SimpleNamespace(aclose=AsyncMock()) native.http_client = SimpleNamespace(aclose=AsyncMock())
with patch(f"{FACADE}.StorageManager", return_value=storage): with patch(f"{RUN_SETUP}.StorageManager", return_value=storage):
await native.run("t", "", screenshot, _state(screenshot), version="pro") await native.run("t", "", screenshot, _state(screenshot), version="pro")
native_close = native.http_client # already reset native_close = native.http_client # already reset
assert native_close is None assert native_close is None
@@ -519,8 +521,8 @@ async def test_run_closes_http_client_on_both_engines(screenshot):
http_client = SimpleNamespace(aclose=AsyncMock()) http_client = SimpleNamespace(aclose=AsyncMock())
universal.http_client = http_client universal.http_client = http_client
with ( with (
patch(f"{FACADE}.StorageManager", return_value=storage), patch(f"{RUN_SETUP}.StorageManager", return_value=storage),
patch(f"{FACADE}.get_llm", return_value=llm), patch(f"{UNIVERSAL_RUNNER}.get_llm", return_value=llm),
pytest.raises(RuntimeError), pytest.raises(RuntimeError),
): ):
await universal.run("t", "", screenshot, _state(screenshot), version="pro") await universal.run("t", "", screenshot, _state(screenshot), version="pro")
+3 -5
View File
@@ -20,10 +20,8 @@ from unittest.mock import AsyncMock, MagicMock, Mock, patch
import pytest import pytest
from langchain_core.messages import AIMessage from langchain_core.messages import AIMessage
from artemis.agents.explorer.explorer import ( from artemis.agents.explorer.explorer import Explorer
UNIVERSAL_EXPLORER_TOOLS, from artemis.agents.explorer.tool_declarations import UNIVERSAL_EXPLORER_TOOLS
Explorer,
)
from artemis.config import settings from artemis.config import settings
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
@@ -106,7 +104,7 @@ async def test_run_universal_explorer_success(mock_context, tmp_path):
mock_llm.bind_tools.return_value = mock_bound mock_llm.bind_tools.return_value = mock_bound
with patch( with patch(
"artemis.agents.explorer.explorer.get_llm", "artemis.agents.explorer.universal_runner.get_llm",
return_value=mock_llm, return_value=mock_llm,
): ):
mock_state = Mock(spec=State) mock_state = Mock(spec=State)
+3 -5
View File
@@ -12,11 +12,10 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
from artemis.agents.operator.prompt_builder import ( from artemis.agents.operator.prompts import (
OperatorPromptBuilder, apply_operator_prompt_contract,
load_operator_prompts, load_operator_prompts,
) )
from artemis.agents.operator.prompts import apply_operator_prompt_contract
def test_operator_prompt_contract_matches_note_runtime_semantics(): def test_operator_prompt_contract_matches_note_runtime_semantics():
@@ -68,9 +67,8 @@ def test_operator_prompt_keeps_large_list_traversal_single_pass_until_boundary()
assert "Terminate exploration when a definitive boundary is reached" not in prompt assert "Terminate exploration when a definitive boundary is reached" not in prompt
def test_compatibility_builder_uses_canonical_operator_template(): def test_contract_strips_legacy_tool_literals():
expected = apply_operator_prompt_contract(load_operator_prompts()["main_template"]) expected = apply_operator_prompt_contract(load_operator_prompts()["main_template"])
assert OperatorPromptBuilder.build_system_message() == expected
assert "wait_for_delay(seconds=" not in expected assert "wait_for_delay(seconds=" not in expected
assert 'press_key(key="home"' not in expected assert 'press_key(key="home"' not in expected
@@ -33,7 +33,7 @@ import pytest
from langchain_core.messages import HumanMessage, SystemMessage from langchain_core.messages import HumanMessage, SystemMessage
from artemis.agents.operator.operator import OperatorNode from artemis.agents.operator.operator import OperatorNode
from artemis.agents.operator.prompt_builder import load_operator_prompts from artemis.agents.operator.prompts import load_operator_prompts
from artemis.agents.operator.prompts import ( from artemis.agents.operator.prompts import (
PLAN_HISTORY_STATIC_POINTER, PLAN_HISTORY_STATIC_POINTER,
PLAN_HISTORY_TEMPLATE_SECTION, PLAN_HISTORY_TEMPLATE_SECTION,
+1 -1
View File
@@ -20,7 +20,7 @@ import re
from jinja2 import Template from jinja2 import Template
import pytest import pytest
from artemis.agents.operator.prompt_builder import load_operator_prompts from artemis.agents.operator.prompts import load_operator_prompts
from artemis.agents.operator.prompts import ( from artemis.agents.operator.prompts import (
OPERATOR_PROMPT_TOOLSET, OPERATOR_PROMPT_TOOLSET,
apply_operator_prompt_contract, apply_operator_prompt_contract,
+6 -12
View File
@@ -208,20 +208,14 @@ def test_operator_verbs_lower_onto_manifest_actions():
) )
def test_registry_wait_for_delay_seconds_drift_stays_dead(): def test_manifest_wait_for_delay_uses_milliseconds():
"""Guards against re-growing a shadow device-action registration. """The manifest's ``wait_for_delay`` takes ``time_in_ms``, never *seconds*.
``artemis/tools/actions/device_actions.py`` used to shadow-register a second ``artemis/tools/actions/device_actions.py`` used to shadow-register a second
``wait_for_delay`` taking *seconds* while every prompt teaches milliseconds ``wait_for_delay`` taking *seconds* while every prompt teaches milliseconds.
(the last such surface, ``artemis/tools/mobile/exec_tools.py``, is deleted). The shadow ToolRegistry channel is deleted; the manifest is the only surface
The ToolRegistry must never again carry a ``wait_for_delay`` whose unit left, and its unit must stay milliseconds.
disagrees with the manifest's ``time_in_ms``.
""" """
from artemis.tools.base import ToolRegistry fields = set(tool_declaration("wait_for_delay").parameters["properties"])
tool = ToolRegistry.get("wait_for_delay")
if tool is None:
return # Not registered at all: nothing to drift.
fields = set(tool.args_schema.model_json_schema().get("properties", {}))
assert "seconds" not in fields assert "seconds" not in fields
assert "time_in_ms" in fields assert "time_in_ms" in fields
+4 -1
View File
@@ -29,7 +29,10 @@ def test_usb_policy_is_primary_when_android_reports_it_active(mock_run, lease_ty
lease_type.assert_called_once_with("device-123") lease_type.assert_called_once_with("device-123")
lease_type.return_value.cleanup_unowned_references.assert_called_once_with() lease_type.return_value.cleanup_unowned_references.assert_called_once_with()
commands = [call.args[0] for call in mock_run.call_args_list] commands = [call.args[0] for call in mock_run.call_args_list]
assert ["shell", "svc", "power", "stayon", "usb"] in [command[3:] for command in commands] # Commands are endpoint-qualified (adb -H host -P port -s serial ...);
# assert on the payload after the serial rather than a fixed prefix width.
payloads = [command[command.index("-s") + 2 :] for command in commands if "-s" in command]
assert ["shell", "svc", "power", "stayon", "usb"] in payloads
assert not any("SCREEN_BRIGHT_WAKE_LOCK" in command for command in commands) assert not any("SCREEN_BRIGHT_WAKE_LOCK" in command for command in commands)
assert not any("KEYCODE_UNKNOWN" in command for command in commands) assert not any("KEYCODE_UNKNOWN" in command for command in commands)
-34
View File
@@ -1,34 +0,0 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Unit tests for OperatorPromptBuilder."""
from artemis.agents.operator.prompt_builder import OperatorPromptBuilder
def test_operator_prompt_builder():
"""Verify prompt rendering formats variables correctly."""
system_msg = OperatorPromptBuilder.build_system_message()
assert "Android Device Operator" in system_msg
assert "click" in system_msg
human_msg = OperatorPromptBuilder.build_human_message(
goal="Open Settings",
sub_goal="Tap Network & internet",
current_turn=2,
history="1. Tapped Settings icon",
)
assert "Open Settings" in human_msg
assert "Tap Network & internet" in human_msg
assert "Current Turn: 2" in human_msg
@@ -16,7 +16,7 @@ from pathlib import Path
from unittest.mock import MagicMock, patch from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.scratchpad import ( from artemis.tools.scratchpad import (
AppendNoteArgs, AppendNoteArgs,
AppendNotePure, AppendNotePure,
@@ -35,8 +35,8 @@ def mock_ctx(tmp_path):
return ctx return ctx
def test_append_note_pure_tool_subclass_and_registry(): def test_append_note_pure_tool_subclass():
"""Verify AppendNotePureTool is a subclass of ArtemisTool and properly registered.""" """Verify AppendNotePureTool is a subclass of ArtemisTool."""
assert issubclass(AppendNotePureTool, ArtemisTool) assert issubclass(AppendNotePureTool, ArtemisTool)
assert issubclass(AppendNotePure, ArtemisTool) assert issubclass(AppendNotePure, ArtemisTool)
assert isinstance(append_note_pure, ArtemisTool) assert isinstance(append_note_pure, ArtemisTool)
@@ -46,11 +46,6 @@ def test_append_note_pure_tool_subclass_and_registry():
assert append_note_pure.category == "memory" assert append_note_pure.category == "memory"
assert append_note_pure.args_schema == AppendNoteArgs assert append_note_pure.args_schema == AppendNoteArgs
# Registry lookup
reg_tool = ToolRegistry.get("append_note_pure")
assert reg_tool is not None
assert isinstance(reg_tool, AppendNotePureTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = append_note_pure.to_genai_declaration() declaration = append_note_pure.to_genai_declaration()
assert declaration.name == "append_note_pure" assert declaration.name == "append_note_pure"
+3 -8
View File
@@ -17,7 +17,7 @@ from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.scratchpad import ( from artemis.tools.scratchpad import (
AppendNote, AppendNote,
AppendNoteArgs, AppendNoteArgs,
@@ -39,8 +39,8 @@ def mock_ctx(tmp_path):
return ctx return ctx
def test_append_note_tool_subclass_and_registry(): def test_append_note_tool_subclass():
"""Verify AppendNoteTool is a subclass of ArtemisTool and properly registered.""" """Verify AppendNoteTool is a subclass of ArtemisTool."""
assert issubclass(AppendNoteTool, ArtemisTool) assert issubclass(AppendNoteTool, ArtemisTool)
assert issubclass(AppendNote, ArtemisTool) assert issubclass(AppendNote, ArtemisTool)
assert isinstance(append_note, ArtemisTool) assert isinstance(append_note, ArtemisTool)
@@ -50,11 +50,6 @@ def test_append_note_tool_subclass_and_registry():
assert append_note.category == "memory" assert append_note.category == "memory"
assert append_note.args_schema == AppendNoteArgs assert append_note.args_schema == AppendNoteArgs
# Registry lookup
reg_tool = ToolRegistry.get("append_note")
assert reg_tool is not None
assert isinstance(reg_tool, AppendNoteTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = append_note.to_genai_declaration() declaration = append_note.to_genai_declaration()
assert declaration.name == "append_note" assert declaration.name == "append_note"
+12 -32
View File
@@ -373,9 +373,9 @@ async def test_analyze_task_output_tool(mock_get_llm, mock_ctx):
del _FINISHED_TASKS_LOGS[task_id] del _FINISHED_TASKS_LOGS[task_id]
def test_run_adb_command_tool_subclass_and_registry(): def test_run_adb_command_tool_subclass():
"""Verify RunAdbCommandTool is a subclass of ArtemisTool and properly registered.""" """Verify RunAdbCommandTool is a subclass of ArtemisTool."""
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.command_tool import ( from artemis.tools.command_tool import (
RunAdbCommand, RunAdbCommand,
RunAdbCommandArgs, RunAdbCommandArgs,
@@ -392,11 +392,6 @@ def test_run_adb_command_tool_subclass_and_registry():
assert run_adb_command.category == "system" assert run_adb_command.category == "system"
assert run_adb_command.args_schema == RunAdbCommandArgs assert run_adb_command.args_schema == RunAdbCommandArgs
# Registry lookup
reg_tool = ToolRegistry.get("run_adb_command")
assert reg_tool is not None
assert isinstance(reg_tool, RunAdbCommandTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = run_adb_command.to_genai_declaration() declaration = run_adb_command.to_genai_declaration()
assert declaration.name == "run_adb_command" assert declaration.name == "run_adb_command"
@@ -421,9 +416,9 @@ async def test_run_adb_command_tool_mock_driver_execute():
assert "pm list packages" in driver.action_history[-1]["command"] assert "pm list packages" in driver.action_history[-1]["command"]
def test_manage_task_tool_subclass_and_registry(): def test_manage_task_tool_subclass():
"""Verify ManageTaskTool is a subclass of ArtemisTool and properly registered.""" """Verify ManageTaskTool is a subclass of ArtemisTool."""
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.command_tool import ( from artemis.tools.command_tool import (
ManageTask, ManageTask,
ManageTaskArgs, ManageTaskArgs,
@@ -440,11 +435,6 @@ def test_manage_task_tool_subclass_and_registry():
assert manage_task.category == "system" assert manage_task.category == "system"
assert manage_task.args_schema == ManageTaskArgs assert manage_task.args_schema == ManageTaskArgs
# Registry lookup
reg_tool = ToolRegistry.get("manage_task")
assert reg_tool is not None
assert isinstance(reg_tool, ManageTaskTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = manage_task.to_genai_declaration() declaration = manage_task.to_genai_declaration()
assert declaration.name == "manage_task" assert declaration.name == "manage_task"
@@ -488,9 +478,9 @@ async def test_manage_task_tool_direct_execute(mock_ctx):
registry.background.clear() registry.background.clear()
def test_analyze_task_output_tool_subclass_and_registry(): def test_analyze_task_output_tool_subclass():
"""Verify AnalyzeTaskOutputTool is a subclass of ArtemisTool and properly registered.""" """Verify AnalyzeTaskOutputTool is a subclass of ArtemisTool."""
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.command_tool import ( from artemis.tools.command_tool import (
AnalyzeTaskOutput, AnalyzeTaskOutput,
AnalyzeTaskOutputArgs, AnalyzeTaskOutputArgs,
@@ -507,11 +497,6 @@ def test_analyze_task_output_tool_subclass_and_registry():
assert analyze_task_output.category == "system" assert analyze_task_output.category == "system"
assert analyze_task_output.args_schema == AnalyzeTaskOutputArgs assert analyze_task_output.args_schema == AnalyzeTaskOutputArgs
# Registry lookup
reg_tool = ToolRegistry.get("analyze_task_output")
assert reg_tool is not None
assert isinstance(reg_tool, AnalyzeTaskOutputTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = analyze_task_output.to_genai_declaration() declaration = analyze_task_output.to_genai_declaration()
assert declaration.name == "analyze_task_output" assert declaration.name == "analyze_task_output"
@@ -558,9 +543,9 @@ async def test_analyze_task_output_tool_direct_execute(mock_get_llm, mock_ctx):
del _FINISHED_TASKS_LOGS[task_id] del _FINISHED_TASKS_LOGS[task_id]
def test_run_short_adb_command_tool_subclass_and_registry(): def test_run_short_adb_command_tool_subclass():
"""Verify RunShortAdbCommandTool is a subclass of ArtemisTool and properly registered.""" """Verify RunShortAdbCommandTool is a subclass of ArtemisTool."""
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.command_tool import ( from artemis.tools.command_tool import (
RunShortAdbCommand, RunShortAdbCommand,
RunShortAdbCommandArgs, RunShortAdbCommandArgs,
@@ -577,11 +562,6 @@ def test_run_short_adb_command_tool_subclass_and_registry():
assert run_short_adb_command.category == "system" assert run_short_adb_command.category == "system"
assert run_short_adb_command.args_schema == RunShortAdbCommandArgs assert run_short_adb_command.args_schema == RunShortAdbCommandArgs
# Registry lookup
reg_tool = ToolRegistry.get("run_short_adb_command")
assert reg_tool is not None
assert isinstance(reg_tool, RunShortAdbCommandTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = run_short_adb_command.to_genai_declaration() declaration = run_short_adb_command.to_genai_declaration()
assert declaration.name == "run_short_adb_command" assert declaration.name == "run_short_adb_command"
+3 -8
View File
@@ -168,9 +168,9 @@ class TestCommitteeTool(unittest.IsolatedAsyncioTestCase):
# Clean up temp directory # Clean up temp directory
shutil.rmtree(temp_dir) shutil.rmtree(temp_dir)
def test_ask_committee_tool_subclass_and_registry(self): def test_ask_committee_tool_subclass(self):
"""Verify AskCommitteeTool is a subclass of ArtemisTool and properly registered.""" """Verify AskCommitteeTool is a subclass of ArtemisTool."""
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.committee_tool import ( from artemis.tools.committee_tool import (
AskCommittee, AskCommittee,
AskCommitteeArgs, AskCommitteeArgs,
@@ -191,11 +191,6 @@ class TestCommitteeTool(unittest.IsolatedAsyncioTestCase):
self.assertEqual(ask_committee.category, "custom") self.assertEqual(ask_committee.category, "custom")
self.assertEqual(ask_committee.args_schema, AskCommitteeArgs) self.assertEqual(ask_committee.args_schema, AskCommitteeArgs)
# Registry lookup
reg_tool = ToolRegistry.get("ask_committee")
self.assertIsNotNone(reg_tool)
self.assertIsInstance(reg_tool, AskCommitteeTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = ask_committee.to_genai_declaration() declaration = ask_committee.to_genai_declaration()
self.assertEqual(declaration.name, "ask_committee") self.assertEqual(declaration.name, "ask_committee")
+2 -4
View File
@@ -27,7 +27,7 @@ from artemis.agents.explorer.constants import (
) )
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.explorer_tool import ( from artemis.tools.explorer_tool import (
AskExplorerArgs, AskExplorerArgs,
AskExplorerTool, AskExplorerTool,
@@ -122,9 +122,7 @@ def test_description_does_not_depend_on_the_tier(version):
assert tool.version == version assert tool.version == version
def test_registry_and_wrapper_export(): def test_wrapper_export():
reg_tool = ToolRegistry.get("ask_explorer")
assert isinstance(reg_tool, AskExplorerTool)
assert ask_explorer_wrapper.tool_fn_getter is get_ask_explorer_tool assert ask_explorer_wrapper.tool_fn_getter is get_ask_explorer_tool
assert ask_explorer_wrapper.on_success_fn("x") == "x" assert ask_explorer_wrapper.on_success_fn("x") == "x"
assert "boom" in ask_explorer_wrapper.on_failure_fn("boom") assert "boom" in ask_explorer_wrapper.on_failure_fn("boom")
@@ -64,9 +64,9 @@ async def test_ask_vision_coder_success():
assert result == vision_coder_outcome assert result == vision_coder_outcome
def test_ask_image_processor_tool_subclass_and_registry(): def test_ask_image_processor_tool_subclass():
"""Verify AskImageProcessorTool is an ArtemisTool subclass and registered in ToolRegistry.""" """Verify AskImageProcessorTool is an ArtemisTool subclass."""
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.image_processor_tool import ( from artemis.tools.image_processor_tool import (
AskImageProcessor, AskImageProcessor,
AskImageProcessorTool, AskImageProcessorTool,
@@ -87,11 +87,6 @@ def test_ask_image_processor_tool_subclass_and_registry():
assert ask_image_processor.category == "custom" assert ask_image_processor.category == "custom"
assert ask_image_processor.args_schema == AskVisionCoderArgs assert ask_image_processor.args_schema == AskVisionCoderArgs
# Registry lookup
reg_tool = ToolRegistry.get("ask_image_processor")
assert reg_tool is not None
assert isinstance(reg_tool, AskImageProcessorTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = ask_image_processor.to_genai_declaration() declaration = ask_image_processor.to_genai_declaration()
assert declaration.name == "ask_image_processor" assert declaration.name == "ask_image_processor"
+3 -8
View File
@@ -17,7 +17,7 @@ from unittest.mock import AsyncMock, MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.mobile.launch_app import ( from artemis.tools.mobile.launch_app import (
LaunchApp, LaunchApp,
LaunchAppArgs, LaunchAppArgs,
@@ -49,8 +49,8 @@ def mock_state():
return MagicMock(spec=State) return MagicMock(spec=State)
def test_launch_app_tool_subclass_and_registry(): def test_launch_app_tool_subclass():
"""Verify LaunchAppTool is a subclass of ArtemisTool and properly registered.""" """Verify LaunchAppTool is a subclass of ArtemisTool."""
assert issubclass(LaunchAppTool, ArtemisTool) assert issubclass(LaunchAppTool, ArtemisTool)
assert issubclass(LaunchApp, ArtemisTool) assert issubclass(LaunchApp, ArtemisTool)
assert isinstance(launch_app, ArtemisTool) assert isinstance(launch_app, ArtemisTool)
@@ -60,11 +60,6 @@ def test_launch_app_tool_subclass_and_registry():
assert launch_app.category == "action" assert launch_app.category == "action"
assert launch_app.args_schema == LaunchAppArgs assert launch_app.args_schema == LaunchAppArgs
# Registry lookup
reg_tool = ToolRegistry.get("launch_app")
assert reg_tool is not None
assert isinstance(reg_tool, LaunchAppTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = launch_app.to_genai_declaration() declaration = launch_app.to_genai_declaration()
assert declaration.name == "launch_app" assert declaration.name == "launch_app"
@@ -15,7 +15,7 @@
from unittest.mock import MagicMock, patch from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.scratchpad import ( from artemis.tools.scratchpad import (
ListNotesArgs, ListNotesArgs,
ListNotesPure, ListNotesPure,
@@ -35,8 +35,8 @@ def mock_ctx(tmp_path):
return ctx return ctx
def test_list_notes_pure_tool_subclass_and_registry(): def test_list_notes_pure_tool_subclass():
"""Verify ListNotesPureTool is a subclass of ArtemisTool and properly registered.""" """Verify ListNotesPureTool is a subclass of ArtemisTool."""
assert issubclass(ListNotesPureTool, ArtemisTool) assert issubclass(ListNotesPureTool, ArtemisTool)
assert issubclass(ListNotesPure, ArtemisTool) assert issubclass(ListNotesPure, ArtemisTool)
assert isinstance(list_notes_pure, ArtemisTool) assert isinstance(list_notes_pure, ArtemisTool)
@@ -46,11 +46,6 @@ def test_list_notes_pure_tool_subclass_and_registry():
assert list_notes_pure.category == "memory" assert list_notes_pure.category == "memory"
assert list_notes_pure.args_schema == ListNotesArgs assert list_notes_pure.args_schema == ListNotesArgs
# Registry lookup
reg_tool = ToolRegistry.get("list_notes_pure")
assert reg_tool is not None
assert isinstance(reg_tool, ListNotesPureTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = list_notes_pure.to_genai_declaration() declaration = list_notes_pure.to_genai_declaration()
assert declaration.name == "list_notes_pure" assert declaration.name == "list_notes_pure"
+3 -8
View File
@@ -16,7 +16,7 @@ from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.scratchpad import ( from artemis.tools.scratchpad import (
ListNotes, ListNotes,
ListNotesArgs, ListNotesArgs,
@@ -39,8 +39,8 @@ def mock_ctx(tmp_path):
return ctx return ctx
def test_list_notes_tool_subclass_and_registry(): def test_list_notes_tool_subclass():
"""Verify ListNotesTool is a subclass of ArtemisTool and properly registered.""" """Verify ListNotesTool is a subclass of ArtemisTool."""
assert issubclass(ListNotesTool, ArtemisTool) assert issubclass(ListNotesTool, ArtemisTool)
assert issubclass(ListNotes, ArtemisTool) assert issubclass(ListNotes, ArtemisTool)
assert isinstance(list_notes, ArtemisTool) assert isinstance(list_notes, ArtemisTool)
@@ -50,11 +50,6 @@ def test_list_notes_tool_subclass_and_registry():
assert list_notes.category == "memory" assert list_notes.category == "memory"
assert list_notes.args_schema == ListNotesArgs assert list_notes.args_schema == ListNotesArgs
# Registry lookup
reg_tool = ToolRegistry.get("list_notes")
assert reg_tool is not None
assert isinstance(reg_tool, ListNotesTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = list_notes.to_genai_declaration() declaration = list_notes.to_genai_declaration()
assert declaration.name == "list_notes" assert declaration.name == "list_notes"
+3 -8
View File
@@ -16,7 +16,7 @@ from unittest.mock import AsyncMock, MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.log_tool import ( from artemis.tools.log_tool import (
AnalyzeLogs, AnalyzeLogs,
AnalyzeLogsArgs, AnalyzeLogsArgs,
@@ -88,8 +88,8 @@ async def test_analyze_logs_tool_no_context():
assert result == "Error: ArtemisContext is required for LogAnalyzer." assert result == "Error: ArtemisContext is required for LogAnalyzer."
def test_analyze_logs_tool_subclass_and_registry(): def test_analyze_logs_tool_subclass():
"""Verify AnalyzeLogsTool is an ArtemisTool subclass and registered in ToolRegistry.""" """Verify AnalyzeLogsTool is an ArtemisTool subclass."""
assert issubclass(AnalyzeLogsTool, ArtemisTool) assert issubclass(AnalyzeLogsTool, ArtemisTool)
assert issubclass(AnalyzeLogs, ArtemisTool) assert issubclass(AnalyzeLogs, ArtemisTool)
assert issubclass(LogTool, ArtemisTool) assert issubclass(LogTool, ArtemisTool)
@@ -100,11 +100,6 @@ def test_analyze_logs_tool_subclass_and_registry():
assert analyze_logs.category == "custom" assert analyze_logs.category == "custom"
assert analyze_logs.args_schema == AnalyzeLogsArgs assert analyze_logs.args_schema == AnalyzeLogsArgs
# Registry lookup
reg_tool = ToolRegistry.get("analyze_logs")
assert reg_tool is not None
assert isinstance(reg_tool, AnalyzeLogsTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = analyze_logs.to_genai_declaration() declaration = analyze_logs.to_genai_declaration()
assert declaration.name == "analyze_logs" assert declaration.name == "analyze_logs"
@@ -21,7 +21,7 @@ from langchain_core.messages import ToolMessage
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.object_detection_tool import ( from artemis.tools.object_detection_tool import (
ObjectDetection, ObjectDetection,
ObjectDetectionArgs, ObjectDetectionArgs,
@@ -41,7 +41,7 @@ from artemis.tools.object_detection_tool import (
import pytest import pytest
def test_object_detection_tool_subclass_and_registry(): def test_object_detection_tool_subclass():
"""Verify ObjectDetectionTool and OperatorObjectDetectionTool subclass ArtemisTool and register.""" """Verify ObjectDetectionTool and OperatorObjectDetectionTool subclass ArtemisTool and register."""
assert issubclass(ObjectDetectionTool, ArtemisTool) assert issubclass(ObjectDetectionTool, ArtemisTool)
assert issubclass(ObjectDetection, ArtemisTool) assert issubclass(ObjectDetection, ArtemisTool)
@@ -65,11 +65,6 @@ def test_object_detection_tool_subclass_and_registry():
assert operator_object_detection.category == "perception" assert operator_object_detection.category == "perception"
assert operator_object_detection.args_schema == OperatorObjectDetectionArgs assert operator_object_detection.args_schema == OperatorObjectDetectionArgs
# Registry lookup
reg_tool = ToolRegistry.get("object_detection")
assert reg_tool is not None
assert isinstance(reg_tool, ObjectDetectionTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = object_detection.to_genai_declaration() declaration = object_detection.to_genai_declaration()
assert declaration.name == "object_detection" assert declaration.name == "object_detection"
+3 -8
View File
@@ -18,7 +18,7 @@ from unittest.mock import AsyncMock, MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.mobile.ocr import ( from artemis.tools.mobile.ocr import (
OCRRecognition, OCRRecognition,
OcrArgs, OcrArgs,
@@ -63,8 +63,8 @@ def mock_state(tmp_path):
return state return state
def test_ocr_tool_subclass_and_registry(): def test_ocr_tool_subclass():
"""Verify OcrRecognitionTool is a subclass of ArtemisTool and properly registered.""" """Verify OcrRecognitionTool is a subclass of ArtemisTool."""
assert issubclass(OcrRecognitionTool, ArtemisTool) assert issubclass(OcrRecognitionTool, ArtemisTool)
assert issubclass(OcrRecognition, ArtemisTool) assert issubclass(OcrRecognition, ArtemisTool)
assert issubclass(OCRRecognition, ArtemisTool) assert issubclass(OCRRecognition, ArtemisTool)
@@ -76,11 +76,6 @@ def test_ocr_tool_subclass_and_registry():
assert ocr_recognition.category == "explorer" assert ocr_recognition.category == "explorer"
assert ocr_recognition.args_schema == OcrArgs assert ocr_recognition.args_schema == OcrArgs
# Registry lookup
reg_tool = ToolRegistry.get("ocr_recognition")
assert reg_tool is not None
assert isinstance(reg_tool, OcrRecognitionTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = ocr_recognition.to_genai_declaration() declaration = ocr_recognition.to_genai_declaration()
assert declaration.name == "ocr_recognition" assert declaration.name == "ocr_recognition"
+3 -8
View File
@@ -16,7 +16,7 @@ from unittest.mock import AsyncMock, MagicMock
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.drivers.base import BaseDeviceDriver from artemis.drivers.base import BaseDeviceDriver
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.mobile.read_hierarchy import ( from artemis.tools.mobile.read_hierarchy import (
GetUIHierarchy, GetUIHierarchy,
GetUiHierarchy, GetUiHierarchy,
@@ -46,8 +46,8 @@ def mock_driver():
return driver return driver
def test_get_ui_hierarchy_tool_subclass_and_registry(): def test_get_ui_hierarchy_tool_subclass():
"""Verify GetUiHierarchyTool is a subclass of ArtemisTool and properly registered.""" """Verify GetUiHierarchyTool is a subclass of ArtemisTool."""
assert issubclass(GetUiHierarchyTool, ArtemisTool) assert issubclass(GetUiHierarchyTool, ArtemisTool)
assert issubclass(GetUiHierarchy, ArtemisTool) assert issubclass(GetUiHierarchy, ArtemisTool)
assert issubclass(GetUIHierarchy, ArtemisTool) assert issubclass(GetUIHierarchy, ArtemisTool)
@@ -58,11 +58,6 @@ def test_get_ui_hierarchy_tool_subclass_and_registry():
assert get_ui_hierarchy.category == "diagnostic" assert get_ui_hierarchy.category == "diagnostic"
assert get_ui_hierarchy.args_schema == GetUiHierarchyArgs assert get_ui_hierarchy.args_schema == GetUiHierarchyArgs
# Registry lookup
reg_tool = ToolRegistry.get("get_ui_hierarchy")
assert reg_tool is not None
assert isinstance(reg_tool, GetUiHierarchyTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = get_ui_hierarchy.to_genai_declaration() declaration = get_ui_hierarchy.to_genai_declaration()
assert declaration.name == "get_ui_hierarchy" assert declaration.name == "get_ui_hierarchy"
+3 -8
View File
@@ -15,7 +15,7 @@
from unittest.mock import MagicMock, patch from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.mobile.read_logs import ( from artemis.tools.mobile.read_logs import (
ReadLogs, ReadLogs,
ReadLogsArgs, ReadLogsArgs,
@@ -33,8 +33,8 @@ def mock_ctx():
return ctx return ctx
def test_read_logs_tool_subclass_and_registry(): def test_read_logs_tool_subclass():
"""Verify ReadLogsTool is a subclass of ArtemisTool and properly registered.""" """Verify ReadLogsTool is a subclass of ArtemisTool."""
assert issubclass(ReadLogsTool, ArtemisTool) assert issubclass(ReadLogsTool, ArtemisTool)
assert issubclass(ReadLogs, ArtemisTool) assert issubclass(ReadLogs, ArtemisTool)
assert issubclass(ReadLogsToolAlias, ArtemisTool) assert issubclass(ReadLogsToolAlias, ArtemisTool)
@@ -45,11 +45,6 @@ def test_read_logs_tool_subclass_and_registry():
assert read_logs.category == "diagnostic" assert read_logs.category == "diagnostic"
assert read_logs.args_schema == ReadLogsArgs assert read_logs.args_schema == ReadLogsArgs
# Registry lookup
reg_tool = ToolRegistry.get("read_logs")
assert reg_tool is not None
assert isinstance(reg_tool, ReadLogsTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = read_logs.to_genai_declaration() declaration = read_logs.to_genai_declaration()
assert declaration.name == "read_logs" assert declaration.name == "read_logs"
+3 -8
View File
@@ -15,7 +15,7 @@
from unittest.mock import MagicMock, patch from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.scratchpad import ( from artemis.tools.scratchpad import (
ReadNoteArgs, ReadNoteArgs,
ReadNotePure, ReadNotePure,
@@ -35,8 +35,8 @@ def mock_ctx(tmp_path):
return ctx return ctx
def test_read_note_pure_tool_subclass_and_registry(): def test_read_note_pure_tool_subclass():
"""Verify ReadNotePureTool is a subclass of ArtemisTool and properly registered.""" """Verify ReadNotePureTool is a subclass of ArtemisTool."""
assert issubclass(ReadNotePureTool, ArtemisTool) assert issubclass(ReadNotePureTool, ArtemisTool)
assert issubclass(ReadNotePure, ArtemisTool) assert issubclass(ReadNotePure, ArtemisTool)
assert isinstance(read_note_pure, ArtemisTool) assert isinstance(read_note_pure, ArtemisTool)
@@ -46,11 +46,6 @@ def test_read_note_pure_tool_subclass_and_registry():
assert read_note_pure.category == "memory" assert read_note_pure.category == "memory"
assert read_note_pure.args_schema == ReadNoteArgs assert read_note_pure.args_schema == ReadNoteArgs
# Registry lookup
reg_tool = ToolRegistry.get("read_note_pure")
assert reg_tool is not None
assert isinstance(reg_tool, ReadNotePureTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = read_note_pure.to_genai_declaration() declaration = read_note_pure.to_genai_declaration()
assert declaration.name == "read_note_pure" assert declaration.name == "read_note_pure"
+3 -8
View File
@@ -16,7 +16,7 @@ from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.scratchpad import ( from artemis.tools.scratchpad import (
ReadNote, ReadNote,
ReadNoteArgs, ReadNoteArgs,
@@ -39,8 +39,8 @@ def mock_ctx(tmp_path):
return ctx return ctx
def test_read_note_tool_subclass_and_registry(): def test_read_note_tool_subclass():
"""Verify ReadNoteTool is a subclass of ArtemisTool and properly registered.""" """Verify ReadNoteTool is a subclass of ArtemisTool."""
assert issubclass(ReadNoteTool, ArtemisTool) assert issubclass(ReadNoteTool, ArtemisTool)
assert issubclass(ReadNote, ArtemisTool) assert issubclass(ReadNote, ArtemisTool)
assert isinstance(read_note, ArtemisTool) assert isinstance(read_note, ArtemisTool)
@@ -50,11 +50,6 @@ def test_read_note_tool_subclass_and_registry():
assert read_note.category == "memory" assert read_note.category == "memory"
assert read_note.args_schema == ReadNoteArgs assert read_note.args_schema == ReadNoteArgs
# Registry lookup
reg_tool = ToolRegistry.get("read_note")
assert reg_tool is not None
assert isinstance(reg_tool, ReadNoteTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = read_note.to_genai_declaration() declaration = read_note.to_genai_declaration()
assert declaration.name == "read_note" assert declaration.name == "read_note"
+3 -8
View File
@@ -16,7 +16,7 @@ from pathlib import Path
from unittest.mock import MagicMock, patch from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.scratchpad import ( from artemis.tools.scratchpad import (
SaveNoteArgs, SaveNoteArgs,
SaveNotePure, SaveNotePure,
@@ -35,8 +35,8 @@ def mock_ctx(tmp_path):
return ctx return ctx
def test_save_note_pure_tool_subclass_and_registry(): def test_save_note_pure_tool_subclass():
"""Verify SaveNotePureTool is a subclass of ArtemisTool and properly registered.""" """Verify SaveNotePureTool is a subclass of ArtemisTool."""
assert issubclass(SaveNotePureTool, ArtemisTool) assert issubclass(SaveNotePureTool, ArtemisTool)
assert issubclass(SaveNotePure, ArtemisTool) assert issubclass(SaveNotePure, ArtemisTool)
assert isinstance(save_note_pure, ArtemisTool) assert isinstance(save_note_pure, ArtemisTool)
@@ -46,11 +46,6 @@ def test_save_note_pure_tool_subclass_and_registry():
assert save_note_pure.category == "memory" assert save_note_pure.category == "memory"
assert save_note_pure.args_schema == SaveNoteArgs assert save_note_pure.args_schema == SaveNoteArgs
# Registry lookup
reg_tool = ToolRegistry.get("save_note_pure")
assert reg_tool is not None
assert isinstance(reg_tool, SaveNotePureTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = save_note_pure.to_genai_declaration() declaration = save_note_pure.to_genai_declaration()
assert declaration.name == "save_note_pure" assert declaration.name == "save_note_pure"
+3 -8
View File
@@ -17,7 +17,7 @@ from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.scratchpad import ( from artemis.tools.scratchpad import (
SaveNote, SaveNote,
SaveNoteArgs, SaveNoteArgs,
@@ -39,8 +39,8 @@ def mock_ctx(tmp_path):
return ctx return ctx
def test_save_note_tool_subclass_and_registry(): def test_save_note_tool_subclass():
"""Verify SaveNoteTool is a subclass of ArtemisTool and properly registered in ToolRegistry.""" """Verify SaveNoteTool is a subclass of ArtemisTool."""
assert issubclass(SaveNoteTool, ArtemisTool) assert issubclass(SaveNoteTool, ArtemisTool)
assert issubclass(SaveNote, ArtemisTool) assert issubclass(SaveNote, ArtemisTool)
assert isinstance(save_note, ArtemisTool) assert isinstance(save_note, ArtemisTool)
@@ -50,11 +50,6 @@ def test_save_note_tool_subclass_and_registry():
assert save_note.category == "memory" assert save_note.category == "memory"
assert save_note.args_schema == SaveNoteArgs assert save_note.args_schema == SaveNoteArgs
# Registry lookup
reg_tool = ToolRegistry.get("save_note")
assert reg_tool is not None
assert isinstance(reg_tool, SaveNoteTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = save_note.to_genai_declaration() declaration = save_note.to_genai_declaration()
assert declaration.name == "save_note" assert declaration.name == "save_note"
+3 -8
View File
@@ -15,7 +15,7 @@
from unittest.mock import MagicMock, patch from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.mobile.search_logs import ( from artemis.tools.mobile.search_logs import (
SearchLogs, SearchLogs,
SearchLogsArgs, SearchLogsArgs,
@@ -147,8 +147,8 @@ def mock_ctx():
return MagicMock(spec=ArtemisContext) return MagicMock(spec=ArtemisContext)
def test_search_logs_tool_subclass_and_registry(): def test_search_logs_tool_subclass():
"""Verify SearchLogsTool is a subclass of ArtemisTool and properly registered.""" """Verify SearchLogsTool is a subclass of ArtemisTool."""
assert issubclass(SearchLogsTool, ArtemisTool) assert issubclass(SearchLogsTool, ArtemisTool)
assert issubclass(SearchLogs, ArtemisTool) assert issubclass(SearchLogs, ArtemisTool)
assert issubclass(SearchLogsToolAlias, ArtemisTool) assert issubclass(SearchLogsToolAlias, ArtemisTool)
@@ -159,11 +159,6 @@ def test_search_logs_tool_subclass_and_registry():
assert search_logs.category == "diagnostic" assert search_logs.category == "diagnostic"
assert search_logs.args_schema == SearchLogsArgs assert search_logs.args_schema == SearchLogsArgs
# Registry lookup
reg_tool = ToolRegistry.get("search_logs")
assert reg_tool is not None
assert isinstance(reg_tool, SearchLogsTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = search_logs.to_genai_declaration() declaration = search_logs.to_genai_declaration()
assert declaration.name == "search_logs" assert declaration.name == "search_logs"
@@ -16,7 +16,7 @@ from pathlib import Path
from unittest.mock import MagicMock, patch from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.scratchpad import ( from artemis.tools.scratchpad import (
UpdateNoteArgs, UpdateNoteArgs,
UpdateNotePure, UpdateNotePure,
@@ -36,8 +36,8 @@ def mock_ctx(tmp_path):
return ctx return ctx
def test_update_note_pure_tool_subclass_and_registry(): def test_update_note_pure_tool_subclass():
"""Verify UpdateNotePureTool is a subclass of ArtemisTool and properly registered.""" """Verify UpdateNotePureTool is a subclass of ArtemisTool."""
assert issubclass(UpdateNotePureTool, ArtemisTool) assert issubclass(UpdateNotePureTool, ArtemisTool)
assert issubclass(UpdateNotePure, ArtemisTool) assert issubclass(UpdateNotePure, ArtemisTool)
assert isinstance(update_note_pure, ArtemisTool) assert isinstance(update_note_pure, ArtemisTool)
@@ -47,11 +47,6 @@ def test_update_note_pure_tool_subclass_and_registry():
assert update_note_pure.category == "memory" assert update_note_pure.category == "memory"
assert update_note_pure.args_schema == UpdateNoteArgs assert update_note_pure.args_schema == UpdateNoteArgs
# Registry lookup
reg_tool = ToolRegistry.get("update_note_pure")
assert reg_tool is not None
assert isinstance(reg_tool, UpdateNotePureTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = update_note_pure.to_genai_declaration() declaration = update_note_pure.to_genai_declaration()
assert declaration.name == "update_note_pure" assert declaration.name == "update_note_pure"
+3 -8
View File
@@ -17,7 +17,7 @@ from unittest.mock import MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.scratchpad import ( from artemis.tools.scratchpad import (
UpdateNote, UpdateNote,
UpdateNoteArgs, UpdateNoteArgs,
@@ -40,8 +40,8 @@ def mock_ctx(tmp_path):
return ctx return ctx
def test_update_note_tool_subclass_and_registry(): def test_update_note_tool_subclass():
"""Verify UpdateNoteTool is a subclass of ArtemisTool and properly registered.""" """Verify UpdateNoteTool is a subclass of ArtemisTool."""
assert issubclass(UpdateNoteTool, ArtemisTool) assert issubclass(UpdateNoteTool, ArtemisTool)
assert issubclass(UpdateNote, ArtemisTool) assert issubclass(UpdateNote, ArtemisTool)
assert isinstance(update_note, ArtemisTool) assert isinstance(update_note, ArtemisTool)
@@ -51,11 +51,6 @@ def test_update_note_tool_subclass_and_registry():
assert update_note.category == "memory" assert update_note.category == "memory"
assert update_note.args_schema == UpdateNoteArgs assert update_note.args_schema == UpdateNoteArgs
# Registry lookup
reg_tool = ToolRegistry.get("update_note")
assert reg_tool is not None
assert isinstance(reg_tool, UpdateNoteTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = update_note.to_genai_declaration() declaration = update_note.to_genai_declaration()
assert declaration.name == "update_note" assert declaration.name == "update_note"
@@ -15,7 +15,7 @@
from unittest.mock import AsyncMock, MagicMock, patch from unittest.mock import AsyncMock, MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.video_tool import ( from artemis.tools.video_tool import (
VideoAnalyzerArgs, VideoAnalyzerArgs,
VideoAnalyzerPure, VideoAnalyzerPure,
@@ -32,8 +32,8 @@ def mock_ctx():
return ctx return ctx
def test_video_analyzer_pure_tool_subclass_and_registry(): def test_video_analyzer_pure_tool_subclass():
"""Verify VideoAnalyzerPureTool is a subclass of ArtemisTool and properly registered.""" """Verify VideoAnalyzerPureTool is a subclass of ArtemisTool."""
assert issubclass(VideoAnalyzerPureTool, ArtemisTool) assert issubclass(VideoAnalyzerPureTool, ArtemisTool)
assert issubclass(VideoAnalyzerPure, ArtemisTool) assert issubclass(VideoAnalyzerPure, ArtemisTool)
assert isinstance(video_analyzer_pure, ArtemisTool) assert isinstance(video_analyzer_pure, ArtemisTool)
@@ -43,11 +43,6 @@ def test_video_analyzer_pure_tool_subclass_and_registry():
assert video_analyzer_pure.category == "perception" assert video_analyzer_pure.category == "perception"
assert video_analyzer_pure.args_schema == VideoAnalyzerArgs assert video_analyzer_pure.args_schema == VideoAnalyzerArgs
# Registry lookup
reg_tool = ToolRegistry.get("video_analyzer_pure")
assert reg_tool is not None
assert isinstance(reg_tool, VideoAnalyzerPureTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = video_analyzer_pure.to_genai_declaration() declaration = video_analyzer_pure.to_genai_declaration()
assert declaration.name == "video_analyzer_pure" assert declaration.name == "video_analyzer_pure"
+3 -8
View File
@@ -16,7 +16,7 @@ from unittest.mock import AsyncMock, MagicMock, patch
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.video_tool import ( from artemis.tools.video_tool import (
DIAGNOSER_VIDEO_ANALYZER_DOCSTRING, DIAGNOSER_VIDEO_ANALYZER_DOCSTRING,
OPERATOR_VIDEO_ANALYZER_DOCSTRING, OPERATOR_VIDEO_ANALYZER_DOCSTRING,
@@ -41,8 +41,8 @@ def mock_state():
return MagicMock(spec=State) return MagicMock(spec=State)
def test_video_analyzer_tool_subclass_and_registry(): def test_video_analyzer_tool_subclass():
"""Verify VideoAnalyzerTool is a subclass of ArtemisTool and properly registered.""" """Verify VideoAnalyzerTool is a subclass of ArtemisTool."""
assert issubclass(VideoAnalyzerTool, ArtemisTool) assert issubclass(VideoAnalyzerTool, ArtemisTool)
assert isinstance(video_analyzer, ArtemisTool) assert isinstance(video_analyzer, ArtemisTool)
assert isinstance(video_analyzer, VideoAnalyzerTool) assert isinstance(video_analyzer, VideoAnalyzerTool)
@@ -51,11 +51,6 @@ def test_video_analyzer_tool_subclass_and_registry():
assert video_analyzer.category == "perception" assert video_analyzer.category == "perception"
assert video_analyzer.args_schema == VideoAnalyzerArgs assert video_analyzer.args_schema == VideoAnalyzerArgs
# Registry lookup
reg_tool = ToolRegistry.get("video_analyzer")
assert reg_tool is not None
assert isinstance(reg_tool, VideoAnalyzerTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = video_analyzer.to_genai_declaration() declaration = video_analyzer.to_genai_declaration()
assert declaration.name == "video_analyzer" assert declaration.name == "video_analyzer"
+3 -8
View File
@@ -17,7 +17,7 @@ import time
from unittest.mock import AsyncMock, MagicMock from unittest.mock import AsyncMock, MagicMock
from artemis.context import ArtemisContext from artemis.context import ArtemisContext
from artemis.tools.base import ArtemisTool, ToolRegistry from artemis.tools.base import ArtemisTool
from artemis.tools.wait_tool import ( from artemis.tools.wait_tool import (
Wait, Wait,
WaitArgs, WaitArgs,
@@ -35,8 +35,8 @@ def mock_ctx():
return ctx return ctx
def test_wait_tool_subclass_and_registry(): def test_wait_tool_subclass():
"""Verify WaitTool is a subclass of ArtemisTool and properly registered.""" """Verify WaitTool is a subclass of ArtemisTool."""
assert issubclass(WaitTool, ArtemisTool) assert issubclass(WaitTool, ArtemisTool)
assert issubclass(Wait, ArtemisTool) assert issubclass(Wait, ArtemisTool)
assert isinstance(wait, ArtemisTool) assert isinstance(wait, ArtemisTool)
@@ -46,11 +46,6 @@ def test_wait_tool_subclass_and_registry():
assert wait.category == "system" assert wait.category == "system"
assert wait.args_schema == WaitArgs assert wait.args_schema == WaitArgs
# Registry lookup
reg_tool = ToolRegistry.get("wait")
assert reg_tool is not None
assert isinstance(reg_tool, WaitTool)
# GenAI FunctionDeclaration export # GenAI FunctionDeclaration export
declaration = wait.to_genai_declaration() declaration = wait.to_genai_declaration()
assert declaration.name == "wait" assert declaration.name == "wait"
+1 -14
View File
@@ -21,7 +21,6 @@ from artemis.agents.explorer.explorer import Explorer
from artemis.config.settings import Settings from artemis.config.settings import Settings
from artemis.graph.perception import perception_node from artemis.graph.perception import perception_node
from artemis.graph.state import State from artemis.graph.state import State
from artemis.tools.base import ToolRegistry
from artemis.tools.index import get_tools_from_wrappers from artemis.tools.index import get_tools_from_wrappers
from artemis.tools.mobile.ocr import ( from artemis.tools.mobile.ocr import (
ocr_recognition, ocr_recognition,
@@ -126,20 +125,8 @@ def test_ocr_tool_not_exposed_when_unconfigured():
with patch("artemis.tools.mobile.ocr.is_ocr_configured", return_value=False): with patch("artemis.tools.mobile.ocr.is_ocr_configured", return_value=False):
assert not ocr_recognition.is_available() assert not ocr_recognition.is_available()
# ToolRegistry.list_tools filters out unavailable tools
available_tools = ToolRegistry.list_tools(available_only=True)
assert "ocr_recognition" not in [t.name for t in available_tools]
# ToolRegistry.get_langchain_tools filters out unavailable tools
mock_ctx = MagicMock()
lc_tools = ToolRegistry.get_langchain_tools(mock_ctx, available_only=True)
assert "ocr_recognition" not in [t.name for t in lc_tools]
# ToolRegistry.get_genai_declarations filters out unavailable tools
genai_tools = ToolRegistry.get_genai_declarations(available_only=True)
assert "ocr_recognition" not in [t.name for t in genai_tools]
# get_tools_from_wrappers excludes ocr_recognition_wrapper # get_tools_from_wrappers excludes ocr_recognition_wrapper
mock_ctx = MagicMock()
wrapped_tools = get_tools_from_wrappers(mock_ctx, [ocr_recognition_wrapper]) wrapped_tools = get_tools_from_wrappers(mock_ctx, [ocr_recognition_wrapper])
assert len(wrapped_tools) == 0 assert len(wrapped_tools) == 0